PompierService::save() - Code Metrics - SDIS62/core-ops - Measure and Improve Code Quality continuously with Scrutinizer

PompierService::save() F
last analyzed 2016-02-05 16:26 UTC

↳ Parent: PompierService

Complexity

Conditions	16
Paths	772

Size

Total Lines	61
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	8
Bugs	3	Features	3

Metric	Value
c	8
b	3
f	3
dl	0
loc	61
rs	3.2786
cc	16
eloc	35
nc	772
nop	1

How to fix Long Method Complexity

<?php

namespace SDIS62\Core\Ops\Service;

use SDIS62\Core\Ops\Entity\Coordinates;
use SDIS62\Core\Ops\Entity\Pompier;
use SDIS62\Core\Ops\Entity\Statut;
use SDIS62\Core\Ops\Exception\InvalidPompierException;
use SDIS62\Core\Ops\Repository\CentreRepositoryInterface;
use SDIS62\Core\Ops\Repository\PompierRepositoryInterface;

class PompierService
{
    /**
     * Initialisation du service avec les repository utilisés.
     *
     * @param SDIS62\Core\Ops\Repository\PompierRepositoryInterface $pompier_repository
     * @param SDIS62\Core\Ops\Repository\CentreRepositoryInterface  $centre_repository
     */
    public function __construct(PompierRepositoryInterface $pompier_repository,
                                CentreRepositoryInterface $centre_repository
    ) {
        $this->pompier_repository = $pompier_repository;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->centre_repository  = $centre_repository;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Retourne un pompier correspondant au matricule spécifié.
     *
     * @param string $matricule
     *
     * @return SDIS62\Core\Ops\Entity\Pompier
     */
    public function find($matricule)
    {
        return $this->pompier_repository->find($matricule);
    }

    /**
     * Retourne un pompier correspondant au nom spécifié.
     *
     * @param string $name
     * @param int    $count Par défaut: 20
     * @param int    $page  Par défaut: 1
     *
     * @return SDIS62\Core\Ops\Entity\Pompier
     */
    public function findAllByName($name, $count = 20, $page = 1)
    {
        return $this->pompier_repository->findAllByName($name, $count, $page);
    }

    /**
     * Sauvegarde d'un pompier.
     *
     * @param array $data
     * @param array $id_pompier Optionnel
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return SDIS62\Core\Ops\Entity\Pompier
     */
    public function save($data)
    {
        if (!empty($data['matricule'])) {
            $pompier = $this->pompier_repository->find($data['matricule']);
        }

        if (empty($pompier)) {
            $centre = $this->centre_repository->find($data['centre']);

            if (empty($centre)) {
                return;
            }

            switch ($data['type']) {
                case 'pompier' :
                    $pompier = new Pompier($data['name'], $data['matricule'], $centre);
                    break;
                case 'specialiste' :
                    $pompier = new Pompier\SpecialistePompier($data['name'], $data['matricule'], $centre);
                    break;
                default:
                    throw new InvalidPompierException();
            }
        }

        if (!empty($data['centre'])) {
            $pompier->setCentre($this->centre_repository->find($data['centre']));
        }

        if (!empty($data['name'])) {
            $pompier->setName($data['name']);
        }

        if (!empty($data['specialites'])) {
            $pompier->setSpecialites($data['specialites']);
        }

        if (!empty($data['phone_number'])) {
            $pompier->setPhoneNumber($data['phone_number']);
        }

        if (!empty($data['statut'])) {
            $pompier->setStatut(Statut::getByName($data['statut']));
        }

        if (array_key_exists('pro', $data)) {
            $pompier->setPro($data['pro'] === true);
        }

        if (!empty($data['coordinates']) && is_array($data['coordinates']) && count($data['coordinates']) >= 2) {
            $pompier->setCoordinates(new Coordinates(
                $data['coordinates'][0],
                $data['coordinates'][1],
                array_key_exists(2, $data['coordinates']) ? $data['coordinates'][2] : null
            ));
        }

        $this->pompier_repository->save($pompier);

        return $pompier;
    }

    /**
     * Suppression d'un pompier.
     *
     * @param string $matricule
     *
     * @return SDIS62\Core\Ops\Entity\Pompier
     */
    public function delete($matricule)
    {
        $pompier = $this->find($matricule);

        if (empty($pompier)) {
            return;
        }

        $this->pompier_repository->delete($pompier);

        return $pompier;
    }
}


1			<?php
2
3			namespace SDIS62\Core\Ops\Service;
4
5			use SDIS62\Core\Ops\Entity\Coordinates;
6			use SDIS62\Core\Ops\Entity\Pompier;
7			use SDIS62\Core\Ops\Entity\Statut;
8			use SDIS62\Core\Ops\Exception\InvalidPompierException;
9			use SDIS62\Core\Ops\Repository\CentreRepositoryInterface;
10			use SDIS62\Core\Ops\Repository\PompierRepositoryInterface;
11
12			class PompierService
13			{
14			/**
15			* Initialisation du service avec les repository utilisés.
16			*
17			* @param SDIS62\Core\Ops\Repository\PompierRepositoryInterface $pompier_repository
18			* @param SDIS62\Core\Ops\Repository\CentreRepositoryInterface $centre_repository
19			*/
20			public function __construct(PompierRepositoryInterface $pompier_repository,
21			CentreRepositoryInterface $centre_repository
22			) {
23			$this->pompier_repository = $pompier_repository;
			0 ignored issues – show Bug introduced 2016-02-05 16:26 UTC by Report Bug Copy Issue Report The property `pompier_repository` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
24			$this->centre_repository = $centre_repository;
			0 ignored issues – show Bug introduced 2016-02-05 16:26 UTC by Report Bug Copy Issue Report The property `centre_repository` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			}
26
27			/**
28			* Retourne un pompier correspondant au matricule spécifié.
29			*
30			* @param string $matricule
31			*
32			* @return SDIS62\Core\Ops\Entity\Pompier
33			*/
34			public function find($matricule)
35			{
36			return $this->pompier_repository->find($matricule);
37			}
38
39			/**
40			* Retourne un pompier correspondant au nom spécifié.
41			*
42			* @param string $name
43			* @param int $count Par défaut: 20
44			* @param int $page Par défaut: 1
45			*
46			* @return SDIS62\Core\Ops\Entity\Pompier
47			*/
48			public function findAllByName($name, $count = 20, $page = 1)
49			{
50			return $this->pompier_repository->findAllByName($name, $count, $page);
51			}
52
53			/**
54			* Sauvegarde d'un pompier.
55			*
56			* @param array $data
57			* @param array $id_pompier Optionnel
			0 ignored issues – show Bug introduced 2016-02-05 16:26 UTC by Report Bug Copy Issue Report There is no parameter named `$id_pompier`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
58			*
59			* @return SDIS62\Core\Ops\Entity\Pompier
60			*/
61			public function save($data)
62			{
63			if (!empty($data['matricule'])) {
64			$pompier = $this->pompier_repository->find($data['matricule']);
65			}
66
67			if (empty($pompier)) {
68			$centre = $this->centre_repository->find($data['centre']);
69
70			if (empty($centre)) {
71			return;
72			}
73
74			switch ($data['type']) {
75			case 'pompier' :
76			$pompier = new Pompier($data['name'], $data['matricule'], $centre);
77			break;
78			case 'specialiste' :
79			$pompier = new Pompier\SpecialistePompier($data['name'], $data['matricule'], $centre);
80			break;
81			default:
82			throw new InvalidPompierException();
83			}
84			}
85
86			if (!empty($data['centre'])) {
87			$pompier->setCentre($this->centre_repository->find($data['centre']));
88			}
89
90			if (!empty($data['name'])) {
91			$pompier->setName($data['name']);
92			}
93
94			if (!empty($data['specialites'])) {
95			$pompier->setSpecialites($data['specialites']);
96			}
97
98			if (!empty($data['phone_number'])) {
99			$pompier->setPhoneNumber($data['phone_number']);
100			}
101
102			if (!empty($data['statut'])) {
103			$pompier->setStatut(Statut::getByName($data['statut']));
104			}
105
106			if (array_key_exists('pro', $data)) {
107			$pompier->setPro($data['pro'] === true);
108			}
109
110			if (!empty($data['coordinates']) && is_array($data['coordinates']) && count($data['coordinates']) >= 2) {
111			$pompier->setCoordinates(new Coordinates(
112			$data['coordinates'][0],
113			$data['coordinates'][1],
114			array_key_exists(2, $data['coordinates']) ? $data['coordinates'][2] : null
115			));
116			}
117
118			$this->pompier_repository->save($pompier);
119
120			return $pompier;
121			}
122
123			/**
124			* Suppression d'un pompier.
125			*
126			* @param string $matricule
127			*
128			* @return SDIS62\Core\Ops\Entity\Pompier
129			*/
130			public function delete($matricule)
131			{
132			$pompier = $this->find($matricule);
133
134			if (empty($pompier)) {
135			return;
136			}
137
138			$this->pompier_repository->delete($pompier);
139
140			return $pompier;
141			}
142			}
143

SDIS62 / core-ops

PompierService::save() F last analyzed 2016-02-05 16:26 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like

PompierService::save() F
last analyzed 2016-02-05 16:26 UTC