SDIS62\Core\Ops\Entity\Engagement

Complexity

Total Complexity

19

Size/Duplication

Total Lines	195
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	6
Bugs	3	Features	1

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	getType()	0	8	2
A	getCreated()	0	4	1
A	getUpdated()	0	4	1
A	setUpdated()	0	14	4
A	getEnded()	0	4	1
A	setEnded()	0	11	3
A	isEnded()	0	4	1
A	getEvenements()	0	14	3
A	addEvenement()	0	8	1
A	getIntervention()	0	4	1

<?php

namespace SDIS62\Core\Ops\Entity;

use Datetime;
use Doctrine\Common\Collections\ArrayCollection;
use SDIS62\Core\Common\Entity\IdentityTrait;
use SDIS62\Core\Ops\Exception\InvalidEngagementException;

abstract class Engagement
{
    use IdentityTrait;

    /**
     * Création de l'engagement.
     *
     * @var Datetime
     */
    protected $created;

    /**
     * Date de mise à jour.
     *
     * @var Datetime
     */
    protected $updated;

    /**
     * Fin de l'engagement.
     *
     * @var Datetime
     */
    protected $ended;

    /**
     * Evenements particuliers de l'engagement.
     *
     * @var SDIS62\Core\Ops\Entity\Evenement[]
     */
    protected $evenements;

    /**
     * Intervention concernée.
     *
     * @var SDIS62\Core\Ops\Entity\Intervention
     */
    protected $intervention;

    /**
     * Ajout d'un engagement à une intervention.
     *
     * @param SDIS62\Core\Ops\Entity\Intervention $intervention
     */
    public function __construct(Intervention $intervention)
    {
        $this->intervention = $intervention;

It seems like $intervention of type object<SDIS62\Core\Ops\Entity\Intervention> is incompatible with the declared type object<SDIS62\Core\Ops\Entity\SDIS62\Core\Ops\Entity\Intervention> of property $intervention.

        $this->intervention->addEngagement($this);

        $this->evenements = new ArrayCollection();

It seems like new \Doctrine\Common\Collections\ArrayCollection() of type object<Doctrine\Common\Collections\ArrayCollection> is incompatible with the declared type array<integer,object<SDIS62\Core\Ops\Entity\SDIS62\Core\Ops\Entity\Evenement>> of property $evenements.

        $this->created = new Datetime('NOW');
    }

    /**
     * Get the value of Type de l'engagement.
     *
     * @return string
     */
    final public function getType()
    {
        if (empty($this->type)) {

The property type does not exist. Did you maybe forget to declare it?

            throw new InvalidEngagementException(get_class($this).' doit avoir un $type');
        }

        return $this->type;
    }

    /**
     * Get the value of Création de l'engagement.
     *
     * @return Datetime
     */
    public function getCreated()
    {
        return $this->created;
    }

    /**
     * Get the value of Date de mise à jour.
     *
     * @return Datetime|null
     */
    public function getUpdated()
    {
        return $this->updated;
    }

    /**
     * Set the value of Date de mise à jour (la date doit être supérieure à la date de création).
     *
     * @param Datetime|string updated Format d-m-Y H:i:s
     *
     * @return self
     */
    public function setUpdated($updated = null)
    {
        if (empty($updated)) {
            $this->setUpdated(new Datetime());
        } else {
            $updated = $updated instanceof Datetime ? $updated : DateTime::createFromFormat('d-m-Y H:i:s', (string) $updated);
        }

        if ($updated > $this->created) {
            $this->updated = $updated;
        }

        return $this;
    }

    /**
     * Get the value of Date de fin.
     *
     * @return Datetime|null
     */
    public function getEnded()
    {
        return $this->ended;
    }

    /**
     * Set the value of Date de fin (la date doit être supérieure à la date de création).
     *
     * @param Datetime|string ended Format d-m-Y H:i:s
     *
     * @return self
     */
    public function setEnded($ended)
    {
        $ended = $ended instanceof Datetime ? $ended : DateTime::createFromFormat('d-m-Y H:i:s', (string) $ended);

        if ($ended > $this->created) {
            $this->ended = $ended;

It seems like $ended can also be of type false. However, the property $ended is declared as type object<DateTime>. Maybe add an additional type check?

            $this->setUpdated();
        }

        return $this;
    }

    /**
     * Retourne vrai si l'engagement est terminée.
     *
     * @return bool
     */
    public function isEnded()
    {
        return !empty($this->ended);
    }

    /**
     * Get the value of Evenements particuliers de l'engagement.
     *
     * @return SDIS62\Core\Ops\Entity\Evenement[]
     */
    public function getEvenements()
    {
        if (count($this->evenements) == 0) {
            return [];
        }

        $evenements = $this->evenements->toArray();

The method toArray cannot be called on $this->evenements (of type array<integer,object<SDIS62\Core\Ops\Entity\SDIS62\Core\Ops\Entity\Evenement>>).

        @usort($evenements, function ($a, $b) {

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            return $a->getDate()->format('U') < $b->getDate()->format('U') ? -1 : 1;
        });

        return $evenements;
    }

    /**
     * Ajoute un evenement à l'engagement.
     *
     * @param SDIS62\Core\Ops\Entity\Evenement $evenement
     *
     * @return self
     */
    public function addEvenement(Evenement $evenement)
    {
        $this->evenements[] = $evenement;

        $this->setUpdated();

        return $this;
    }

    /**
     * Get the value of Intervention.
     *
     * @return SDIS62\Core\Ops\Entity\Intervention
     */
    public function getIntervention()
    {
        return $this->intervention;
    }
}