satdigitalinvoice.layout.make_layout() - Code Metrics - Inspection of "Initial" - SAT-CFDI/python-satdigitalinvoice - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — main ( 87466e...0f1820 )

by Sat CFDI

created 2023-03-28 06:54 UTC

satdigitalinvoice.layout.make_layout() B

↳ Parent: satdigitalinvoice.layout

Complexity

Conditions

Size

Total Lines	80
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	60
dl	0
loc	80
rs	8.309
c	0
b	0
f	0
cc	1
nop	1

How to fix Long Method

from datetime import date, timedelta

import PySimpleGUI as sg
from babel.dates import format_date
# noinspection PyUnresolvedReferences
from satcfdi.transform.catalog import CATALOGS

# from .credential_loader import EMAIL_MANAGER, FACTURAS_SOURCE, PAC_SERVICE, FIEL_SIGNER, AJUSTES_DIR, CORREO_FIRMA
from .log_tools import *

logging.basicConfig(level=logging.DEBUG)
logger = LogAdapter(logging.getLogger())

FORMA_PAGO = CATALOGS['{http://www.sat.gob.mx/sitio_internet/cfd/catalogos}c_FormaPago']
TEXT_PADDING = ((5, 0), 3)
RTEXT_PADDING = ((0, 0), 3)


def make_layout(facturas_manager):
    numero_facturas = len(facturas_manager["Facturas"])

    # LAYOUT
    button_column = [
        sg.Button("Preparar Facturas", key="prepare_facturas"),
        sg.Text("Periodo:", pad=TEXT_PADDING),
        sg.Input(format_date(date.today(), locale='es_MX', format="'Mes de' MMMM 'del' y").upper(), key="periodo", change_submits=True),
        sg.Text("De:", pad=TEXT_PADDING),
        sg.Input("1", key="inicio", size=(4, 1), change_submits=True),
        sg.Text("Hasta:", pad=TEXT_PADDING),
        sg.Input(str(numero_facturas), key="final", size=(4, 1), change_submits=True),
    ]

    c_second = [
        sg.Column(
            [
                [
                    sg.Text("Factura:", pad=TEXT_PADDING),
                    sg.Input("", size=(30, 1), key="factura_pagar", change_submits=True),
                ],
                [
                    sg.Button("Status", key="status_sat"),
                    sg.Button("Descarga", key="descarga"),
                ]
            ],
            pad=0
        ),
        sg.VSeparator(),
        sg.Column(
            [
                [
                    sg.CalendarButton("FechaPago:", format='%Y-%m-%d', title="FechaPago", no_titlebar=False, target="fecha_pago", pad=TEXT_PADDING),
                    sg.Input("", size=(12, 1), key="fecha_pago", change_submits=True),
                    sg.Text("FormaPago:", pad=TEXT_PADDING),
                    sg.Combo([Code(k, v) for k, v in FORMA_PAGO.items()], default_value=Code("03", FORMA_PAGO["03"]), key="forma_pago", change_submits=True, size=(34, 1))
                ],
                [
                    sg.Button("Preparar Pago", key="prepare_pago"),
                ]
            ],
            pad=0
        )
    ]

    button_column_third = [
        sg.Button("Preparar Correos", key="prepare_correos"),
        sg.Button("Facturas Pendientes", key="facturas_pendientes"),
        sg.Checkbox("Ver Detallado", default=False, key="detallado"),
        sg.VSeparator(),
        sg.Button("Ajuste Anual", key="preparar_ajuste_anual"),
        sg.Text("Año-Mes:", pad=TEXT_PADDING),
        sg.Input((date.today() + timedelta(days=31)).strftime('%Y-%m'), size=(8, 1), key="anio_mes_ajuste"),
        sg.Text("Ajuste:", pad=TEXT_PADDING),
        sg.Input("", size=(6, 1), key="ajuste_porcentaje"),
        sg.Text("%", pad=RTEXT_PADDING),
        sg.VSeparator(),
        sg.Text("Recuperar:", pad=TEXT_PADDING),
        sg.Button("Emitidas", key="recuperar_emitidas"),
        sg.Button("Recibidas", key="recuperar_recibidas"),
        sg.Text("Dias:", pad=TEXT_PADDING),
        sg.Input("40", size=(4, 1), key="recuperar_dias"),
    ]

    button_column_low = [
        sg.Button("Validar Clientes", key="validate_clientes"),
        sg.Button("Crear Facturas", disabled=True, key="crear_facturas"),
        sg.Button("Enviar Correos", disabled=True, key="enviar_correos"),

    ]

    # ----- Full layout -----
    return [
        button_column,
        [sg.HSeparator()],
        c_second,
        [sg.HSeparator()],
        button_column_third,
        [sg.Output(expand_x=True, expand_y=True, key="console")],
        button_column_low
    ]


class InvoiceButtonManager:
    def __init__(self, button, detallado):
        self._cfdis = []
        self.button = button
        self.detallado = detallado

    def set_invoices(self, invoices):
        self._cfdis = invoices
        for i, cfdi in enumerate(self._cfdis, start=1):
            log_item(f"FACTURA NUMERO: {i}")
            log_cfdi(cfdi, detailed=self.detallado.get())

        self.style_button()

    def clear(self):
        cfdis = self._cfdis
        self._cfdis = []
        self.style_button()
        return cfdis

    def style_button(self):
        self.button.update(
            disabled=len(self._cfdis) == 0
        )


class EmailButtonManager:
    def __init__(self, button):
        self._emails = {}
        self.button = button

    def set_invoices(self, invoices):
        self._emails = invoices

        for i, (receptor_rfc, (notify_invoices, facturas_pendientes)) in enumerate(invoices.items(), start=1):
            log_item(f"CORREO NUMERO: {i}")
            log_email(receptor_rfc, notify_invoices, facturas_pendientes)

        self.style_button()

    def clear(self):
        emails = self._emails
        self._emails = {}
        self.style_button()
        return emails

    def style_button(self):
        self.button.update(
            disabled=len(self._emails) == 0
        )



1			from datetime import date, timedelta
2
3			import PySimpleGUI as sg
4			from babel.dates import format_date
5			# noinspection PyUnresolvedReferences
6			from satcfdi.transform.catalog import CATALOGS
7
8			# from .credential_loader import EMAIL_MANAGER, FACTURAS_SOURCE, PAC_SERVICE, FIEL_SIGNER, AJUSTES_DIR, CORREO_FIRMA
9			from .log_tools import *
10
11			logging.basicConfig(level=logging.DEBUG)
12			logger = LogAdapter(logging.getLogger())
13
14			FORMA_PAGO = CATALOGS['{http://www.sat.gob.mx/sitio_internet/cfd/catalogos}c_FormaPago']
15			TEXT_PADDING = ((5, 0), 3)
16			RTEXT_PADDING = ((0, 0), 3)
17
18
19			def make_layout(facturas_manager):
20			numero_facturas = len(facturas_manager["Facturas"])
21
22			# LAYOUT
23			button_column = [
24			sg.Button("Preparar Facturas", key="prepare_facturas"),
25			sg.Text("Periodo:", pad=TEXT_PADDING),
26			sg.Input(format_date(date.today(), locale='es_MX', format="'Mes de' MMMM 'del' y").upper(), key="periodo", change_submits=True),
27			sg.Text("De:", pad=TEXT_PADDING),
28			sg.Input("1", key="inicio", size=(4, 1), change_submits=True),
29			sg.Text("Hasta:", pad=TEXT_PADDING),
30			sg.Input(str(numero_facturas), key="final", size=(4, 1), change_submits=True),
31			]
32
33			c_second = [
34			sg.Column(
35			[
36			[
37			sg.Text("Factura:", pad=TEXT_PADDING),
38			sg.Input("", size=(30, 1), key="factura_pagar", change_submits=True),
39			],
40			[
41			sg.Button("Status", key="status_sat"),
42			sg.Button("Descarga", key="descarga"),
43			]
44			],
45			pad=0
46			),
47			sg.VSeparator(),
48			sg.Column(
49			[
50			[
51			sg.CalendarButton("FechaPago:", format='%Y-%m-%d', title="FechaPago", no_titlebar=False, target="fecha_pago", pad=TEXT_PADDING),
52			sg.Input("", size=(12, 1), key="fecha_pago", change_submits=True),
53			sg.Text("FormaPago:", pad=TEXT_PADDING),
54			sg.Combo([Code(k, v) for k, v in FORMA_PAGO.items()], default_value=Code("03", FORMA_PAGO["03"]), key="forma_pago", change_submits=True, size=(34, 1))
55			],
56			[
57			sg.Button("Preparar Pago", key="prepare_pago"),
58			]
59			],
60			pad=0
61			)
62			]
63
64			button_column_third = [
65			sg.Button("Preparar Correos", key="prepare_correos"),
66			sg.Button("Facturas Pendientes", key="facturas_pendientes"),
67			sg.Checkbox("Ver Detallado", default=False, key="detallado"),
68			sg.VSeparator(),
69			sg.Button("Ajuste Anual", key="preparar_ajuste_anual"),
70			sg.Text("Año-Mes:", pad=TEXT_PADDING),
71			sg.Input((date.today() + timedelta(days=31)).strftime('%Y-%m'), size=(8, 1), key="anio_mes_ajuste"),
72			sg.Text("Ajuste:", pad=TEXT_PADDING),
73			sg.Input("", size=(6, 1), key="ajuste_porcentaje"),
74			sg.Text("%", pad=RTEXT_PADDING),
75			sg.VSeparator(),
76			sg.Text("Recuperar:", pad=TEXT_PADDING),
77			sg.Button("Emitidas", key="recuperar_emitidas"),
78			sg.Button("Recibidas", key="recuperar_recibidas"),
79			sg.Text("Dias:", pad=TEXT_PADDING),
80			sg.Input("40", size=(4, 1), key="recuperar_dias"),
81			]
82
83			button_column_low = [
84			sg.Button("Validar Clientes", key="validate_clientes"),
85			sg.Button("Crear Facturas", disabled=True, key="crear_facturas"),
86			sg.Button("Enviar Correos", disabled=True, key="enviar_correos"),
87
88			]
89
90			# ----- Full layout -----
91			return [
92			button_column,
93			[sg.HSeparator()],
94			c_second,
95			[sg.HSeparator()],
96			button_column_third,
97			[sg.Output(expand_x=True, expand_y=True, key="console")],
98			button_column_low
99			]
100
101
102			class InvoiceButtonManager:
103			def __init__(self, button, detallado):
104			self._cfdis = []
105			self.button = button
106			self.detallado = detallado
107
108			def set_invoices(self, invoices):
109			self._cfdis = invoices
110			for i, cfdi in enumerate(self._cfdis, start=1):
111			log_item(f"FACTURA NUMERO: {i}")
112			log_cfdi(cfdi, detailed=self.detallado.get())
113
114			self.style_button()
115
116			def clear(self):
117			cfdis = self._cfdis
118			self._cfdis = []
119			self.style_button()
120			return cfdis
121
122			def style_button(self):
123			self.button.update(
124			disabled=len(self._cfdis) == 0
125			)
126
127
128			class EmailButtonManager:
129			def __init__(self, button):
130			self._emails = {}
131			self.button = button
132
133			def set_invoices(self, invoices):
134			self._emails = invoices
135
136			for i, (receptor_rfc, (notify_invoices, facturas_pendientes)) in enumerate(invoices.items(), start=1):
137			log_item(f"CORREO NUMERO: {i}")
138			log_email(receptor_rfc, notify_invoices, facturas_pendientes)
139
140			self.style_button()
141
142			def clear(self):
143			emails = self._emails
144			self._emails = {}
145			self.style_button()
146			return emails
147
148			def style_button(self):
149			self.button.update(
150			disabled=len(self._emails) == 0
151			)
152
153

SAT-CFDI / python-satdigitalinvoice

Push — main ( 87466e...0f1820 )

satdigitalinvoice.layout.make_layout() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like