satdigitalinvoice.layout.make_layout() - Code Metrics - Inspection of "Initial" - SAT-CFDI/python-satdigitalinvoice - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( d86a79...f53e5f )

by Sat CFDI

created 2023-04-05 17:35 UTC

satdigitalinvoice.layout.make_layout() B

↳ Parent: satdigitalinvoice.layout

Complexity

Conditions

Size

Total Lines	86
Code Lines	68

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	68
dl	0
loc	86
rs	8.0472
c	0
b	0
f	0
cc	1
nop	1

How to fix Long Method

from datetime import date

import PySimpleGUI as sg
from dateutil.relativedelta import relativedelta
# noinspection PyUnresolvedReferences
from satcfdi.transform.catalog import CATALOGS

from .log_tools import *

FORMA_PAGO = CATALOGS['{http://www.sat.gob.mx/sitio_internet/cfd/catalogos}c_FormaPago']
TEXT_PADDING = ((5, 0), 3)
RTEXT_PADDING = ((0, 0), 3)


def make_layout(has_fiel):
    # LAYOUT
    button_column = [
        sg.Button("Preparar Facturas", key="prepare_facturas", border_width=0),
        sg.Text("Año-Mes:", pad=TEXT_PADDING),
        sg.Input(date.today().strftime('%Y-%m'), size=(8, 1), key="periodo", change_submits=True),
        sg.Text("De La:", pad=TEXT_PADDING),
        sg.Input("1", key="inicio", size=(4, 1), change_submits=True),
        sg.Text("Hasta:", pad=TEXT_PADDING),
        sg.Input("", key="final", size=(4, 1), change_submits=True),
        sg.Text("             ", pad=TEXT_PADDING),
        sg.Text("Exportar:", pad=TEXT_PADDING),
        sg.Button("Excel", key="ver_excel", border_width=0),
        sg.Button("HTML", key="ver_html", border_width=0),
    ]

    c_second = [
        sg.Column(
            [
                [
                    sg.Button("Buscar Factura:", key="buscar_factura", border_width=0, pad=TEXT_PADDING),
                    sg.Input("", size=(40, 1), key="factura_pagar", enable_events=True),
                    sg.Button("Descarga", key="descarga", border_width=0, disabled=True),
                ],
                [
                    sg.Button("Status SAT", key="status_sat", border_width=0, disabled=True),
                    sg.Button("PUE Pagada", key="pago_pue", border_width=0, disabled=True),
                    sg.Button("PPD Ignorar", key="ignorar_ppd", border_width=0, disabled=True),
                    sg.Button("Email Notificada", key="email_notificada", border_width=0, disabled=True),
                    sg.Button(" Ver PDF ", key="ver_factura", border_width=0, disabled=True),
                ]
            ],
            pad=0
        ),
        sg.VSeparator(),
        sg.Column(
            [
                [
                    sg.CalendarButton("FechaPago:", format='%Y-%m-%d', title="FechaPago", no_titlebar=False, target="fecha_pago", pad=TEXT_PADDING, border_width=0,
                                      key="fecha_pago_select", disabled=True),
                    sg.Input("", size=(12, 1), key="fecha_pago", change_submits=True, disabled=True),
                    sg.Text("FormaPago:", pad=TEXT_PADDING),
                    sg.Combo([Code(k, v) for k, v in FORMA_PAGO.items()], default_value=Code("03", FORMA_PAGO["03"]), key="forma_pago", change_submits=True, size=(34, 1), disabled=True),

                ],
                [
                    sg.Button("Preparar Comprobante Pago", key="prepare_pago", border_width=0, disabled=True),
                ]
            ],
            pad=0
        )
    ]

    button_column_third = [
        sg.Button("Preparar Correos", key="prepare_correos", border_width=0),
        sg.Button("Facturas Pendientes", key="facturas_pendientes", border_width=0),
        sg.Button("Clientes", key="prepare_clientes", border_width=0),
        sg.VSeparator(),
        sg.Button("Ajuste:", key="preparar_ajuste_anual", border_width=0),
        sg.Text("Año-Mes:", pad=TEXT_PADDING),
        sg.Input((date.today() + relativedelta(months=1)).strftime('%Y-%m'), size=(8, 1), key="anio_mes_ajuste"),
        sg.Input("", size=(6, 1), key="ajuste_porcentaje"),
        sg.Text("%", pad=RTEXT_PADDING),
        sg.VSeparator(),
        sg.Text("Recuperar:", pad=TEXT_PADDING),
        sg.Button("Emitidas", key="recuperar_emitidas", border_width=0, disabled=not has_fiel),
        sg.Button("Recibidas", key="recuperar_recibidas", border_width=0, disabled=not has_fiel),
        sg.Text("Dias:", pad=TEXT_PADDING),
        sg.Input("40", size=(4, 1), key="recuperar_dias", disabled=not has_fiel),
    ]

    button_column_low = [
        sg.Button("Enviar ", disabled=True, key="crear_facturas", border_width=0),
        sg.Push(),
        sg.Checkbox("Ver Detallado", default=False, key="detallado"),
        sg.Button("Acerca De", key="about", border_width=0),
    ]

    # ----- Full layout -----
    return [
        button_column,
        [sg.HSeparator()],
        c_second,
        [sg.HSeparator()],
        button_column_third,
        [sg.Multiline(expand_x=True, expand_y=True, key="console", write_only=True, autoscroll=True, reroute_stdout=True)],
        button_column_low
    ]


class ActionButtonManager:
    def __init__(self, button):
        self._name = ""
        self._items = []
        self.button = button

    def set_items(self, name, items):
        self._name = name
        self._items = items
        self.style_button()

    def clear(self):
        name = self._name
        items = self._items
        self._name = ""
        self._items = []
        self.style_button()
        return name, items

    def style_button(self):
        self.button.update(
            f"Enviar {len(self._items)} {self._name.capitalize()}" if self._items else f"Enviar {self._name.capitalize()}",
            disabled=len(self._items) == 0
        )


1			from datetime import date
2
3			import PySimpleGUI as sg
4			from dateutil.relativedelta import relativedelta
5			# noinspection PyUnresolvedReferences
6			from satcfdi.transform.catalog import CATALOGS
7
8			from .log_tools import *
9
10			FORMA_PAGO = CATALOGS['{http://www.sat.gob.mx/sitio_internet/cfd/catalogos}c_FormaPago']
11			TEXT_PADDING = ((5, 0), 3)
12			RTEXT_PADDING = ((0, 0), 3)
13
14
15			def make_layout(has_fiel):
16			# LAYOUT
17			button_column = [
18			sg.Button("Preparar Facturas", key="prepare_facturas", border_width=0),
19			sg.Text("Año-Mes:", pad=TEXT_PADDING),
20			sg.Input(date.today().strftime('%Y-%m'), size=(8, 1), key="periodo", change_submits=True),
21			sg.Text("De La:", pad=TEXT_PADDING),
22			sg.Input("1", key="inicio", size=(4, 1), change_submits=True),
23			sg.Text("Hasta:", pad=TEXT_PADDING),
24			sg.Input("", key="final", size=(4, 1), change_submits=True),
25			sg.Text(" ", pad=TEXT_PADDING),
26			sg.Text("Exportar:", pad=TEXT_PADDING),
27			sg.Button("Excel", key="ver_excel", border_width=0),
28			sg.Button("HTML", key="ver_html", border_width=0),
29			]
30
31			c_second = [
32			sg.Column(
33			[
34			[
35			sg.Button("Buscar Factura:", key="buscar_factura", border_width=0, pad=TEXT_PADDING),
36			sg.Input("", size=(40, 1), key="factura_pagar", enable_events=True),
37			sg.Button("Descarga", key="descarga", border_width=0, disabled=True),
38			],
39			[
40			sg.Button("Status SAT", key="status_sat", border_width=0, disabled=True),
41			sg.Button("PUE Pagada", key="pago_pue", border_width=0, disabled=True),
42			sg.Button("PPD Ignorar", key="ignorar_ppd", border_width=0, disabled=True),
43			sg.Button("Email Notificada", key="email_notificada", border_width=0, disabled=True),
44			sg.Button(" Ver PDF ", key="ver_factura", border_width=0, disabled=True),
45			]
46			],
47			pad=0
48			),
49			sg.VSeparator(),
50			sg.Column(
51			[
52			[
53			sg.CalendarButton("FechaPago:", format='%Y-%m-%d', title="FechaPago", no_titlebar=False, target="fecha_pago", pad=TEXT_PADDING, border_width=0,
54			key="fecha_pago_select", disabled=True),
55			sg.Input("", size=(12, 1), key="fecha_pago", change_submits=True, disabled=True),
56			sg.Text("FormaPago:", pad=TEXT_PADDING),
57			sg.Combo([Code(k, v) for k, v in FORMA_PAGO.items()], default_value=Code("03", FORMA_PAGO["03"]), key="forma_pago", change_submits=True, size=(34, 1), disabled=True),
			0 ignored issues – show Comprehensibility Best Practice introduced 2023-03-31 17:35 UTC by Report Bug Copy Issue Report The variable `Code` does not seem to be defined. Loading history...
58			],
59			[
60			sg.Button("Preparar Comprobante Pago", key="prepare_pago", border_width=0, disabled=True),
61			]
62			],
63			pad=0
64			)
65			]
66
67			button_column_third = [
68			sg.Button("Preparar Correos", key="prepare_correos", border_width=0),
69			sg.Button("Facturas Pendientes", key="facturas_pendientes", border_width=0),
70			sg.Button("Clientes", key="prepare_clientes", border_width=0),
71			sg.VSeparator(),
72			sg.Button("Ajuste:", key="preparar_ajuste_anual", border_width=0),
73			sg.Text("Año-Mes:", pad=TEXT_PADDING),
74			sg.Input((date.today() + relativedelta(months=1)).strftime('%Y-%m'), size=(8, 1), key="anio_mes_ajuste"),
75			sg.Input("", size=(6, 1), key="ajuste_porcentaje"),
76			sg.Text("%", pad=RTEXT_PADDING),
77			sg.VSeparator(),
78			sg.Text("Recuperar:", pad=TEXT_PADDING),
79			sg.Button("Emitidas", key="recuperar_emitidas", border_width=0, disabled=not has_fiel),
80			sg.Button("Recibidas", key="recuperar_recibidas", border_width=0, disabled=not has_fiel),
81			sg.Text("Dias:", pad=TEXT_PADDING),
82			sg.Input("40", size=(4, 1), key="recuperar_dias", disabled=not has_fiel),
83			]
84
85			button_column_low = [
86			sg.Button("Enviar ", disabled=True, key="crear_facturas", border_width=0),
87			sg.Push(),
88			sg.Checkbox("Ver Detallado", default=False, key="detallado"),
89			sg.Button("Acerca De", key="about", border_width=0),
90			]
91
92			# ----- Full layout -----
93			return [
94			button_column,
95			[sg.HSeparator()],
96			c_second,
97			[sg.HSeparator()],
98			button_column_third,
99			[sg.Multiline(expand_x=True, expand_y=True, key="console", write_only=True, autoscroll=True, reroute_stdout=True)],
100			button_column_low
101			]
102
103
104			class ActionButtonManager:
105			def __init__(self, button):
106			self._name = ""
107			self._items = []
108			self.button = button
109
110			def set_items(self, name, items):
111			self._name = name
112			self._items = items
113			self.style_button()
114
115			def clear(self):
116			name = self._name
117			items = self._items
118			self._name = ""
119			self._items = []
120			self.style_button()
121			return name, items
122
123			def style_button(self):
124			self.button.update(
125			f"Enviar {len(self._items)} {self._name.capitalize()}" if self._items else f"Enviar {self._name.capitalize()}",
126			disabled=len(self._items) == 0
127			)
128

SAT-CFDI / python-satdigitalinvoice

Push — main ( d86a79...f53e5f )

satdigitalinvoice.layout.make_layout() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like