HmacFilter::init() - Code Metrics - Inspection of "Added tests for HmacFilter, updated readme" - SAM-IT/yii2-urlsigner - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 32af36...de0c2e )

by Sam

created 2018-07-12 08:24 UTC

HmacFilter::init() A

↳ Parent: HmacFilter

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	0
crap	2

<?php
declare(strict_types=1);


namespace SamIT\Yii2\UrlSigner;


use SamIT\Yii2\UrlSigner\UrlSigner;
use yii\base\ActionFilter;
use yii\base\InvalidConfigException;
use yii\web\ForbiddenHttpException;
use yii\web\Request;

/**
 * Filter that checks for a valid HMAC in the URL.
 * @inheritdoc
 */
class HmacFilter extends ActionFilter
{
    /**
     * @var UrlSigner
     */
    public $signer;

    public function init()
    {
        parent::init();
        if (!$this->signer instanceof UrlSigner) {
            throw new InvalidConfigException('Signer is required');
        }
    }


    /**
     * @param \yii\base\Action $action
     * @throws \Exception
     * @return bool
     */
    public function beforeAction($action)
    {
        /**
         * We obtain the request this way because we do not want to store a reference to any objects with state.
         * @var Request $request
         */
        $request = $action->controller->module->get('request');
        if (!$this->signer->verify($request->queryParams, $action->controller->route)) {
            throw new ForbiddenHttpException("No or invalid HMAC");
        }
        return true;
    }

}


1		<?php
2		declare(strict_types=1);
3
4
5		namespace SamIT\Yii2\UrlSigner;
6
7
8		use SamIT\Yii2\UrlSigner\UrlSigner;
9		use yii\base\ActionFilter;
10		use yii\base\InvalidConfigException;
11		use yii\web\ForbiddenHttpException;
12		use yii\web\Request;
13
14		/**
15		* Filter that checks for a valid HMAC in the URL.
16		* @inheritdoc
17		*/
18		class HmacFilter extends ActionFilter
19		{
20		/**
21		* @var UrlSigner
22		*/
23		public $signer;
24
25	10	public function init()
26		{
27	10	parent::init();
28	10	if (!$this->signer instanceof UrlSigner) {
29	4	throw new InvalidConfigException('Signer is required');
30		}
31		}
32
33
34		/**
35		* @param \yii\base\Action $action
36		* @throws \Exception
37		* @return bool
38		*/
39	4	public function beforeAction($action)
40		{
41		/**
42		* We obtain the request this way because we do not want to store a reference to any objects with state.
43		* @var Request $request
44		*/
45	4	$request = $action->controller->module->get('request');
46	4	if (!$this->signer->verify($request->queryParams, $action->controller->route)) {
47	2	throw new ForbiddenHttpException("No or invalid HMAC");
48		}
49	2	return true;
50		}
51
52		}
53

SAM-IT / yii2-urlsigner

Push — master ( 32af36...de0c2e )

HmacFilter::init() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like