MetadataBag::add() - Code Metrics - Inspection of "Prepare V1 Release" - RxThunder/Core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Jérémy

created 2020-01-03 09:44 UTC

MetadataBag::add() A

↳ Parent: MetadataBag

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	10
cc	2
nc	2
nop	2
crap	2

<?php

declare(strict_types=1);

namespace RxThunder\Core\Model;

final class MetadataBag
{
    /** @var array<string, bool|int|float|string>  */
    private array $parameters = [];

    /**
     * @param array<mixed, mixed> $parameters
     */
    public function __construct(array $parameters)
    {
        foreach ($parameters as $key => $value) {
            $this->add((string) $key, $value);
        }
    }

    /**
     * @param bool|int|float|string $value
     */
    public function add(string $key, $value): self
    {
        if (!is_scalar($value)) {

            throw new \InvalidArgumentException(sprintf(
                'MetadataBag expect scalar value, %s given',
                gettype($value)
            ));
        }

        $this->parameters[$key] = $value;

        return $this;
    }

    /**
     * @return bool|int|float|string
     */
    public function get(string $key)
    {
        return $this->parameters[$key] ?? null;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace RxThunder\Core\Model;
6
7		final class MetadataBag
8		{
9		/** @var array<string, bool\|int\|float\|string> */
10		private array $parameters = [];
11
12		/**
13		* @param array<mixed, mixed> $parameters
14		*/
15	5	public function __construct(array $parameters)
16		{
17	5	foreach ($parameters as $key => $value) {
18	3	$this->add((string) $key, $value);
19		}
20	4	}
21
22		/**
23		* @param bool\|int\|float\|string $value
24		*/
25	3	public function add(string $key, $value): self
26		{
27	3	if (!is_scalar($value)) {
		0 ignored issues – show introduced 2020-01-02 14:47 UTC by Report Bug Copy Issue Report The condition `is_scalar($value)` is always `true`. Loading history...
28	1	throw new \InvalidArgumentException(sprintf(
29	1	'MetadataBag expect scalar value, %s given',
30	1	gettype($value)
31		));
32		}
33
34	2	$this->parameters[$key] = $value;
35
36	2	return $this;
37		}
38
39		/**
40		* @return bool\|int\|float\|string
41		*/
42	2	public function get(string $key)
43		{
44	2	return $this->parameters[$key] ?? null;
45		}
46		}
47

RxThunder / Core

Pull Request — master (#9)

MetadataBag::add() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like