FitMapping::guessDevice() - Code Metrics - Inspection of "Merge pull request #6 from Runalyze/a-lot-of-new-d..." - Runalyze/devices - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d7f70...76d437 )

by Michael

created 2020-09-13 08:29 UTC

FitMapping::guessDevice() D

↳ Parent: FitMapping

Complexity

Conditions	22
Paths	22

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	506

Importance

Changes

Metric	Value
dl	0
loc	70
ccs	0
cts	70
cp	0
rs	4.1666
c	0
b	0
f	0
cc	22
nc	22
nop	2
crap	506

How to fix Long Method Complexity

<?php

/*
 * This file is part of the Runalyze Device List.
 *
 * (c) RUNALYZE <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Runalyze\Devices\Mapping;

use Runalyze\Devices\Device\DeviceProfile;

class FitMapping
{
    public static function guessDevice($manufactorId, $productId)
    {
        switch ($manufactorId) {
            case 1:
                return (new GarminFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 23:
                return (new SuuntoFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 294:
                return (new CorosFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 32:
                return (new WahooFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 38:
                return (new OsynceFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 255:
                return (new DevelopmentFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 267:
                return DeviceProfile::BRYTON_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 70:
                return (new SigmaSportFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 71:
                return (new TomTomFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 95:
                return DeviceProfile::STRYD_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 54:
                return DeviceProfile::APP_IP_BIKE;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 69:
                return DeviceProfile::STAGES_CYCLING_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 40:
                return DeviceProfile::CONCEPT_2_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 67:
                return DeviceProfile::APP_BKOOL;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 260:
                return DeviceProfile::APP_ZWIFT;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 282:
                return DeviceProfile::APP_THE_SUFFERFEST;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 281:
                return DeviceProfile::APP_TRAINER_ROAD;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 115:
                return DeviceProfile::IGPSPORT_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 258:
                return DeviceProfile::LEZYNE_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 505:
                return DeviceProfile::MIO_UNKNOWN;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 73:
                return (new WattbikeFitSdkMapping())->toInternal($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return null;
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of the Runalyze Device List.
5			*
6			* (c) RUNALYZE <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Runalyze\Devices\Mapping;
13
14			use Runalyze\Devices\Device\DeviceProfile;
15
16			class FitMapping
17			{
18			public static function guessDevice($manufactorId, $productId)
19			{
20			switch ($manufactorId) {
21			case 1:
22			return (new GarminFitSdkMapping())->toInternal($productId);
23			break;
			0 ignored issues – show Unused Code introduced 2020-03-11 10:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
24			case 23:
25			return (new SuuntoFitSdkMapping())->toInternal($productId);
26			break;
			0 ignored issues – show Unused Code introduced 2020-03-11 10:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
27			case 294:
28			return (new CorosFitSdkMapping())->toInternal($productId);
29			break;
			0 ignored issues – show Unused Code introduced 2020-03-11 10:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
30			case 32:
31			return (new WahooFitSdkMapping())->toInternal($productId);
32			break;
			0 ignored issues – show Unused Code introduced 2020-03-11 10:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
33			case 38:
34			return (new OsynceFitSdkMapping())->toInternal($productId);
35			break;
			0 ignored issues – show Unused Code introduced 2020-03-11 10:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
36			case 255:
37			return (new DevelopmentFitSdkMapping())->toInternal($productId);
38			break;
			0 ignored issues – show Unused Code introduced 2020-03-13 20:53 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
39			case 267:
40			return DeviceProfile::BRYTON_UNKNOWN;
41			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
42			case 70:
43			return (new SigmaSportFitSdkMapping())->toInternal($productId);
44			break;
			0 ignored issues – show Unused Code introduced 2020-03-16 12:59 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
45			case 71:
46			return (new TomTomFitSdkMapping())->toInternal($productId);
47			break;
			0 ignored issues – show Unused Code introduced 2020-03-17 09:16 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
48			case 95:
49			return DeviceProfile::STRYD_UNKNOWN;
50			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
51			case 54:
52			return DeviceProfile::APP_IP_BIKE;
53			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
54			case 69:
55			return DeviceProfile::STAGES_CYCLING_UNKNOWN;
56			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
57			case 40:
58			return DeviceProfile::CONCEPT_2_UNKNOWN;
59			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
60			case 67:
61			return DeviceProfile::APP_BKOOL;
62			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
63			case 260:
64			return DeviceProfile::APP_ZWIFT;
65			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
66			case 282:
67			return DeviceProfile::APP_THE_SUFFERFEST;
68			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
69			case 281:
70			return DeviceProfile::APP_TRAINER_ROAD;
71			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
72			case 115:
73			return DeviceProfile::IGPSPORT_UNKNOWN;
74			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
75			case 258:
76			return DeviceProfile::LEZYNE_UNKNOWN;
77			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
78			case 505:
79			return DeviceProfile::MIO_UNKNOWN;
80			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
81			case 73:
82			return (new WattbikeFitSdkMapping())->toInternal($productId);
83			break;
			0 ignored issues – show Unused Code introduced 2020-09-12 13:51 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
84			default:
85			return null;
86			}
87			}
88			}
89

Runalyze / devices

Push — master ( 6d7f70...76d437 )

FitMapping::guessDevice() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like