FitMapping::guessDevice() - Code Metrics - Inspection of "fit mapping" - Runalyze/devices - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 486315...705061 )

by Michael

created 2019-11-20 21:08 UTC

FitMapping::guessDevice() A

↳ Parent: FitMapping

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	0
cts	15
cp	0
rs	9.7333
c	0
b	0
f	0
cc	4
nc	4
nop	2
crap	20

<?php

/*
 * This file is part of the Runalyze Device List.
 *
 * (c) RUNALYZE <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Runalyze\Devices\Mapping;

use Runalyze\Devices\Device\DeviceProfile;

class FitMapping
{
    public static function guessDevice($manufactorId, $productId) {

        switch ($manufactorId) {
            case 1:
                return self::getGarminDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 23:
                return self::getSuuntoDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 294:
                return self::getCorosDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return null;
        }
    }

    public function getGarminDevice($productId) {
        $garmin = new GarminFitSdkMapping();
        return $garmin->toInternal($productId);
    }

    public function getCorosDevice($productId) {
        $coros = new CorosFitSdkMapping();
        return $coros->toInternal($productId);
    }

    public function getSuuntoDevice($productId) {
        $suunto = new SuuntoFitSdkMapping();
        return $suunto->toInternal($productId);
    }


}


1			<?php
2
3			/*
4			* This file is part of the Runalyze Device List.
5			*
6			* (c) RUNALYZE <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Runalyze\Devices\Mapping;
13
14			use Runalyze\Devices\Device\DeviceProfile;
15
16			class FitMapping
17			{
18			public static function guessDevice($manufactorId, $productId) {
19
20			switch ($manufactorId) {
21			case 1:
22			return self::getGarminDevice($productId);
23			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
24			case 23:
25			return self::getSuuntoDevice($productId);
26			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
27			case 294:
28			return self::getCorosDevice($productId);
29			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
30			default:
31			return null;
32			}
33			}
34
35			public function getGarminDevice($productId) {
36			$garmin = new GarminFitSdkMapping();
37			return $garmin->toInternal($productId);
38			}
39
40			public function getCorosDevice($productId) {
41			$coros = new CorosFitSdkMapping();
42			return $coros->toInternal($productId);
43			}
44
45			public function getSuuntoDevice($productId) {
46			$suunto = new SuuntoFitSdkMapping();
47			return $suunto->toInternal($productId);
48			}
49
50
51			}
52

Runalyze / devices

Push — master ( 486315...705061 )

FitMapping::guessDevice() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like