FitMapping::guessDevice() - Code Metrics - Inspection of "More devices/3" - Runalyze/devices - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4)

by Michael

created 2020-03-10 19:13 UTC

FitMapping::guessDevice() A

↳ Parent: FitMapping

Complexity

Conditions	5
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	0
cts	18
cp	0
rs	9.3554
c	0
b	0
f	0
cc	5
nc	5
nop	2
crap	30

<?php

/*
 * This file is part of the Runalyze Device List.
 *
 * (c) RUNALYZE <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Runalyze\Devices\Mapping;

class FitMapping
{
    public static function guessDevice($manufactorId, $productId)
    {
        switch ($manufactorId) {
            case 1:
                return self::getGarminDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 23:
                return self::getSuuntoDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 294:
                return self::getCorosDevice($productId);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 32:
                return self::getWahooDevice($productId);
            default:
                return null;
        }
    }

    public function getGarminDevice($productId)
    {
        $garmin = new GarminFitSdkMapping();

        return $garmin->toInternal($productId);
    }

    public function getCorosDevice($productId)
    {
        $coros = new CorosFitSdkMapping();

        return $coros->toInternal($productId);
    }

    public function getSuuntoDevice($productId)
    {
        $suunto = new SuuntoFitSdkMapping();

        return $suunto->toInternal($productId);
    }

    public function getWahooDevice($productId)
    {
        $suunto = new WahooFitSdkMapping();

        return $suunto->toInternal($productId);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Runalyze Device List.
5			*
6			* (c) RUNALYZE <[email protected]>
7			*
8			* This source file is subject to the MIT license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Runalyze\Devices\Mapping;
13
14			class FitMapping
15			{
16			public static function guessDevice($manufactorId, $productId)
17			{
18			switch ($manufactorId) {
19			case 1:
20			return self::getGarminDevice($productId);
21			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
22			case 23:
23			return self::getSuuntoDevice($productId);
24			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
25			case 294:
26			return self::getCorosDevice($productId);
27			break;
			0 ignored issues – show Unused Code introduced 2019-11-20 21:10 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
28			case 32:
29			return self::getWahooDevice($productId);
30			default:
31			return null;
32			}
33			}
34
35			public function getGarminDevice($productId)
36			{
37			$garmin = new GarminFitSdkMapping();
38
39			return $garmin->toInternal($productId);
40			}
41
42			public function getCorosDevice($productId)
43			{
44			$coros = new CorosFitSdkMapping();
45
46			return $coros->toInternal($productId);
47			}
48
49			public function getSuuntoDevice($productId)
50			{
51			$suunto = new SuuntoFitSdkMapping();
52
53			return $suunto->toInternal($productId);
54			}
55
56			public function getWahooDevice($productId)
57			{
58			$suunto = new WahooFitSdkMapping();
59
60			return $suunto->toInternal($productId);
61			}
62			}
63

Runalyze / devices

Pull Request — master (#4)

FitMapping::guessDevice() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like