RunOpenCode\ExchangeRate\Source\Api\NationalBankOfSerbiaXmlSaxParser

Complexity

Total Complexity

22

Size/Duplication

Total Lines	199
Duplicated Lines	19.6 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

73.39%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	parse()	0	31	1
A	onStart()	0	11	3
B	onEnd()	39	54	6
C	onData()	0	35	11
A	parseXml()	0	5	1

<?php
/*
 * This file is part of the Exchange Rate package, an RunOpenCode project.
 *
 * (c) 2016 RunOpenCode
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace RunOpenCode\ExchangeRate\Source\Api;
use RunOpenCode\ExchangeRate\Contract\RateInterface;
use RunOpenCode\ExchangeRate\Model\Rate;
use RunOpenCode\ExchangeRate\Source\NationalBankOfSerbiaDomCrawlerSource;

/**
 * Class NationalBankOfSerbiaXmlSaxParser
 *
 * Parses XML files from National bank of Serbia.
 *
 * @package RunOpenCode\ExchangeRate\Source\Api
 * @internal
 */
class NationalBankOfSerbiaXmlSaxParser
{
    /**
     * @var RateInterface[]
     */
    private $rates;

    /**
     * @var \SplStack
     */
    private $stack;

    /**
     * @var array
     */
    private $currentRate;

    /**
     * @var \DateTime
     */
    private $date;

    /**
     * @var string
     */
    private $rateType;

    /**
     * Parse XML from National bank of Serbia.
     *
     * @param string $xml
     * @return RateInterface[]
     */
    public function parse($xml)
    {
        $this->rates = array();
        $this->stack = new \SplStack();
        $this->currentRate = array();
        $this->date = new \DateTime('now');
        $this->rateType = 'default';

        $parser = xml_parser_create();

        xml_set_element_handler(
            $parser,
            \Closure::bind(function($parser, $name, $attributes) {
                $this->onStart($parser, $name, $attributes);
            }, $this),
            \Closure::bind(function($parser, $name) {
                $this->onEnd($parser, $name);
            }, $this)
        );

        xml_set_character_data_handler(
            $parser,
            \Closure::bind(function($parser, $data) {
                $this->onData($parser, $data);
            }, $this));

        xml_parse($parser, $xml);
        xml_parser_free($parser);

        return $this->rates;
    }

    /**
     * SAX on tag start callback.
     *
     * @param $parser
     * @param $name
     * @param $attributes
     */
    private function onStart($parser, $name, $attributes)

The parameter $parser is not used and could be removed.

The parameter $attributes is not used and could be removed.

    {
        if (!empty($name)) {

            $this->stack->push($name);

            if ($name === 'ITEM') {
                $this->currentRate = array();
            }
        }
    }

    /**
     * SAX on tag end callback.
     *
     * @param $parser
     * @param $name
     */
    private function onEnd($parser, $name)

The parameter $parser is not used and could be removed.

    {
        if (!empty($name)) {

            $this->stack->pop();

            if ($name === 'ITEM') {

                if (array_key_exists('buyingRate', $this->currentRate)) {

This code seems to be duplicated across your project.

                    $this->rates[] = new Rate(
                        NationalBankOfSerbiaDomCrawlerSource::NAME,
                        $this->currentRate['buyingRate'] / $this->currentRate['unit'],
                        $this->currentRate['currencyCode'],
                        $this->rateType . '_buying',
                        $this->date,
                        'RSD',
                        new \DateTime('now'),
                        new \DateTime('now')
                    );
                }

                if (array_key_exists('sellingRate', $this->currentRate)) {

This code seems to be duplicated across your project.

                    $this->rates[] = new Rate(
                        NationalBankOfSerbiaDomCrawlerSource::NAME,
                        $this->currentRate['sellingRate'] / $this->currentRate['unit'],
                        $this->currentRate['currencyCode'],
                        $this->rateType . '_selling',
                        $this->date,
                        'RSD',
                        new \DateTime('now'),
                        new \DateTime('now')
                    );
                }

                if (array_key_exists('middleRate', $this->currentRate)) {

This code seems to be duplicated across your project.

                    $this->rates[] = new Rate(
                        NationalBankOfSerbiaDomCrawlerSource::NAME,
                        $this->currentRate['middleRate'] / $this->currentRate['unit'],
                        $this->currentRate['currencyCode'],
                        'default',
                        $this->date,
                        'RSD',
                        new \DateTime('now'),
                        new \DateTime('now')
                    );
                }

                $this->currentRate = array();
            }
        }
    }

    /**
     * SAX on data callback.
     *
     * @param $parser
     * @param $data
     */
    private function onData($parser, $data)

The parameter $parser is not used and could be removed.

    {
        if (!empty($data)) {

            switch ($this->stack->top()) {
                case 'DATE':
                    $this->date = \DateTime::createFromFormat('d.m.Y', $data);

It seems like \DateTime::createFromFormat('d.m.Y', $data) can also be of type false. However, the property $date is declared as type object<DateTime>. Maybe add an additional type check?

                    break;
                case 'TYPE':
                    $data = trim($data);
                    if ($data === 'FOREIGN EXCHANGE') {
                        $this->rateType = 'foreign_exchange';
                    } elseif ($data === 'FOREIGN CASH') {
                        $this->rateType = 'foreign_cache';
                    }
                    break;
                case 'CURRENCY':
                    $this->currentRate['currencyCode'] = trim($data);
                    break;
                case 'UNIT':
                    $this->currentRate['unit'] = (int) trim($data);
                    break;
                case 'BUYING_RATE':
                    $this->currentRate['buyingRate'] = (float) trim($data);
                    break;
                case 'SELLING_RATE':
                    $this->currentRate['sellingRate'] = (float) trim($data);
                    break;
                case 'MIDDLE_RATE':
                    $this->currentRate['middleRate'] = (float) trim($data);
                    break;
            }

        }
    }

    /**
     * Parse XML from National bank of Serbia.
     *
     * @param string $xml
     * @return RateInterface[]
     */
    public static function parseXml($xml)
    {
        $parser = new static();
        return $parser->parse($xml);
    }
}