RunOpenCode\ExchangeRate\BancaIntesaSerbia\Parser\HtmlParser

Complexity

Total Complexity

20

Size/Duplication

Total Lines	158
Duplicated Lines	20.25 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getRates()	0	8	2
A	parseHtml()	0	7	1
B	extractRates()	32	57	6
D	parseRow()	0	35	9
A	buildRate()	0	13	1

<?php
/*
 * This file is part of the Exchange Rate package, an RunOpenCode project.
 *
 * Implementation of exchange rate crawler for Banca Intesa Serbia, http://www.bancaintesa.rs.
 *
 * (c) 2016 RunOpenCode
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace RunOpenCode\ExchangeRate\BancaIntesaSerbia\Parser;

use RunOpenCode\ExchangeRate\Contract\RateInterface;
use RunOpenCode\ExchangeRate\Model\Rate;
use RunOpenCode\ExchangeRate\BancaIntesaSerbia\Api;
use Symfony\Component\DomCrawler\Crawler;

/**
 * Class HtmlParser
 *
 * Parse HTML document with daily rates from Banca Intesa Serbia.
 *
 * @package RunOpenCode\ExchangeRate\BancaIntesaSerbia\Parser
 */
class HtmlParser
{
    /**
     * @var RateInterface[]
     */
    private $rates;

    /**
     * @var array
     */
    private $currentRate;

The property $currentRate is not used and could be removed.

    /**
     * @var \DateTime
     */
    private $date;

    /**
     * @var string
     */
    private $html;

    /**
     * HtmlParser constructor.
     * @param $node string
     * @param $date \DateTime
     */
    public function __construct($node, \DateTime $date)
    {
        $this->html = $node;
        $this->date = $date;
    }

    public function getRates()
    {
        if (!$this->rates) {

The expression $this->rates of type RunOpenCode\ExchangeRate\Contract\RateInterface[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->rates = $this->parseHtml($this->html, $this->date);
        }

        return $this->rates;
    }

    private function parseHtml($html, \DateTime $date)
    {
        $crawler = new Crawler($html);
        $crawler = $crawler->filter('table');

        return $this->extractRates($crawler, $date);
    }

    private function extractRates(Crawler $crawler, \DateTime $date)
    {
        $rates = array();

        $crawler->filter('tr')->each(function (Crawler $node) use ($date, &$rates) {

            $row = $this->parseRow($node);

            if (null !== $row) {

                $rates[] = $this->buildRate(
                    $row['default'] / $row['unit'],
                    $row['currencyCode'],
                    'default',
                    $date
                );

                if ($row['foreign_exchange_buying'] > 0) {

This code seems to be duplicated across your project.

                    $rates[] = $this->buildRate(
                        $row['foreign_exchange_buying'] / $row['unit'],
                        $row['currencyCode'],
                        'foreign_exchange_buying',
                        $date
                    );
                }

                if ($row['foreign_exchange_selling'] > 0) {

This code seems to be duplicated across your project.

                    $rates[] = $this->buildRate(
                        $row['foreign_exchange_selling'] / $row['unit'],
                        $row['currencyCode'],
                        'foreign_exchange_selling',
                        $this->date
                    );
                }

                if ($row['foreign_cash_buying'] > 0) {

This code seems to be duplicated across your project.

                    $rates[] = $this->buildRate(
                        $row['foreign_cash_buying'] / $row['unit'],
                        $row['currencyCode'],
                        'foreign_cash_buying',
                        $this->date
                    );
                }

                if ($row['foreign_cash_selling'] > 0) {

This code seems to be duplicated across your project.

                    $rates[] = $this->buildRate(
                        $row['foreign_cash_selling'] / $row['unit'],
                        $row['currencyCode'],
                        'foreign_cash_selling',
                        $this->date
                    );
                }
            }
        });

        return $rates;
    }

    private function parseRow(Crawler $crawler)
    {
        $currentRow = array(
            'currencyCode' => ''
        );

        $crawler->filter('td')->each(function (Crawler $node, $i) use (&$currentRow) {

            switch ($i) {
                case 1:
                    $currentRow['currencyCode'] = trim($node->text());
                    break;
                case 2:
                    $currentRow['unit'] = (int)trim($node->text());
                    break;
                case 3:
                    $currentRow['foreign_exchange_buying'] = (float)trim($node->text());
                    break;
                case 4:
                    $currentRow['default'] = (float)trim($node->text());
                    break;
                case 5:
                    $currentRow['foreign_exchange_selling'] = (float)trim($node->text());
                    break;
                case 6:
                    $currentRow['foreign_cash_buying'] = (float)trim($node->text());
                    break;
                case 7:
                    $currentRow['foreign_cash_selling'] = (float)trim($node->text());
                    break;
            }
        });

        return strlen($currentRow['currencyCode']) === 3 ? $currentRow : null;
    }

    private function buildRate($value, $currencyCode, $rateType, $date) {

        return new Rate(
            Api::NAME,
            $value,
            $currencyCode,
            $rateType,
            $date,
            'RSD',
            new \DateTime('now'),
            new \DateTime('now')
        );
    }
}