RunOpenCode / exchange-rate-bundle

src/RunOpenCode/Bundle/ExchangeRate/Controller/EditController.php

<?php
/*
 * This file is part of the Exchange Rate Bundle, an RunOpenCode project.
 *
 * (c) 2017 RunOpenCode
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace RunOpenCode\Bundle\ExchangeRate\Controller;

use RunOpenCode\Bundle\ExchangeRate\Form\Dto\Rate as DtoRate;
use RunOpenCode\Bundle\ExchangeRate\Form\FormType;
use RunOpenCode\Bundle\ExchangeRate\Security\AccessVoter;
use RunOpenCode\ExchangeRate\Contract\RateInterface;
use RunOpenCode\ExchangeRate\Contract\RepositoryInterface;
use RunOpenCode\ExchangeRate\Model\Rate;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Form;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class EditController
 *
 * @package RunOpenCode\Bundle\ExchangeRate\Controller
 */
class EditController extends Controller
{
    /**
     * Main controller action
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response|\Symfony\Component\HttpKernel\Exception\NotFoundHttpException
     */
    public function indexAction(Request $request)
    {
        $source = $request->get('source');
        $rateType = $request->get('rate_type');
        $currencyCode = $request->get('currency_code');
        $date = \DateTime::createFromFormat('Y-m-d', $request->get('date'));

        /**
         * @var RepositoryInterface $repository
         */
        $repository = $this->get('runopencode.exchange_rate.repository');

        if (!$repository->has($source, $currencyCode, $date, $rateType)) {

It seems like $date defined by \DateTime::createFromFormat('Y-m-d', $request->get('date')) on line 41 can also be of type false; however, RunOpenCode\ExchangeRate\Contract\RepositoryInterface::has() does only seem to accept null|object<DateTime>, did you maybe forget to handle an error condition?

            throw $this->createNotFoundException();
        }

        $rate = $repository->get($source, $currencyCode, $date, $rateType);

It seems like $date defined by \DateTime::createFromFormat('Y-m-d', $request->get('date')) on line 41 can also be of type false; however, RunOpenCode\ExchangeRate\Contract\RepositoryInterface::get() does only seem to accept null|object<DateTime>, did you maybe forget to handle an error condition?

        if (!$this->isGranted(AccessVoter::EDIT, $rate)) {
            throw $this->createAccessDeniedException();
        }

        $form = $this->getForm($rate);

        if (true === $this->handleForm($form, $request, $rate)) {
            return $this->redirectAfterSuccess();
        }

        return $this->render($this->getTwigTemplate(), [
            'form' => $form->createView(),
            'rate' => $rate
        ]);
    }

    /**
     * Handle form submission.
     *
     * @param Form $form
     * @param Request $request
     * @param RateInterface $exchangeRate
     *
     * @return bool TRUE if successful
     */
    protected function handleForm(Form $form, Request $request, RateInterface $exchangeRate)
    {
        $form->handleRequest($request);

        if (!$form->isSubmitted()) {
            return false;
        }

        /**
         * @var Rate $rate
         */
        $rate = $form->getData()->toRate($exchangeRate);

        if (!$form->isValid()) {
            $this->addFlash('error', $this->get('translator')->trans('flash.form.error', [], 'runopencode_exchange_rate'));
            return false;
        }

        return $this->save($rate);
    }

    /**
     * Get FQCN of FormType form.
     *
     * @return string
     */
    protected function getFormType()
    {
        return FormType::class;
    }

    /**
     * Get form.
     *
     * @return Form
     */
    protected function getForm(RateInterface $rate)
    {
        return $this->createForm($this->getFormType(), DtoRate::fromRateInterface($rate));
    }

    /**
     * Save rate.
     *
     * @param RateInterface $rate
     * @return TRUE if successful.
     */
    protected function save(RateInterface $rate)
    {
        try {
            $this->get('runopencode.exchange_rate.repository')->save([$rate]);
            $this->addFlash('success', $this->get('translator')->trans('flash.edit.success', [], 'runopencode_exchange_rate'));
            return true;
        } catch (\Exception $e) {
            $this->addFlash('error', $this->get('translator')->trans('flash.edit.error.unknown', [], 'runopencode_exchange_rate'));
            return false;
        }
    }

    /**
     * Redirect after success.
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    protected function redirectAfterSuccess()
    {
        return $this->redirectToRoute('runopencode_exchange_rate_list');
    }

    /**
     * Get Twig template path.
     *
     * @return string
     */
    protected function getTwigTemplate()
    {
        return '@ExchangeRate/edit.html.twig';
    }
}