RunOpenCode\Bundle\ExchangeRate\Controller\ExchangeRateController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	87
Duplicated Lines	48.28 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	indexAction()	0	9	1
A	newAction()	21	21	3
A	editAction()	21	21	3
A	getNewRate()	0	7	1
A	getRateFromRequest()	0	8	2

<?php

namespace RunOpenCode\Bundle\ExchangeRate\Controller;

use RunOpenCode\Bundle\ExchangeRate\Form\Type\NewType;
use RunOpenCode\ExchangeRate\Contract\RepositoryInterface;
use RunOpenCode\Bundle\ExchangeRate\Model\Rate;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;

class ExchangeRateController extends Controller
{
    protected $repository;

    protected $baseCurrency;

    protected $settings;

    public function __construct(RepositoryInterface $repository, $baseCurrency, $settings)
    {
        $this->repository = $repository;
        $this->baseCurrency = $baseCurrency;
        $this->settings = $settings;
    }

    public function indexAction()
    {
        return $this->render($this->settings['list'], array(
            'base_template' => $this->settings['base_template'],
            'rates' => $this->repository->all(),
            'date_format' => $this->settings['date_format'],
            'date_time_format' => $this->settings['date_time_format']
        ));
    }

    public function newAction(Request $request)

This method seems to be duplicated in your project.

    {
        $form = $this->createForm(NewType::class, $this->getNewRate());

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $this->repository->save(array(
                $form->getData()
            ));

            $this->get('session')->getFlashBag()->add('success', 'run_open_code.exchange_rate.flash.new.success');
            return $this->redirectToRoute('roc_exchange_rate_list');
        }

        return $this->render($this->settings['new'], array(
            'base_template' => $this->settings['base_template'],
            'form' => $form->createView()
        ));
    }

    public function editAction(Request $request)

This method seems to be duplicated in your project.

    {
        $form = $this->createForm(NewType::class, $this->getRateFromRequest($request));

        $form->handleRequest($request);

        if ($form->isSubmitted() && $form->isValid()) {

            $this->repository->save(array(
                $form->getData()
            ));

            $this->get('session')->getFlashBag()->add('success', 'run_open_code.exchange_rate.flash.edit.success');
            return $this->redirectToRoute('roc_exchange_rate_list');
        }

        return $this->render($this->settings['edit'], array(
            'base_template' => $this->settings['base_template'],
            'form' => $form->createView()
        ));
    }

    protected function getNewRate()
    {
        $rate = new Rate(null, null, $this->baseCurrency, null, null, $this->baseCurrency, null, null);
        $rate->setBaseCurrencyCode($this->baseCurrency);

        return $rate;
    }

    protected function getRateFromRequest(Request $request)
    {
        if (!$this->repository->has($request->get('currency_code'), \DateTime::createFromFormat('Y-m-d', $request->get('date')), $request->get('rate_type'))) {

It seems like \DateTime::createFromFormat('Y-m-d', $request->get('date')) targeting DateTime::createFromFormat() can also be of type false; however, RunOpenCode\ExchangeRate\Contract\RepositoryInterface::has() does only seem to accept null|object<DateTime>, did you maybe forget to handle an error condition?

            throw new NotFoundHttpException();
        }

        return Rate::fromRateInterface($this->repository->get($request->get('currency_code'), \DateTime::createFromFormat('Y-m-d', $request->get('date')), $request->get('rate_type')));

It seems like \DateTime::createFromFormat('Y-m-d', $request->get('date')) targeting DateTime::createFromFormat() can also be of type false; however, RunOpenCode\ExchangeRate\Contract\RepositoryInterface::get() does only seem to accept null|object<DateTime>, did you maybe forget to handle an error condition?

    }

}