Rate::setCurrencyCode() - Code Metrics - Inspection of "Forms and some of the views are done" - RunOpenCode/exchange-rate-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bf73c4...f46316 )

by Nikola

created 2016-01-03 10:51 UTC

Rate::setCurrencyCode() A

↳ Parent: Rate

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php

namespace RunOpenCode\Bundle\ExchangeRate\Model;

use RunOpenCode\ExchangeRate\Model\Rate as BaseRate;
use RunOpenCode\ExchangeRate\Utils\CurrencyCode;

class Rate extends BaseRate
{
    /**
     * Set source name.
     *
     * @param string $sourceName
     */
    public function setSourceName($sourceName)
    {
        $this->sourceName = $sourceName;
    }

    /**
     * Set value.
     *
     * @param float $value
     */
    public function setValue($value)
    {
        $this->value = $value;
    }

    /**
     * Set currency code.
     *
     * @param string $currencyCode
     */
    public function setCurrencyCode($currencyCode)
    {
        $this->currencyCode = CurrencyCode::validate($currencyCode);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }

    /**
     * Set rate type.
     *
     * @param string $rateType
     */
    public function setRateType($rateType)
    {
        $this->rateType = $rateType;
    }

    /**
     * Set date.
     *
     * @param \DateTime $date
     */
    public function setDate(\DateTime $date)
    {
        $this->date = $date;
    }

    /**
     * Set base currency code.
     *
     * @param string $baseCurrencyCode
     */
    public function setBaseCurrencyCode($baseCurrencyCode)
    {
        $this->baseCurrencyCode = CurrencyCode::validate($baseCurrencyCode);;
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
    }

    /**
     * Set created date.
     *
     * @param \DateTime $createdAt
     */
    public function setCreatedAt(\DateTime $createdAt)
    {
        $this->createdAt = $createdAt;
    }

    /**
     * Set last modification date.
     *
     * @param \DateTime $modifiedAt
     */
    public function setModifiedAt(\DateTime $modifiedAt)
    {
        $this->modifiedAt = $modifiedAt;
    }
}


1			<?php
2
3			namespace RunOpenCode\Bundle\ExchangeRate\Model;
4
5			use RunOpenCode\ExchangeRate\Model\Rate as BaseRate;
6			use RunOpenCode\ExchangeRate\Utils\CurrencyCode;
7
8			class Rate extends BaseRate
9			{
10			/**
11			* Set source name.
12			*
13			* @param string $sourceName
14			*/
15			public function setSourceName($sourceName)
16			{
17			$this->sourceName = $sourceName;
18			}
19
20			/**
21			* Set value.
22			*
23			* @param float $value
24			*/
25			public function setValue($value)
26			{
27			$this->value = $value;
28			}
29
30			/**
31			* Set currency code.
32			*
33			* @param string $currencyCode
34			*/
35			public function setCurrencyCode($currencyCode)
36			{
37			$this->currencyCode = CurrencyCode::validate($currencyCode);
			0 ignored issues – show Bug introduced 2016-01-03 10:54 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->currencyCode` is correct as `\RunOpenCode\ExchangeRat...validate($currencyCode)` (which targets `RunOpenCode\ExchangeRate...urrencyCode::validate()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38			}
39
40			/**
41			* Set rate type.
42			*
43			* @param string $rateType
44			*/
45			public function setRateType($rateType)
46			{
47			$this->rateType = $rateType;
48			}
49
50			/**
51			* Set date.
52			*
53			* @param \DateTime $date
54			*/
55			public function setDate(\DateTime $date)
56			{
57			$this->date = $date;
58			}
59
60			/**
61			* Set base currency code.
62			*
63			* @param string $baseCurrencyCode
64			*/
65			public function setBaseCurrencyCode($baseCurrencyCode)
66			{
67			$this->baseCurrencyCode = CurrencyCode::validate($baseCurrencyCode);;
			0 ignored issues – show Bug introduced 2016-01-03 10:54 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$this->baseCurrencyCode` is correct as `\RunOpenCode\ExchangeRat...date($baseCurrencyCode)` (which targets `RunOpenCode\ExchangeRate...urrencyCode::validate()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
68			}
69
70			/**
71			* Set created date.
72			*
73			* @param \DateTime $createdAt
74			*/
75			public function setCreatedAt(\DateTime $createdAt)
76			{
77			$this->createdAt = $createdAt;
78			}
79
80			/**
81			* Set last modification date.
82			*
83			* @param \DateTime $modifiedAt
84			*/
85			public function setModifiedAt(\DateTime $modifiedAt)
86			{
87			$this->modifiedAt = $modifiedAt;
88			}
89			}
90

RunOpenCode / exchange-rate-bundle

Push — master ( bf73c4...f46316 )

Rate::setCurrencyCode() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like