Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
26 | class Extension extends BaseExtension |
||
27 | { |
||
28 | /** |
||
29 | * {@inheritdoc} |
||
30 | */ |
||
31 | 4 | public function getAlias() |
|
35 | |||
36 | /** |
||
37 | * {@inheritdoc} |
||
38 | */ |
||
39 | 2 | public function load(array $config, ContainerBuilder $container) |
|
69 | |||
70 | /** |
||
71 | * Configure base currency. |
||
72 | * |
||
73 | * @param array $config Configuration parameters. |
||
74 | * @param ContainerBuilder $container Service container. |
||
75 | * @return Extension $this Fluent interface. |
||
76 | */ |
||
77 | protected function configureBaseCurrency(array $config, ContainerBuilder $container) |
||
84 | |||
85 | /** |
||
86 | * Configure rates. |
||
87 | * |
||
88 | * @param array $config Configuration parameters. |
||
89 | * @param ContainerBuilder $container Service container. |
||
90 | * @return Extension $this Fluent interface. |
||
91 | */ |
||
92 | protected function configureRates(array $config, ContainerBuilder $container) |
||
101 | |||
102 | /** |
||
103 | * Configure required processors. |
||
104 | * |
||
105 | * @param array $config Configuration parameters. |
||
106 | * @param ContainerBuilder $container Service container. |
||
107 | * @return Extension $this Fluent interface. |
||
108 | */ |
||
109 | protected function configureRepository(array $config, ContainerBuilder $container) |
||
114 | |||
115 | /** |
||
116 | * Configure file repository, if used. |
||
117 | * |
||
118 | * @param array $config Configuration parameters. |
||
119 | * @param ContainerBuilder $container Service container. |
||
120 | * @return Extension $this Fluent interface. |
||
121 | */ |
||
122 | protected function configureFileRepository(array $config, ContainerBuilder $container) |
||
127 | |||
128 | /** |
||
129 | * Configure controller. |
||
130 | * |
||
131 | * @param array $config Configuration parameters. |
||
132 | * @param ContainerBuilder $container Service container. |
||
133 | * @return Extension $this Fluent interface. |
||
134 | */ |
||
135 | protected function configureController(array $config, ContainerBuilder $container) |
||
144 | |||
145 | /** |
||
146 | * Configure simple sources which does not have to be explicitly added to service container. |
||
147 | * |
||
148 | * @param array $config Configuration parameters. |
||
149 | * @param ContainerBuilder $container Service container. |
||
150 | * @return Extension $this Fluent interface. |
||
151 | */ |
||
152 | protected function configureSimpleSources(array $config, ContainerBuilder $container) |
||
160 | |||
161 | /** |
||
162 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\SourceType" default settings. |
||
163 | * |
||
164 | * @param array $config Configuration parameters. |
||
165 | * @param ContainerBuilder $container Service container. |
||
166 | * @return Extension $this Fluent interface. |
||
167 | */ |
||
168 | View Code Duplication | protected function configureSourceType(array $config, ContainerBuilder $container) |
|
180 | |||
181 | /** |
||
182 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\RateTypeType" default settings. |
||
183 | * |
||
184 | * @param array $config Configuration parameters. |
||
185 | * @param ContainerBuilder $container Service container. |
||
186 | * @return Extension $this Fluent interface. |
||
187 | */ |
||
188 | View Code Duplication | protected function configureRateTypeType(array $config, ContainerBuilder $container) |
|
200 | |||
201 | /** |
||
202 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\CurrencyCodeType" default settings. |
||
203 | * |
||
204 | * @param array $config Configuration parameters. |
||
205 | * @param ContainerBuilder $container Service container. |
||
206 | * @return Extension $this Fluent interface. |
||
207 | */ |
||
208 | protected function configureCurrencyCodeType(array $config, ContainerBuilder $container) |
||
224 | |||
225 | /** |
||
226 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\RateType" default settings. |
||
227 | * |
||
228 | * @param array $config Configuration parameters. |
||
229 | * @param ContainerBuilder $container Service container. |
||
230 | * @return Extension $this Fluent interface. |
||
231 | */ |
||
232 | protected function configureRateType(array $config, ContainerBuilder $container) |
||
238 | |||
239 | /** |
||
240 | * Configure internal notifications. |
||
241 | * |
||
242 | * @param array $config Configuration parameters. |
||
243 | * @param ContainerBuilder $container Service container. |
||
244 | * @return Extension $this Fluent interface. |
||
245 | */ |
||
246 | protected function configureNotifications(array $config, ContainerBuilder $container) |
||
254 | } |
||
255 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.