EditController::getTwigTemplate() - Code Metrics - Inspection of "Working on documentation..." - RunOpenCode/exchange-rate-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 431275...4f28c1 )

by Nikola

created 2017-06-03 07:17 UTC

EditController::getTwigTemplate() A

↳ Parent: EditController

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php
/*
 * This file is part of the Exchange Rate Bundle, an RunOpenCode project.
 *
 * (c) 2017 RunOpenCode
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace RunOpenCode\Bundle\ExchangeRate\Controller;

use RunOpenCode\Bundle\ExchangeRate\Form\Dto\Rate as DtoRate;
use RunOpenCode\Bundle\ExchangeRate\Form\FormType;
use RunOpenCode\Bundle\ExchangeRate\Security\AccessVoter;
use RunOpenCode\ExchangeRate\Contract\RateInterface;
use RunOpenCode\ExchangeRate\Contract\RepositoryInterface;
use RunOpenCode\ExchangeRate\Model\Rate;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Form;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class EditController
 *
 * @package RunOpenCode\Bundle\ExchangeRate\Controller
 */
class EditController extends Controller
{
    /**
     * Main controller action
     *
     * @param Request $request
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse|\Symfony\Component\HttpFoundation\Response|\Symfony\Component\HttpKernel\Exception\NotFoundHttpException
     */
    public function indexAction(Request $request)
    {
        $source = $request->get('source');
        $rateType = $request->get('rate_type');
        $currencyCode = $request->get('currency_code');
        $date = \DateTime::createFromFormat('Y-m-d', $request->get('date'));

        /**
         * @var RepositoryInterface $repository
         */
        $repository = $this->get('runopencode.exchange_rate.repository');

        if (!$repository->has($source, $currencyCode, $date, $rateType)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
            throw $this->createNotFoundException();
        }

        $rate = $repository->get($source, $currencyCode, $date, $rateType);
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}

        if (!$this->isGranted(AccessVoter::EDIT, $rate)) {
            throw $this->createAccessDeniedException();
        }

        $form = $this->getForm($rate);

        if (true === $this->handleForm($form, $request, $rate)) {
            return $this->redirectAfterSuccess();
        }

        return $this->render($this->getTwigTemplate(), [
            'form' => $form->createView(),
            'rate' => $rate
        ]);
    }

    /**
     * Handle form submission.
     *
     * @param Form $form
     * @param Request $request
     * @param RateInterface $exchangeRate
     *
     * @return bool TRUE if successful
     */
    protected function handleForm(Form $form, Request $request, RateInterface $exchangeRate)
    {
        $form->handleRequest($request);

        if (!$form->isSubmitted()) {
            return false;
        }

        /**
         * @var Rate $rate
         */
        $rate = $form->getData()->toRate($exchangeRate);

        if (!$form->isValid()) {

            $this->addFlash('error', $this->get('translator')->trans('flash.form.error', [], 'runopencode_exchange_rate'));
            return false;
        }

        return $this->save($rate);
    }

    /**
     * Get FQCN of FormType form.
     *
     * @return string
     */
    protected function getFormType()
    {
        return FormType::class;
    }

    /**
     * Get form.
     *
     * @return Form
     */
    protected function getForm(RateInterface $rate)
    {
        return $this->createForm($this->getFormType(), DtoRate::fromRateInterface($rate));
    }

    /**
     * Save rate.
     *
     * @param RateInterface $rate
     * @return TRUE if successful.
     */
    protected function save(RateInterface $rate)

    {
        try {
            $this->get('runopencode.exchange_rate.repository')->save([$rate]);
            $this->addFlash('success', $this->get('translator')->trans('flash.edit.success', [], 'runopencode_exchange_rate'));
            return true;
        } catch (\Exception $e) {
            $this->addFlash('error', $this->get('translator')->trans('flash.edit.error.unknown', [], 'runopencode_exchange_rate'));
            return false;
        }
    }

    /**
     * Redirect after success.
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    protected function redirectAfterSuccess()
    {
        return $this->redirectToRoute('runopencode_exchange_rate_list');
    }

    /**
     * Get Twig template path.
     *
     * @return string
     */
    protected function getTwigTemplate()
    {
        return '@ExchangeRate/edit.html.twig';
    }
}


1			<?php
2			/*
3			* This file is part of the Exchange Rate Bundle, an RunOpenCode project.
4			*
5			* (c) 2017 RunOpenCode
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10			namespace RunOpenCode\Bundle\ExchangeRate\Controller;
11
12			use RunOpenCode\Bundle\ExchangeRate\Form\Dto\Rate as DtoRate;
13			use RunOpenCode\Bundle\ExchangeRate\Form\FormType;
14			use RunOpenCode\Bundle\ExchangeRate\Security\AccessVoter;
15			use RunOpenCode\ExchangeRate\Contract\RateInterface;
16			use RunOpenCode\ExchangeRate\Contract\RepositoryInterface;
17			use RunOpenCode\ExchangeRate\Model\Rate;
18			use Symfony\Bundle\FrameworkBundle\Controller\Controller;
19			use Symfony\Component\Form\Form;
20			use Symfony\Component\HttpFoundation\Request;
21
22			/**
23			* Class EditController
24			*
25			* @package RunOpenCode\Bundle\ExchangeRate\Controller
26			*/
27			class EditController extends Controller
28			{
29			/**
30			* Main controller action
31			*
32			* @param Request $request
33			*
34			* @return \Symfony\Component\HttpFoundation\RedirectResponse\|\Symfony\Component\HttpFoundation\Response\|\Symfony\Component\HttpKernel\Exception\NotFoundHttpException
35			*/
36	6		public function indexAction(Request $request)
37			{
38	6		$source = $request->get('source');
39	6		$rateType = $request->get('rate_type');
40	6		$currencyCode = $request->get('currency_code');
41	6		$date = \DateTime::createFromFormat('Y-m-d', $request->get('date'));
42
43			/**
44			* @var RepositoryInterface $repository
45			*/
46	6		$repository = $this->get('runopencode.exchange_rate.repository');
47
48	6		if (!$repository->has($source, $currencyCode, $date, $rateType)) {
			0 ignored issues – show Security Bug introduced 2017-05-24 09:38 UTC by Report Bug Copy Issue Report It seems like `$date` defined by `\DateTime::createFromFor... $request->get('date'))` on line `41` can also be of type `false`; however, `RunOpenCode\ExchangeRate...ositoryInterface::has()` does only seem to accept `null\|object<DateTime>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
49	1		throw $this->createNotFoundException();
50			}
51
52	5		$rate = $repository->get($source, $currencyCode, $date, $rateType);
			0 ignored issues – show Security Bug introduced 2017-05-24 09:38 UTC by Report Bug Copy Issue Report It seems like `$date` defined by `\DateTime::createFromFor... $request->get('date'))` on line `41` can also be of type `false`; however, `RunOpenCode\ExchangeRate...ositoryInterface::get()` does only seem to accept `null\|object<DateTime>`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
53
54	5		if (!$this->isGranted(AccessVoter::EDIT, $rate)) {
55	1		throw $this->createAccessDeniedException();
56			}
57
58	4		$form = $this->getForm($rate);
59
60	4		if (true === $this->handleForm($form, $request, $rate)) {
61	1		return $this->redirectAfterSuccess();
62			}
63
64	4		return $this->render($this->getTwigTemplate(), [
65	4		'form' => $form->createView(),
66	4		'rate' => $rate
67			]);
68			}
69
70			/**
71			* Handle form submission.
72			*
73			* @param Form $form
74			* @param Request $request
75			* @param RateInterface $exchangeRate
76			*
77			* @return bool TRUE if successful
78			*/
79	4		protected function handleForm(Form $form, Request $request, RateInterface $exchangeRate)
80			{
81	4		$form->handleRequest($request);
82
83	4		if (!$form->isSubmitted()) {
84	3		return false;
85			}
86
87			/**
88			* @var Rate $rate
89			*/
90	3		$rate = $form->getData()->toRate($exchangeRate);
91
92	3	View Code Duplication	if (!$form->isValid()) {
			0 ignored issues – show Duplication introduced 2017-05-14 19:33 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
93	1		$this->addFlash('error', $this->get('translator')->trans('flash.form.error', [], 'runopencode_exchange_rate'));
94	1		return false;
95			}
96
97	2		return $this->save($rate);
98			}
99
100			/**
101			* Get FQCN of FormType form.
102			*
103			* @return string
104			*/
105	4		protected function getFormType()
106			{
107	4		return FormType::class;
108			}
109
110			/**
111			* Get form.
112			*
113			* @return Form
114			*/
115	4		protected function getForm(RateInterface $rate)
116			{
117	4		return $this->createForm($this->getFormType(), DtoRate::fromRateInterface($rate));
118			}
119
120			/**
121			* Save rate.
122			*
123			* @param RateInterface $rate
124			* @return TRUE if successful.
125			*/
126	2	View Code Duplication	protected function save(RateInterface $rate)
			0 ignored issues – show Duplication introduced 2017-05-24 09:38 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127			{
128			try {
129	2		$this->get('runopencode.exchange_rate.repository')->save([$rate]);
130	1		$this->addFlash('success', $this->get('translator')->trans('flash.edit.success', [], 'runopencode_exchange_rate'));
131	1		return true;
132	1		} catch (\Exception $e) {
133	1		$this->addFlash('error', $this->get('translator')->trans('flash.edit.error.unknown', [], 'runopencode_exchange_rate'));
134	1		return false;
135			}
136			}
137
138			/**
139			* Redirect after success.
140			*
141			* @return \Symfony\Component\HttpFoundation\RedirectResponse
142			*/
143	1		protected function redirectAfterSuccess()
144			{
145	1		return $this->redirectToRoute('runopencode_exchange_rate_list');
146			}
147
148			/**
149			* Get Twig template path.
150			*
151			* @return string
152			*/
153	4		protected function getTwigTemplate()
154			{
155	4		return '@ExchangeRate/edit.html.twig';
156			}
157			}
158

RunOpenCode / exchange-rate-bundle

Push — master ( 431275...4f28c1 )

EditController::getTwigTemplate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like