Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
30 | class Extension extends BaseExtension |
||
31 | { |
||
32 | /** |
||
33 | * {@inheritdoc} |
||
34 | */ |
||
35 | 9 | public function getAlias() |
|
39 | |||
40 | /** |
||
41 | * {@inheritdoc} |
||
42 | */ |
||
43 | 9 | public function getNamespace() |
|
47 | |||
48 | /** |
||
49 | * {@inheritdoc} |
||
50 | */ |
||
51 | public function getXsdValidationBasePath() |
||
55 | |||
56 | /** |
||
57 | * {@inheritdoc} |
||
58 | */ |
||
59 | 9 | public function load(array $config, ContainerBuilder $container) |
|
90 | |||
91 | /** |
||
92 | * Configure base currency. |
||
93 | * |
||
94 | * @param array $config Configuration parameters. |
||
95 | * @param ContainerBuilder $container Service container. |
||
96 | * |
||
97 | * @return Extension $this Fluent interface. |
||
98 | * @throws \RunOpenCode\ExchangeRate\Exception\UnknownCurrencyCodeException |
||
99 | */ |
||
100 | 9 | protected function configureBaseCurrency(array $config, ContainerBuilder $container) |
|
107 | |||
108 | /** |
||
109 | * Configure rates. |
||
110 | * |
||
111 | * @param array $config Configuration parameters. |
||
112 | * @param ContainerBuilder $container Service container. |
||
113 | * |
||
114 | * @return Extension $this Fluent interface. |
||
115 | */ |
||
116 | 9 | protected function configureRates(array $config, ContainerBuilder $container) |
|
139 | |||
140 | |||
141 | /** |
||
142 | * Configure sources which does not have to be explicitly added to service container. |
||
143 | * |
||
144 | * @param array $config Configuration parameters. |
||
145 | * @param ContainerBuilder $container Service container. |
||
146 | * |
||
147 | * @return Extension $this Fluent interface. |
||
148 | */ |
||
149 | 9 | protected function configureSources(array $config, ContainerBuilder $container) |
|
165 | |||
166 | /** |
||
167 | * Configure required processors. |
||
168 | * |
||
169 | * @param array $config Configuration parameters. |
||
170 | * @param ContainerBuilder $container Service container. |
||
171 | * |
||
172 | * @return Extension $this Fluent interface. |
||
173 | */ |
||
174 | 9 | protected function configureRepository(array $config, ContainerBuilder $container) |
|
179 | |||
180 | /** |
||
181 | * Configure file repository. |
||
182 | * |
||
183 | * @param array $config Configuration parameters. |
||
184 | * @param ContainerBuilder $container Service container. |
||
185 | * |
||
186 | * @return Extension $this Fluent interface. |
||
187 | */ |
||
188 | 9 | protected function configureFileRepository(array $config, ContainerBuilder $container) |
|
199 | |||
200 | /** |
||
201 | * Configure Doctrine Dbal repository. |
||
202 | * |
||
203 | * @param array $config Configuration parameters. |
||
204 | * @param ContainerBuilder $container Service container. |
||
205 | * |
||
206 | * @return Extension $this Fluent interface. |
||
207 | */ |
||
208 | 9 | protected function configureDoctrineDbalRepository(array $config, ContainerBuilder $container) |
|
220 | |||
221 | /** |
||
222 | * Configure access voter. |
||
223 | * |
||
224 | * @param array $config Configuration parameters. |
||
225 | * @param ContainerBuilder $container Service container. |
||
226 | * |
||
227 | * @return Extension $this Fluent interface. |
||
228 | */ |
||
229 | 9 | protected function configureAccessVoter(array $config, ContainerBuilder $container) |
|
250 | |||
251 | /** |
||
252 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\SourceType" default settings. |
||
253 | * |
||
254 | * @param array $config Configuration parameters. |
||
255 | * @param ContainerBuilder $container Service container. |
||
256 | * |
||
257 | * @return Extension $this Fluent interface. |
||
258 | */ |
||
259 | 9 | View Code Duplication | protected function configureSourceType(array $config, ContainerBuilder $container) |
271 | |||
272 | /** |
||
273 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\RateTypeType" default settings. |
||
274 | * |
||
275 | * @param array $config Configuration parameters. |
||
276 | * @param ContainerBuilder $container Service container. |
||
277 | * |
||
278 | * @return Extension $this Fluent interface. |
||
279 | */ |
||
280 | 9 | View Code Duplication | protected function configureRateTypeType(array $config, ContainerBuilder $container) |
292 | |||
293 | /** |
||
294 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\CurrencyCodeType" default settings. |
||
295 | * |
||
296 | * @param array $config Configuration parameters. |
||
297 | * @param ContainerBuilder $container Service container. |
||
298 | * @return Extension $this Fluent interface. |
||
299 | */ |
||
300 | 9 | protected function configureCurrencyCodeType(array $config, ContainerBuilder $container) |
|
313 | |||
314 | /** |
||
315 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\ForeignCurrencyCodeType" default settings. |
||
316 | * |
||
317 | * @param array $config Configuration parameters. |
||
318 | * @param ContainerBuilder $container Service container. |
||
319 | * |
||
320 | * @return Extension $this Fluent interface. |
||
321 | */ |
||
322 | 9 | View Code Duplication | protected function configureForeignCurrencyCodeType(array $config, ContainerBuilder $container) |
335 | |||
336 | /** |
||
337 | * Configure "RunOpenCode\\Bundle\\ExchangeRate\\Form\\Type\\RateType" default settings. |
||
338 | * |
||
339 | * @param array $config Configuration parameters. |
||
340 | * @param ContainerBuilder $container Service container. |
||
341 | * |
||
342 | * @return Extension $this Fluent interface. |
||
343 | */ |
||
344 | 9 | View Code Duplication | protected function configureRateType(array $config, ContainerBuilder $container) |
356 | } |
||
357 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: