puck\Controller

Complexity

Total Complexity

9

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	12	1
A	initTwigFilter()	0	4	1
A	initTwigFunction()	0	4	1
A	assign()	0	8	2
A	show()	0	16	4

<?php
namespace puck;

class Controller
{

    protected $viewPath = '';
    private $twig;
    private $tVar = array();
    protected $title='';
    public function __construct()
    {
        $loader = new \Twig_Loader_Filesystem(BASE_PATH . $this->viewPath);
        $twig = new \Twig_Environment($loader, array(
            'debug' => DEBUG,
            'cache' => BASE_PATH . '/cache',
        ));
        $this->twig = $twig;
        $this->initTwigFilter();
        $this->initTwigFunction();
        $this->db = \MysqliDb::getInstance();

The property db does not exist. Did you maybe forget to declare it?

    }
    private function initTwigFilter(){
        $filter = new \Twig_SimpleFilter('long2ip', 'long2ip');
        $this->twig->addFilter($filter);
    }
    private function initTwigFunction(){
        $function = new \Twig_SimpleFunction('I','I');
        $this->twig->addFunction($function);
    }
    protected function assign($name, $value = '')
    {
        if (is_array($name)) {
            $this->tVar = array_merge($this->tVar, $name);
        } else {
            $this->tVar[$name] = $value;
        }
    }

    protected function show($tmpPath = '')
    {
        if ($tmpPath == '') {
            if (defined("CONTROLLER_NAME") && defined("ACTION_NAME")) {
                $tmpPath = CONTROLLER_NAME . '/' . ACTION_NAME;
            } else {
                show_json($this->tVar);
            }
        }
        header('Content-Type:text/html; charset=utf-8');
        header('Cache-control: private'); // 页面缓存控制
        header('X-Powered-By:ViviAnAuthSystem');
        $this->assign('title',$this->title);
        echo $this->twig->render($tmpPath . '.' . TempExt, $this->tVar);
        die();

The method show() contains an exit expression.

    }
}