App::initEnv() - Code Metrics - Inspection of "支持cli模式默认路由" - Rozbo/puck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 381e61...c34c78 )

by kill

created 2017-04-16 14:57 UTC

App::initEnv() B

↳ Parent: App

Complexity

Conditions	4
Paths	5

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	17
nc	5
nop	0
dl	0
loc	23
ccs	0
cts	0
cp	0
crap	20
rs	8.7972
c	0
b	0
f	0

<?php
/**
 * Created by rozbo at 2017/3/18 下午8:52
 */

namespace puck;


use Dotenv\Dotenv;
use puck\Config;
use puck\Route;
use puck\tools\Arr;
use Whoops\Run;

class App extends Container {
    /**
     * 已经加载的config文件
     *
     * @var array
     */
    protected $loadedConfigurations = [];

    /**
     * 应用的根目录.
     *
     * @var string
     */
    protected $basePath;
    public function __construct($basePath) {
        $this->basePath=$basePath;
        $this->initEnv();
        $this->initContainer();
        $this->initConfig();
    }
    private function initConfig(){
        $this->configure('core');
    }

    private function initEnv(){
        try{
            $dotEnv = new Dotenv($this->basePath);
            $dotEnv->load();
        }
        catch (\Dotenv\Exception\InvalidPathException $e){
            die("环境配置文件`.env`没有被找到.");

        }
        date_default_timezone_set(env('APP_TIMEZONE', 'Asia/Shanghai'));
        define('IS_CLI', $this->runningInConsole());
        define('IS_DEBUG',env('DEBUG',false));
        if (IS_DEBUG) {
            error_reporting(E_ALL);
            @ini_set('display_errors', 'On');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            //@ob_start();
            $whoops=new Run;
            $handle=IS_CLI ? "PlainTextHandler" : "PrettyPageHandler";
            $handle="\\Whoops\\Handler\\".$handle;
            $whoops->pushHandler(new $handle);
            $whoops->register();
        }

    }

    public function run() {
        $this->route->dispatch();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    /**
     * 初始化容器
     */
    private function initContainer() {
        static::setInstance($this);
        $this->instance('app',$this);
        $this->instance('config',new Config());
        $this->instance('request',new Request($this->config));

        $this->instance('route',new Route($this->request));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->bind('pinyin','\puck\helpers\PinYin');
        $this->bind('curl','\puck\helpers\Curl');
    }

    /**
     * Get the base path for the application.
     *
     * @param  string|null  $path
     * @return string
     */
    public function basePath($path = null)
    {
        if (isset($this->basePath)) {
            return $this->basePath.($path ? '/'.$path : $path);
        }

        if ($this->runningInConsole()) {
            $this->basePath = getcwd();
        } else {
            $this->basePath = realpath(getcwd().'/../');
        }

        return $this->basePath($path);
    }
    /**
     * 判断是否是cli模式
     *
     * @return bool
     */
    public function runningInConsole()
    {
        return php_sapi_name() == 'cli';
    }
    /**
     * 加载一个配置文件
     *
     * @param  string  $name
     * @return void
     */
    public function configure($name)
    {
        if (isset($this->loadedConfigurations[$name])) {
            return;
        }
        //标记为已加载
        $this->loadedConfigurations[$name] = true;
        $path = $this->getConfigurationPath($name);
        if ($path) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->make('config')->set($name, require $path);
        }
    }


    /**
     * 获取配置文件的路径。
     *
     * 如果没有给定配置文件的名字，则返回目录。
     *
     * 如果应用目录下有相应配置文件则优先返回。
     *
     * @param  string|null  $name
     * @return string
     */
    public function getConfigurationPath($name = null)
    {
        if (! $name) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $appConfigDir = $this->basePath('configs').'/';

            if (file_exists($appConfigDir)) {
                return $appConfigDir;
            } elseif (file_exists($path = __DIR__.'/configs/')) {
                return $path;
            }
        } else {
            $appConfigPath = $this->basePath('configs').'/'.$name.'.php';
            if (file_exists($appConfigPath)) {
                return $appConfigPath;
            } elseif (file_exists($path = __DIR__.'/configs/'.$name.'.php')) {
                return $path;
            }
        }
    }
}

1		<?php
2		/**
3		* Created by rozbo at 2017/3/18 下午8:52
4		*/
5
6		namespace puck;
7
8
9		use Dotenv\Dotenv;
10		use puck\Config;
11		use puck\Route;
12		use puck\tools\Arr;
13		use Whoops\Run;
14
15		class App extends Container {
16		/**
17		* 已经加载的config文件
18		*
19		* @var array
20		*/
21		protected $loadedConfigurations = [];
22
23		/**
24		* 应用的根目录.
25		*
26		* @var string
27		*/
28		protected $basePath;
29		public function __construct($basePath) {
30		$this->basePath=$basePath;
31		$this->initEnv();
32		$this->initContainer();
33		$this->initConfig();
34		}
35		private function initConfig(){
36		$this->configure('core');
37		}
38
39		private function initEnv(){
40		try{
41		$dotEnv = new Dotenv($this->basePath);
42		$dotEnv->load();
43		}
44		catch (\Dotenv\Exception\InvalidPathException $e){
45		die("环境配置文件`.env`没有被找到.");
		0 ignored issues – show Coding Style Compatibility introduced 2017-04-16 14:59 UTC by Report Bug Copy Issue Report The method `initEnv()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
46		}
47		date_default_timezone_set(env('APP_TIMEZONE', 'Asia/Shanghai'));
48		define('IS_CLI', $this->runningInConsole());
49		define('IS_DEBUG',env('DEBUG',false));
50		if (IS_DEBUG) {
51		error_reporting(E_ALL);
52		@ini_set('display_errors', 'On');
		0 ignored issues – show Security Best Practice introduced 2017-03-19 08:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
53		//@ob_start();
54		$whoops=new Run;
55		$handle=IS_CLI ? "PlainTextHandler" : "PrettyPageHandler";
56		$handle="\\Whoops\\Handler\\".$handle;
57		$whoops->pushHandler(new $handle);
58		$whoops->register();
59		}
60
61		}
62
63		public function run() {
64		$this->route->dispatch();
		0 ignored issues – show Documentation introduced 2017-03-19 14:34 UTC by Report Bug Copy Issue Report The property `route` does not exist on `object<puck\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
65		}
66		/**
67		* 初始化容器
68		*/
69		private function initContainer() {
70		static::setInstance($this);
71		$this->instance('app',$this);
72		$this->instance('config',new Config());
73		$this->instance('request',new Request($this->config));
		0 ignored issues – show Bug introduced 2017-03-19 14:34 UTC by Report Bug Copy Issue Report The property `config` does not seem to exist. Did you mean `loadedConfigurations`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
74		$this->instance('route',new Route($this->request));
		0 ignored issues – show Documentation introduced 2017-03-19 14:34 UTC by Report Bug Copy Issue Report The property `request` does not exist on `object<puck\App>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
75		$this->bind('pinyin','\puck\helpers\PinYin');
76		$this->bind('curl','\puck\helpers\Curl');
77		}
78
79		/**
80		* Get the base path for the application.
81		*
82		* @param string\|null $path
83		* @return string
84		*/
85	3	public function basePath($path = null)
86		{
87	3	if (isset($this->basePath)) {
88	3	return $this->basePath.($path ? '/'.$path : $path);
89		}
90
91		if ($this->runningInConsole()) {
92		$this->basePath = getcwd();
93		} else {
94		$this->basePath = realpath(getcwd().'/../');
95		}
96
97		return $this->basePath($path);
98		}
99		/**
100		* 判断是否是cli模式
101		*
102		* @return bool
103		*/
104		public function runningInConsole()
105		{
106		return php_sapi_name() == 'cli';
107		}
108		/**
109		* 加载一个配置文件
110		*
111		* @param string $name
112		* @return void
113		*/
114		public function configure($name)
115		{
116		if (isset($this->loadedConfigurations[$name])) {
117		return;
118		}
119		//标记为已加载
120		$this->loadedConfigurations[$name] = true;
121		$path = $this->getConfigurationPath($name);
122		if ($path) {
		0 ignored issues – show Bug Best Practice introduced 2017-03-19 14:34 UTC by Report Bug Copy Issue Report The expression `$path` of type `string\|null` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
123		$this->make('config')->set($name, require $path);
124		}
125		}
126
127
128		/**
129		* 获取配置文件的路径。
130		*
131		* 如果没有给定配置文件的名字，则返回目录。
132		*
133		* 如果应用目录下有相应配置文件则优先返回。
134		*
135		* @param string\|null $name
136		* @return string
137		*/
138		public function getConfigurationPath($name = null)
139		{
140		if (! $name) {
		0 ignored issues – show Bug Best Practice introduced 2017-03-19 14:34 UTC by Report Bug Copy Issue Report The expression `$name` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
141		$appConfigDir = $this->basePath('configs').'/';
142
143		if (file_exists($appConfigDir)) {
144		return $appConfigDir;
145		} elseif (file_exists($path = __DIR__.'/configs/')) {
146		return $path;
147		}
148		} else {
149		$appConfigPath = $this->basePath('configs').'/'.$name.'.php';
150		if (file_exists($appConfigPath)) {
151		return $appConfigPath;
152		} elseif (file_exists($path = __DIR__.'/configs/'.$name.'.php')) {
153		return $path;
154		}
155		}
156		}
157		}

Rozbo / puck

Push — master ( 381e61...c34c78 )

App::initEnv() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like