App::initEnv() - Code Metrics - Inspection of "改变入口方式" - Rozbo/puck - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 37d3cb...34a83f )

by kill

created 2017-03-19 08:12 UTC

App::initEnv() A

↳ Parent: App

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
cc	3
eloc	13
nc	3
nop	0
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
ccs	0
cts	0
cp	0
crap	12

<?php
/**
 * Created by rozbo at 2017/3/18 下午8:52
 */

namespace puck;


use Dotenv\Dotenv;
use Whoops\Run;

class App extends Container {

    /**
     * 应用的根目录.
     *
     * @var string
     */
    protected $basePath;
    public function __construct($basePath) {
        $this->basePath=$basePath;
        $this->initEnv();
        $this->initContainer();
    }

    private function initEnv(){
        $dotEnv = new Dotenv($this->basePath);
        $dotEnv->load();
        date_default_timezone_set(env('APP_TIMEZONE', 'Asia/Shanghai'));
        define('IS_CLI', php_sapi_name() == 'cli');
        if (env('DEBUG',false)) {
            error_reporting(E_ALL);
            @ini_set('display_errors', 'On');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            //@ob_start();
            $whoops=new Run;
            $handle=IS_CLI ? "PlainTextHandler" : "PrettyPageHandler";
            $handle="\\Whoops\\Handler\\".$handle;
            $whoops->pushHandler(new $handle);
            $whoops->register();
        }

    }
    /**
     * 初始化容器
     */
    private function initContainer() {
        static::setInstance($this);
        $this->instance('app',$this);
        $this->bind('pinyin','\puck\helpers\PinYin');
    }

}

1			<?php
2			/**
3			* Created by rozbo at 2017/3/18 下午8:52
4			*/
5
6			namespace puck;
7
8
9			use Dotenv\Dotenv;
10			use Whoops\Run;
11
12			class App extends Container {
13
14			/**
15			* 应用的根目录.
16			*
17			* @var string
18			*/
19			protected $basePath;
20			public function __construct($basePath) {
21			$this->basePath=$basePath;
22			$this->initEnv();
23			$this->initContainer();
24			}
25
26			private function initEnv(){
27			$dotEnv = new Dotenv($this->basePath);
28			$dotEnv->load();
29			date_default_timezone_set(env('APP_TIMEZONE', 'Asia/Shanghai'));
30			define('IS_CLI', php_sapi_name() == 'cli');
31			if (env('DEBUG',false)) {
32			error_reporting(E_ALL);
33			@ini_set('display_errors', 'On');
			0 ignored issues – show Security Best Practice introduced 2017-03-19 08:16 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
34			//@ob_start();
35			$whoops=new Run;
36			$handle=IS_CLI ? "PlainTextHandler" : "PrettyPageHandler";
37			$handle="\\Whoops\\Handler\\".$handle;
38			$whoops->pushHandler(new $handle);
39			$whoops->register();
40			}
41
42			}
43			/**
44			* 初始化容器
45			*/
46			private function initContainer() {
47			static::setInstance($this);
48			$this->instance('app',$this);
49			$this->bind('pinyin','\puck\helpers\PinYin');
50			}
51
52			}

Rozbo / puck

Push — master ( 37d3cb...34a83f )

App::initEnv() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like