puck\App

Complexity

Total Complexity

22

Size/Duplication

Total Lines	147
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	6

Test Coverage

Coverage

42.86%

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	runningInConsole()	0	3	1
B	initEnv()	0	23	4
A	initContainer()	0	12	1
A	initConfig()	0	3	1
A	configure()	0	12	3
B	getConfigurationPath()	0	19	6
A	basePath()	0	13	4
A	run()	0	3	1

<?php
/**
 * Created by rozbo at 2017/3/18 下午8:52
 */

namespace puck;


use Dotenv\Dotenv;
use Whoops\Run;

class App extends Container {
    /**
     * 已经加载的config文件
     *
     * @var array
     */
    protected $loadedConfigurations = [];

    /**
     * 应用的根目录.
     *
     * @var string
     */
    protected $basePath;
    public function __construct($basePath) {
        $this->basePath=$basePath;
        $this->initEnv();
        $this->initContainer();
        $this->initConfig();
    }

    private function initEnv(){
        try{
            $dotEnv = new Dotenv($this->basePath);
            $dotEnv->load();
        }
        catch (\Dotenv\Exception\InvalidPathException $e){

Consider adding a comment why this CATCH block is empty.

        }
        date_default_timezone_set(env('APP_TIMEZONE', 'Asia/Shanghai'));
        define('IS_CLI', $this->runningInConsole());
        define('IS_DEBUG',env('DEBUG',false));
        if (IS_DEBUG) {
            error_reporting(E_ALL);
            @ini_set('display_errors', 'On');

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            //@ob_start();
            $whoops=new Run;
            $handle=IS_CLI ? "PlainTextHandler" : "PrettyPageHandler";
            $handle="\\Whoops\\Handler\\".$handle;
            $whoops->pushHandler(new $handle);
            $whoops->register();
        }

    }

    /**
     * 判断是否是cli模式
     *
     * @return bool
     */
    public function runningInConsole() {
        return php_sapi_name() == 'cli';
    }

    /**
     * 初始化容器
     */
    private function initContainer() {
        static::setInstance($this);
        $this->instance('app',$this);
        $this->instance('config',new Config());
        $this->instance('request',new Request($this->config));

The property config does not seem to exist. Did you mean loadedConfigurations?

        $this->instance('route',new Route($this->request));

The property request does not exist on object<puck\App>. Since you implemented __get, maybe consider adding a @property annotation.

        $this->regexBind('#^(\w+)_model$#', "\\app\\models\\\\$1");
        $this->bind('pinyin','\puck\helpers\PinYin');
        $this->bind('curl','\puck\helpers\Curl');
        $this->bind('dom', '\puck\helpers\Dom');
        $this->bind('db', '\puck\Db');
    }

    private function initConfig() {
        $this->configure('core');
    }

    /**
     * 加载一个配置文件
     *
     * @param  string  $name
     * @return void
     */
    public function configure($name)
    {
        if (isset($this->loadedConfigurations[$name])) {
            return;
        }
        //标记为已加载
        $this->loadedConfigurations[$name] = true;
        $path = $this->getConfigurationPath($name);
        if ($path) {

The expression $path of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $this->make('config')->set($name, require $path);
        }
    }

    /**
     * 获取配置文件的路径。
     *
     * 如果没有给定配置文件的名字，则返回目录。
     *
     * 如果应用目录下有相应配置文件则优先返回。
     *
     * @param  string|null  $name
     * @return string
     */
    public function getConfigurationPath($name = null)
    {
        if (! $name) {

The expression $name of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $appConfigDir = $this->basePath('configs').'/';

            if (file_exists($appConfigDir)) {
                return $appConfigDir;
            } elseif (file_exists($path = __DIR__.'/configs/')) {
                return $path;
            }
        } else {
            $appConfigPath = $this->basePath('configs').'/'.$name.'.php';
            if (file_exists($appConfigPath)) {
                return $appConfigPath;
            } elseif (file_exists($path = __DIR__.'/configs/'.$name.'.php')) {
                return $path;
            }
        }
    }

    /**
     * Get the base path for the application.
     *
     * @param  string|null $path
     * @return string
     */
    public function basePath($path = null) {
        if (isset($this->basePath)) {
            return $this->basePath . ($path ? '/' . $path : $path);
        }

        if ($this->runningInConsole()) {
            $this->basePath = getcwd();
        } else {
            $this->basePath = realpath(getcwd() . '/../');
        }

        return $this->basePath($path);
    }

    public function run() {
        $this->route->dispatch();

The property route does not exist on object<puck\App>. Since you implemented __get, maybe consider adding a @property annotation.

    }
}