@@ -146,8 +146,7 @@ discard block |
||
146 | 146 | // Compare the current states with the set of valid states |
147 | 147 | if ($intersect) { |
148 | 148 | $remaining_states = array_intersect($current_states, $valid_states); |
149 | - } |
|
150 | - else { |
|
149 | + } else { |
|
151 | 150 | $remaining_states = array_diff($current_states, $valid_states); |
152 | 151 | } |
153 | 152 | |
@@ -155,8 +154,7 @@ discard block |
||
155 | 154 | // Unit is in a state that is within the set of valid states so add to result set |
156 | 155 | $units[$unit] = $unit; |
157 | 156 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE); |
158 | - } |
|
159 | - else { |
|
157 | + } else { |
|
160 | 158 | $response->addMiss($keyed_units[$unit], CalendarResponse::INVALID_STATE); |
161 | 159 | } |
162 | 160 | |
@@ -250,8 +248,7 @@ discard block |
||
250 | 248 | foreach ($days as $day => $value) { |
251 | 249 | $result[$year][$month][$day] = ((int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day]); |
252 | 250 | } |
253 | - } |
|
254 | - else { |
|
251 | + } else { |
|
255 | 252 | foreach ($days as $day => $value) { |
256 | 253 | $result[$year][$month][$day] = $keyed_units[$unit]->getDefaultValue(); |
257 | 254 | } |
@@ -282,8 +279,7 @@ discard block |
||
282 | 279 | foreach ($hours as $hour => $value) { |
283 | 280 | if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { |
284 | 281 | $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]); |
285 | - } |
|
286 | - else { |
|
282 | + } else { |
|
287 | 283 | // If nothing from db - then revert to the defaults |
288 | 284 | $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue(); |
289 | 285 | } |
@@ -331,8 +327,7 @@ discard block |
||
331 | 327 | foreach ($minutes as $minute => $value) { |
332 | 328 | if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { |
333 | 329 | $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]); |
334 | - } |
|
335 | - else { |
|
330 | + } else { |
|
336 | 331 | // If nothing from db - then revert to the defaults |
337 | 332 | $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue(); |
338 | 333 | } |
@@ -393,8 +388,12 @@ discard block |
||
393 | 388 | |
394 | 389 | // Make sure years are sorted |
395 | 390 | ksort($data[Event::BAT_DAY]); |
396 | - if (isset($data[Event::BAT_HOUR])) ksort($data[Event::BAT_HOUR]); |
|
397 | - if (isset($data[Event::BAT_MINUTE])) ksort($data[Event::BAT_MINUTE]); |
|
391 | + if (isset($data[Event::BAT_HOUR])) { |
|
392 | + ksort($data[Event::BAT_HOUR]); |
|
393 | + } |
|
394 | + if (isset($data[Event::BAT_MINUTE])) { |
|
395 | + ksort($data[Event::BAT_MINUTE]); |
|
396 | + } |
|
398 | 397 | |
399 | 398 | // Set up variables to keep track of stuff |
400 | 399 | $current_value = NULL; |
@@ -419,8 +418,7 @@ discard block |
||
419 | 418 | if ($current_value === $minute_value) { |
420 | 419 | // We are still in minutes and going through so add a minute |
421 | 420 | $end_event->add(new \DateInterval('PT1M')); |
422 | - } |
|
423 | - elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
421 | + } elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
424 | 422 | // Value just switched - let us wrap up with current event and start a new one |
425 | 423 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
426 | 424 | $start_event = clone($end_event->add(new \DateInterval('PT1M'))); |
@@ -434,12 +432,10 @@ discard block |
||
434 | 432 | } |
435 | 433 | $current_value = $minute_value; |
436 | 434 | } |
437 | - } |
|
438 | - elseif ($current_value === $hour_value) { |
|
435 | + } elseif ($current_value === $hour_value) { |
|
439 | 436 | // We are in hours and can add something |
440 | 437 | $end_event->add(new \DateInterval('PT1H')); |
441 | - } |
|
442 | - elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
438 | + } elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
443 | 439 | $skip_finalize_event = FALSE; |
444 | 440 | |
445 | 441 | if ($is_daylight_saving_time) { |
@@ -466,12 +462,10 @@ discard block |
||
466 | 462 | $current_value = $hour_value; |
467 | 463 | } |
468 | 464 | } |
469 | - } |
|
470 | - elseif ($current_value === $value) { |
|
465 | + } elseif ($current_value === $value) { |
|
471 | 466 | // We are adding a whole day so the end event gets moved to the end of the day we are adding |
472 | 467 | $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . '23:59'); |
473 | - } |
|
474 | - elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
468 | + } elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
475 | 469 | // Value just switched - let us wrap up with current event and start a new one |
476 | 470 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
477 | 471 | // Start event becomes the end event with a minute added |
@@ -506,8 +500,7 @@ discard block |
||
506 | 500 | if ($event->endsLater($end_date)) { |
507 | 501 | $event->setEndDate($end_date); |
508 | 502 | } |
509 | - } |
|
510 | - else { |
|
503 | + } else { |
|
511 | 504 | // Event completely not in range so unset it |
512 | 505 | unset($normalized_events[$unit_id][$key]); |
513 | 506 | } |
@@ -538,8 +531,7 @@ discard block |
||
538 | 531 | $e++; |
539 | 532 | $flipped[$e][$value][$datum] = $datum; |
540 | 533 | $old_value = $value; |
541 | - } |
|
542 | - else { |
|
534 | + } else { |
|
543 | 535 | $flipped[$e][$value][$datum] = $datum; |
544 | 536 | } |
545 | 537 | } |