SqlLiteDBStore::getEventData() - Code Metrics - Inspection of "Add SqlLiteDBStore" - Roomify/bat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d93fe...e96ad3 )

unknown

created 2016-01-05 11:52 UTC

SqlLiteDBStore::getEventData() D

↳ Parent: SqlLiteDBStore

Complexity

Conditions	9
Paths	72

Size

Total Lines	44
Code Lines	22

Duplication

Lines	15
Ratio	34.09 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	15
loc	44
rs	4.9091
cc	9
eloc	22
nc	72
nop	3

<?php

/**
 * @file
 * Class SqlLiteDBStore
 */

namespace Roomify\Bat\Store;

use Roomify\Bat\Event\Event;
use Roomify\Bat\Store\SqlDBStore;

/**
 * This is a SqlLite implementation of the Store.
 *
 */
class SqlLiteDBStore extends SqlDBStore {

  protected $pdo;

  public function __construct(\PDO $pdo, $event_type, $event_data = 'state') {
    parent::__construct($event_type, $event_data);

    $this->pdo = $pdo;
  }

  /**
   *
   * @param \DateTime $start_date
   * @param \DateTime $end_date
   * @param $unit_ids
   *
   * @return array
   */
  public function getEventData(\DateTime $start_date, \DateTime $end_date, $unit_ids) {

    $queries  = $this->buildQueries($start_date, $end_date, $unit_ids);

    $results = array();
    // Run each query and store results
    foreach ($queries as $type => $query) {
      $results[$type] = $this->pdo->query($query);
    }

    $db_events = array();

    // Cycle through day results and setup an event array
    foreach ($results[Event::BAT_DAY]->fetchAll() as $data) {
      // Figure out how many days the current month has
      $temp_date = new \DateTime($data['year'] . "-" . $data['month']);
      $days_in_month = (int)$temp_date->format('t');
      for ($i = 1; $i<=$days_in_month; $i++) {

        $db_events[$data['unit_id']][Event::BAT_DAY][$data['year']][$data['month']]['d' . $i] = $data['d'.$i];
      }
    }

    // With the day events taken care off let's cycle through hours
    foreach ($results[Event::BAT_HOUR]->fetchAll() as $data) {
      for ($i = 0; $i<=23; $i++) {

        $db_events[$data['unit_id']][Event::BAT_HOUR][$data['year']][$data['month']][$data['day']]['h'. $i] = $data['h'.$i];
      }
    }

    // With the hour events taken care off let's cycle through minutes
    foreach ($results[Event::BAT_MINUTE]->fetchAll() as $data) {
      for ($i = 0; $i<=59; $i++) {

        if ($i <= 9) {
          $index = 'm0'.$i;
        }
        else {
          $index = 'm'.$i;
        }
        $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index];
      }
    }

    return $db_events;
  }

  /**
   * @param \Roomify\Bat\Event\Event $event
   * @param $granularity
   *
   * @return bool
   */
  public function storeEvent(Event $event, $granularity = Event::BAT_HOURLY) {
    $stored = TRUE;

    try {
      // Itemize an event so we can save it
      $itemized = $event->itemizeEvent($granularity);

      // Write days
      foreach ($itemized[Event::BAT_DAY] as $year => $months) {
        foreach ($months as $month => $days) {
          $values = array_values($days);
          $keys = array_keys($days);
          $this->pdo->exec("INSERT OR REPLACE INTO $this->day_table (unit_id, year, month, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . implode(', ', $values) . ")");
        }
      }

      if ($granularity == Event::BAT_HOURLY) {
        // Write Hours
        foreach ($itemized[Event::BAT_HOUR] as $year => $months) {
          foreach ($months as $month => $days) {

            foreach ($days as $day => $hours) {
              // Count required as we may receive empty hours for granular events that start and end on midnight
              if (count($hours) > 0) {
                $values = array_values($hours);
                $keys = array_keys($hours);
                $this->pdo->exec("INSERT OR REPLACE INTO $this->hour_table (unit_id, year, month, day, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . implode(', ', $values) . ")");
              }
            }
          }
        }

        // If we have minutes write minutes
        foreach ($itemized[Event::BAT_MINUTE] as $year => $months) {
          foreach ($months as $month => $days) {
            foreach ($days as $day => $hours) {

              foreach ($hours as $hour => $minutes) {
                $values = array_values($minutes);
                $keys = array_keys($minutes);
                $this->pdo->exec("INSERT OR REPLACE INTO $this->minute_table (unit_id, year, month, day, hour, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . substr($hour, 1) . ", " . implode(', ', $values) . ")");
              }
            }
          }
        }
      }
    }
    catch (\Exception $e) {
      $saved = FALSE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    return $stored;
  }

}


1		<?php
2
3		/**
4		* @file
5		* Class SqlLiteDBStore
6		*/
7
8		namespace Roomify\Bat\Store;
9
10		use Roomify\Bat\Event\Event;
11		use Roomify\Bat\Store\SqlDBStore;
12
13		/**
14		* This is a SqlLite implementation of the Store.
15		*
16		*/
17		class SqlLiteDBStore extends SqlDBStore {
18
19		protected $pdo;
20
21		public function __construct(\PDO $pdo, $event_type, $event_data = 'state') {
22		parent::__construct($event_type, $event_data);
23
24		$this->pdo = $pdo;
25		}
26
27		/**
28		*
29		* @param \DateTime $start_date
30		* @param \DateTime $end_date
31		* @param $unit_ids
32		*
33		* @return array
34		*/
35		public function getEventData(\DateTime $start_date, \DateTime $end_date, $unit_ids) {
36
37		$queries = $this->buildQueries($start_date, $end_date, $unit_ids);
38
39		$results = array();
40		// Run each query and store results
41		foreach ($queries as $type => $query) {
42		$results[$type] = $this->pdo->query($query);
43		}
44
45		$db_events = array();
46
47		// Cycle through day results and setup an event array
48		foreach ($results[Event::BAT_DAY]->fetchAll() as $data) {
49		// Figure out how many days the current month has
50		$temp_date = new \DateTime($data['year'] . "-" . $data['month']);
51		$days_in_month = (int)$temp_date->format('t');
52	View Code Duplication	for ($i = 1; $i<=$days_in_month; $i++) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		$db_events[$data['unit_id']][Event::BAT_DAY][$data['year']][$data['month']]['d' . $i] = $data['d'.$i];
54		}
55		}
56
57		// With the day events taken care off let's cycle through hours
58		foreach ($results[Event::BAT_HOUR]->fetchAll() as $data) {
59	View Code Duplication	for ($i = 0; $i<=23; $i++) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		$db_events[$data['unit_id']][Event::BAT_HOUR][$data['year']][$data['month']][$data['day']]['h'. $i] = $data['h'.$i];
61		}
62		}
63
64		// With the hour events taken care off let's cycle through minutes
65		foreach ($results[Event::BAT_MINUTE]->fetchAll() as $data) {
66	View Code Duplication	for ($i = 0; $i<=59; $i++) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		if ($i <= 9) {
68		$index = 'm0'.$i;
69		}
70		else {
71		$index = 'm'.$i;
72		}
73		$db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index];
74		}
75		}
76
77		return $db_events;
78		}
79
80		/**
81		* @param \Roomify\Bat\Event\Event $event
82		* @param $granularity
83		*
84		* @return bool
85		*/
86		public function storeEvent(Event $event, $granularity = Event::BAT_HOURLY) {
87		$stored = TRUE;
88
89		try {
90		// Itemize an event so we can save it
91		$itemized = $event->itemizeEvent($granularity);
92
93		// Write days
94		foreach ($itemized[Event::BAT_DAY] as $year => $months) {
95		foreach ($months as $month => $days) {
96		$values = array_values($days);
97		$keys = array_keys($days);
98		$this->pdo->exec("INSERT OR REPLACE INTO $this->day_table (unit_id, year, month, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . implode(', ', $values) . ")");
99		}
100		}
101
102		if ($granularity == Event::BAT_HOURLY) {
103		// Write Hours
104		foreach ($itemized[Event::BAT_HOUR] as $year => $months) {
105	View Code Duplication	foreach ($months as $month => $days) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		foreach ($days as $day => $hours) {
107		// Count required as we may receive empty hours for granular events that start and end on midnight
108		if (count($hours) > 0) {
109		$values = array_values($hours);
110		$keys = array_keys($hours);
111		$this->pdo->exec("INSERT OR REPLACE INTO $this->hour_table (unit_id, year, month, day, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . implode(', ', $values) . ")");
112		}
113		}
114		}
115		}
116
117		// If we have minutes write minutes
118		foreach ($itemized[Event::BAT_MINUTE] as $year => $months) {
119		foreach ($months as $month => $days) {
120	View Code Duplication	foreach ($days as $day => $hours) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
121		foreach ($hours as $hour => $minutes) {
122		$values = array_values($minutes);
123		$keys = array_keys($minutes);
124		$this->pdo->exec("INSERT OR REPLACE INTO $this->minute_table (unit_id, year, month, day, hour, " . implode(', ', $keys) . ") VALUES (" . $event->getUnitId() . ", $year, $month, " . substr($day, 1) . ", " . substr($hour, 1) . ", " . implode(', ', $values) . ")");
125		}
126		}
127		}
128		}
129		}
130		}
131		catch (\Exception $e) {
132		$saved = FALSE;
		0 ignored issues – show Unused Code introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report `$saved` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
133		}
134
135		return $stored;
136		}
137
138		}
139

Roomify / bat

GitHub Access Token became invalid

Push — master ( 5d93fe...e96ad3 )

SqlLiteDBStore::getEventData() D

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like