SqlDBStore::__construct() - Code Metrics - Inspection of "Add SqlLiteDBStore" - Roomify/bat - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5d93fe...e96ad3 )

unknown

created 2016-01-05 11:52 UTC

SqlDBStore::__construct() A

↳ Parent: SqlDBStore

Complexity

Conditions	3
Paths	4

Size

Total Lines	17
Code Lines	10

Duplication

Lines	10
Ratio	58.82 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	10
loc	17
rs	9.4286
cc	3
eloc	10
nc	4
nop	2

<?php

/**
 * @file
 * Class SqlDBStore
 */

namespace Roomify\Bat\Store;

use Roomify\Bat\Event\Event;
use Roomify\Bat\Store\SqlDBStore;

/**
 * This is a generic Sql implementation of the Store.
 *
 */
abstract class SqlDBStore extends Store {

  // There are two types of stores - for event ids and status
  const BAT_EVENT = 'event';
  const BAT_STATE = 'state';

  /**
   * The table that holds day data.
   * @var
   */
  public $day_table;

  /**
   * The table that holds hour data.
   * @var
   */
  public $hour_table;

  /**
   * The table that holds minute data.
   * @var
   */
  public $minute_table;

  /**
   * The event type we are dealing with.
   * @var
   */
  public $event_type;

  /**
   * SqlDBStore constructor.
   *
   * Provided with the event type it will determine the appropriate table names to
   * store data in. This assumes standard behaviour from Bat_Event
   * @param $event_type
   * @param string $event_data
   */
  public function __construct($event_type, $event_data = 'state') {

    $this->event_type = $event_type;

    if ($event_data == SqlDBStore::BAT_STATE) {

      $this->day_table = 'bat_event_' . $event_type . '_day_' . SqlDBStore::BAT_STATE;
      $this->hour_table = 'bat_event_' . $event_type . '_hour_' . SqlDBStore::BAT_STATE;
      $this->minute_table = 'bat_event_' . $event_type . '_minute_' . SqlDBStore::BAT_STATE;
    }

    if ($event_data == SqlDBStore::BAT_EVENT) {

      $this->day_table = 'bat_event_' . $event_type . '_day_' . SqlDBStore::BAT_EVENT;
      $this->hour_table = 'bat_event_' . $event_type . '_hour_' . SqlDBStore::BAT_EVENT;
      $this->minute_table = 'bat_event_' . $event_type . '_minute_' . SqlDBStore::BAT_EVENT;
    }

  }

  /**
   * @param \DateTime $start_date
   * @param \DateTime $end_date
   * @param $unit_ids
   *
   * @return array
   */
  public function buildQueries(\DateTime $start_date, \DateTime $end_date, $unit_ids) {
    $queries = array();

    $queries[Event::BAT_DAY] = 'SELECT * FROM ' . $this->day_table . ' WHERE ';
    $queries[Event::BAT_HOUR] = 'SELECT * FROM ' . $this->hour_table . ' WHERE ';
    $queries[Event::BAT_MINUTE] = 'SELECT * FROM ' . $this->minute_table . ' WHERE ';

    $hours_query = TRUE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $minutes_query = TRUE;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    // Create a mock event which we will use to determine how to query the database
    $mock_event = new Event($start_date, $end_date, 0, -10);
    // We don't need a granular event even if we are retrieving granular data - since we don't
    // know what the event break-down is going to be we need to get the full range of data from
    // days, hours and minutes.
    $itemized = $mock_event->itemizeEvent(Event::BAT_DAILY);

    $year_count = 0;
    $hour_count = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    $minute_count = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

    $query_parameters = '';

    foreach($itemized[Event::BAT_DAY] as $year => $months) {
      if ($year_count > 0) {
        // We are dealing with multiple years so add an OR
        $query_parameters .= ' OR ';
      }
      $query_parameters .= 'year IN (' . $year . ') ';
      $query_parameters .= 'AND month IN (' . implode("," ,array_keys($months)) .') ';
      if (count($unit_ids) > 0) {
        // Unit ids are defined so add this as a filter
        $query_parameters .= 'AND unit_id in (' . implode("," , $unit_ids) .') ';
      }
      $year_count++;
    }

    // Add parameters to each query
    $queries[Event::BAT_DAY] .= $query_parameters;
    $queries[Event::BAT_HOUR] .= $query_parameters;
    $queries[Event::BAT_MINUTE] .= $query_parameters;

    // Clean up and add ordering information
    $queries[Event::BAT_DAY] .= ' ORDER BY unit_id, year, month';
    $queries[Event::BAT_HOUR] .= ' ORDER BY unit_id, year, month, day';
    $queries[Event::BAT_MINUTE] .= ' ORDER BY unit_id, year, month, day, hour';

    return $queries;
  }

}


1		<?php
2
3		/**
4		* @file
5		* Class SqlDBStore
6		*/
7
8		namespace Roomify\Bat\Store;
9
10		use Roomify\Bat\Event\Event;
11		use Roomify\Bat\Store\SqlDBStore;
12
13		/**
14		* This is a generic Sql implementation of the Store.
15		*
16		*/
17		abstract class SqlDBStore extends Store {
18
19		// There are two types of stores - for event ids and status
20		const BAT_EVENT = 'event';
21		const BAT_STATE = 'state';
22
23		/**
24		* The table that holds day data.
25		* @var
26		*/
27		public $day_table;
28
29		/**
30		* The table that holds hour data.
31		* @var
32		*/
33		public $hour_table;
34
35		/**
36		* The table that holds minute data.
37		* @var
38		*/
39		public $minute_table;
40
41		/**
42		* The event type we are dealing with.
43		* @var
44		*/
45		public $event_type;
46
47		/**
48		* SqlDBStore constructor.
49		*
50		* Provided with the event type it will determine the appropriate table names to
51		* store data in. This assumes standard behaviour from Bat_Event
52		* @param $event_type
53		* @param string $event_data
54		*/
55		public function __construct($event_type, $event_data = 'state') {
56
57		$this->event_type = $event_type;
58
59	View Code Duplication	if ($event_data == SqlDBStore::BAT_STATE) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		$this->day_table = 'bat_event_' . $event_type . '_day_' . SqlDBStore::BAT_STATE;
61		$this->hour_table = 'bat_event_' . $event_type . '_hour_' . SqlDBStore::BAT_STATE;
62		$this->minute_table = 'bat_event_' . $event_type . '_minute_' . SqlDBStore::BAT_STATE;
63		}
64
65	View Code Duplication	if ($event_data == SqlDBStore::BAT_EVENT) {
		0 ignored issues – show Duplication introduced 2016-01-05 12:01 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		$this->day_table = 'bat_event_' . $event_type . '_day_' . SqlDBStore::BAT_EVENT;
67		$this->hour_table = 'bat_event_' . $event_type . '_hour_' . SqlDBStore::BAT_EVENT;
68		$this->minute_table = 'bat_event_' . $event_type . '_minute_' . SqlDBStore::BAT_EVENT;
69		}
70
71		}
72
73		/**
74		* @param \DateTime $start_date
75		* @param \DateTime $end_date
76		* @param $unit_ids
77		*
78		* @return array
79		*/
80		public function buildQueries(\DateTime $start_date, \DateTime $end_date, $unit_ids) {
81		$queries = array();
82
83		$queries[Event::BAT_DAY] = 'SELECT * FROM ' . $this->day_table . ' WHERE ';
84		$queries[Event::BAT_HOUR] = 'SELECT * FROM ' . $this->hour_table . ' WHERE ';
85		$queries[Event::BAT_MINUTE] = 'SELECT * FROM ' . $this->minute_table . ' WHERE ';
86
87		$hours_query = TRUE;
		0 ignored issues – show Unused Code introduced 2016-01-04 14:29 UTC by Report Bug Copy Issue Report `$hours_query` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
88		$minutes_query = TRUE;
		0 ignored issues – show Unused Code introduced 2016-01-04 14:29 UTC by Report Bug Copy Issue Report `$minutes_query` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
89
90		// Create a mock event which we will use to determine how to query the database
91		$mock_event = new Event($start_date, $end_date, 0, -10);
92		// We don't need a granular event even if we are retrieving granular data - since we don't
93		// know what the event break-down is going to be we need to get the full range of data from
94		// days, hours and minutes.
95		$itemized = $mock_event->itemizeEvent(Event::BAT_DAILY);
96
97		$year_count = 0;
98		$hour_count = 0;
		0 ignored issues – show Unused Code introduced 2016-01-04 14:29 UTC by Report Bug Copy Issue Report `$hour_count` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
99		$minute_count = 0;
		0 ignored issues – show Unused Code introduced 2016-01-04 14:29 UTC by Report Bug Copy Issue Report `$minute_count` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
100
101		$query_parameters = '';
102
103		foreach($itemized[Event::BAT_DAY] as $year => $months) {
104		if ($year_count > 0) {
105		// We are dealing with multiple years so add an OR
106		$query_parameters .= ' OR ';
107		}
108		$query_parameters .= 'year IN (' . $year . ') ';
109		$query_parameters .= 'AND month IN (' . implode("," ,array_keys($months)) .') ';
110		if (count($unit_ids) > 0) {
111		// Unit ids are defined so add this as a filter
112		$query_parameters .= 'AND unit_id in (' . implode("," , $unit_ids) .') ';
113		}
114		$year_count++;
115		}
116
117		// Add parameters to each query
118		$queries[Event::BAT_DAY] .= $query_parameters;
119		$queries[Event::BAT_HOUR] .= $query_parameters;
120		$queries[Event::BAT_MINUTE] .= $query_parameters;
121
122		// Clean up and add ordering information
123		$queries[Event::BAT_DAY] .= ' ORDER BY unit_id, year, month';
124		$queries[Event::BAT_HOUR] .= ' ORDER BY unit_id, year, month, day';
125		$queries[Event::BAT_MINUTE] .= ' ORDER BY unit_id, year, month, day, hour';
126
127		return $queries;
128		}
129
130		}
131

Roomify / bat

GitHub Access Token became invalid

Push — master ( 5d93fe...e96ad3 )

SqlDBStore::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like