@@ -126,8 +126,7 @@ |
||
126 | 126 | unset($this->included_set[$unit->getUnitId()]); |
127 | 127 | $this->addMiss($unit, $reason, $constraint); |
128 | 128 | return TRUE; |
129 | - } |
|
130 | - else { |
|
129 | + } else { |
|
131 | 130 | return FALSE; |
132 | 131 | } |
133 | 132 | } |
@@ -110,8 +110,7 @@ discard block |
||
110 | 110 | for ($i = 0; $i<=59; $i++) { |
111 | 111 | if ($i <= 9) { |
112 | 112 | $index = 'm0'.$i; |
113 | - } |
|
114 | - else { |
|
113 | + } else { |
|
115 | 114 | $index = 'm'.$i; |
116 | 115 | } |
117 | 116 | $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index]; |
@@ -190,8 +189,7 @@ discard block |
||
190 | 189 | } |
191 | 190 | } |
192 | 191 | } |
193 | - } |
|
194 | - catch (\Exception $e) { |
|
192 | + } catch (\Exception $e) { |
|
195 | 193 | $saved = FALSE; |
196 | 194 | $transaction->rollback(); |
197 | 195 | watchdog_exception('BAT Event Save Exception', $e); |
@@ -70,8 +70,7 @@ discard block |
||
70 | 70 | $calendar_response->removeFromMatched($included_set[$unit_id]['unit'], CalendarResponse::CONSTRAINT, $this); |
71 | 71 | |
72 | 72 | $this->affected_units[$unit_id] = $included_set[$unit_id]['unit']; |
73 | - } |
|
74 | - elseif (is_numeric($this->max_days) && $diff > $this->max_days) { |
|
73 | + } elseif (is_numeric($this->max_days) && $diff > $this->max_days) { |
|
75 | 74 | $calendar_response->removeFromMatched($included_set[$unit_id]['unit'], CalendarResponse::CONSTRAINT, $this); |
76 | 75 | |
77 | 76 | $this->affected_units[$unit_id] = $included_set[$unit_id]['unit']; |
@@ -122,8 +121,7 @@ discard block |
||
122 | 121 | if ($day_of_the_week) { |
123 | 122 | if ($start_date && $end_date) { |
124 | 123 | $text = t('From @start_date to @end_date, if booking starts on @day_of_the_week', $args); |
125 | - } |
|
126 | - else { |
|
124 | + } else { |
|
127 | 125 | $text = t('If booking starts on @day_of_the_week', $args); |
128 | 126 | } |
129 | 127 | } |
@@ -132,8 +130,7 @@ discard block |
||
132 | 130 | if ($minimum_stay || $maximum_stay) { |
133 | 131 | if (empty($text)) { |
134 | 132 | $text = t('The stay') . ' '; |
135 | - } |
|
136 | - else { |
|
133 | + } else { |
|
137 | 134 | $text .= ' ' . t('the stay') . ' '; |
138 | 135 | } |
139 | 136 | } |
@@ -141,15 +138,12 @@ discard block |
||
141 | 138 | // Special case when min stay and max stay are the same. |
142 | 139 | if ($minimum_stay == $maximum_stay) { |
143 | 140 | $text .= t('must be for @minimum_stay', $args); |
144 | - } |
|
145 | - else { |
|
141 | + } else { |
|
146 | 142 | $text .= t('must be at least @minimum_stay and at most @maximum_stay', $args); |
147 | 143 | } |
148 | - } |
|
149 | - elseif ($minimum_stay) { |
|
144 | + } elseif ($minimum_stay) { |
|
150 | 145 | $text .= t('must be for at least @minimum_stay', $args); |
151 | - } |
|
152 | - elseif ($maximum_stay) { |
|
146 | + } elseif ($maximum_stay) { |
|
153 | 147 | $text .= t('cannot be more than @maximum_stay', $args); |
154 | 148 | } |
155 | 149 |
@@ -110,8 +110,7 @@ discard block |
||
110 | 110 | for ($i = 0; $i<=59; $i++) { |
111 | 111 | if ($i <= 9) { |
112 | 112 | $index = 'm0'.$i; |
113 | - } |
|
114 | - else { |
|
113 | + } else { |
|
115 | 114 | $index = 'm'.$i; |
116 | 115 | } |
117 | 116 | $db_events[$data['unit_id']][Event::BAT_MINUTE][$data['year']][$data['month']][$data['day']][$data['hour']][$index] = $data[$index]; |
@@ -190,8 +189,7 @@ discard block |
||
190 | 189 | } |
191 | 190 | } |
192 | 191 | } |
193 | - } |
|
194 | - catch (\Exception $e) { |
|
192 | + } catch (\Exception $e) { |
|
195 | 193 | $saved = FALSE; |
196 | 194 | $transaction->rollback(); |
197 | 195 | watchdog_exception('BAT Event Save Exception', $e); |
@@ -102,8 +102,7 @@ |
||
102 | 102 | if ($day_of_the_week) { |
103 | 103 | if ($start_date && $end_date) { |
104 | 104 | $text = 'From @start_date to @end_date, if booking starts on @day_of_the_week'; |
105 | - } |
|
106 | - else { |
|
105 | + } else { |
|
107 | 106 | $text = 'If booking starts on @day_of_the_week'; |
108 | 107 | } |
109 | 108 |
@@ -128,8 +128,7 @@ discard block |
||
128 | 128 | // Unit is in a state that is within the set of valid states so add to result set |
129 | 129 | $units[$unit] = $unit; |
130 | 130 | $response->addMatch($keyed_units[$unit], CalendarResponse::VALID_STATE); |
131 | - } |
|
132 | - else { |
|
131 | + } else { |
|
133 | 132 | $response->addMiss($keyed_units[$unit], CalendarResponse::INVALID_STATE); |
134 | 133 | } |
135 | 134 | |
@@ -223,8 +222,7 @@ discard block |
||
223 | 222 | foreach ($days as $day => $value) { |
224 | 223 | $result[$year][$month][$day] = ((int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int)$db_events[$unit][Event::BAT_DAY][$year][$month][$day]); |
225 | 224 | } |
226 | - } |
|
227 | - else { |
|
225 | + } else { |
|
228 | 226 | foreach ($days as $day => $value) { |
229 | 227 | $result[$year][$month][$day] = $keyed_units[$unit]->getDefaultValue(); |
230 | 228 | } |
@@ -254,8 +252,7 @@ discard block |
||
254 | 252 | foreach ($hours as $hour => $value) { |
255 | 253 | if (isset($db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour])) { |
256 | 254 | $result[$year][$month][$day][$hour] = ((int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_HOUR][$year][$month][$day][$hour]); |
257 | - } |
|
258 | - else { |
|
255 | + } else { |
|
259 | 256 | // If nothing from db - then revert to the defaults |
260 | 257 | $result[$year][$month][$day][$hour] = (int) $keyed_units[$unit]->getDefaultValue(); |
261 | 258 | } |
@@ -301,8 +298,7 @@ discard block |
||
301 | 298 | foreach ($minutes as $minute => $value) { |
302 | 299 | if (isset($db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute])) { |
303 | 300 | $result[$year][$month][$day][$hour][$minute] = ((int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute] == 0 ? $keyed_units[$unit]->getDefaultValue() : (int) $db_events[$unit][Event::BAT_MINUTE][$year][$month][$day][$hour][$minute]); |
304 | - } |
|
305 | - else { |
|
301 | + } else { |
|
306 | 302 | // If nothing from db - then revert to the defaults |
307 | 303 | $result[$year][$month][$day][$hour][$minute] = (int) $keyed_units[$unit]->getDefaultValue(); |
308 | 304 | } |
@@ -377,8 +373,7 @@ discard block |
||
377 | 373 | if ($current_value === $minute_value) { |
378 | 374 | // We are still in minutes and going through so add a minute |
379 | 375 | $end_event->add(new \DateInterval('PT1M')); |
380 | - } |
|
381 | - elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
376 | + } elseif (($current_value != $minute_value) && ($current_value !== NULL)) { |
|
382 | 377 | // Value just switched - let us wrap up with current event and start a new one |
383 | 378 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
384 | 379 | $start_event = clone($end_event->add(new \DateInterval('PT1M'))); |
@@ -392,12 +387,10 @@ discard block |
||
392 | 387 | } |
393 | 388 | $current_value = $minute_value; |
394 | 389 | } |
395 | - } |
|
396 | - elseif ($current_value === $hour_value) { |
|
390 | + } elseif ($current_value === $hour_value) { |
|
397 | 391 | // We are in hours and can add something |
398 | 392 | $end_event->add(new \DateInterval('PT1H')); |
399 | - } |
|
400 | - elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
393 | + } elseif (($current_value != $hour_value) && ($current_value !== NULL)) { |
|
401 | 394 | // Value just switched - let us wrap up with current event and start a new one |
402 | 395 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
403 | 396 | // Start event becomes the end event with a minute added |
@@ -414,12 +407,10 @@ discard block |
||
414 | 407 | $current_value = $hour_value; |
415 | 408 | } |
416 | 409 | } |
417 | - } |
|
418 | - elseif ($current_value === $value) { |
|
410 | + } elseif ($current_value === $value) { |
|
419 | 411 | // We are adding a whole day so the end event gets moved to the end of the day we are adding |
420 | 412 | $end_event = new \DateTime($year . '-' . $month . '-' . substr($day, 1) . ' ' . '23:59'); |
421 | - } |
|
422 | - elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
413 | + } elseif (($current_value !== $value) && ($current_value !== NULL)) { |
|
423 | 414 | // Value just switched - let us wrap up with current event and start a new one |
424 | 415 | $normalized_events[$unit_id][] = new Event($start_event, $end_event, $this->getUnit($unit_id), $current_value); |
425 | 416 | // Start event becomes the end event with a minute added |
@@ -454,8 +445,7 @@ discard block |
||
454 | 445 | if ($event->endsLater($end_date)) { |
455 | 446 | $event->setEndDate($end_date); |
456 | 447 | } |
457 | - } |
|
458 | - else { |
|
448 | + } else { |
|
459 | 449 | // Event completely not in range so unset it |
460 | 450 | unset($normalized_events[$unit_id][$key]); |
461 | 451 | } |
@@ -486,8 +476,7 @@ discard block |
||
486 | 476 | $e++; |
487 | 477 | $flipped[$e][$value][$datum] = $datum; |
488 | 478 | $old_value = $value; |
489 | - } |
|
490 | - else { |
|
479 | + } else { |
|
491 | 480 | $flipped[$e][$value][$datum] = $datum; |
492 | 481 | } |
493 | 482 | } |
@@ -90,7 +90,7 @@ discard block |
||
90 | 90 | /** |
91 | 91 | * Returns the start date. |
92 | 92 | * |
93 | - * @return DateTime |
|
93 | + * @return \DateTime |
|
94 | 94 | */ |
95 | 95 | public function getStartDate() { |
96 | 96 | return clone($this->start_date); |
@@ -107,7 +107,7 @@ discard block |
||
107 | 107 | /** |
108 | 108 | * Set the start date. |
109 | 109 | * |
110 | - * @param DateTime $start_date |
|
110 | + * @param \DateTime $start_date |
|
111 | 111 | */ |
112 | 112 | public function setStartDate(\DateTime $start_date) { |
113 | 113 | $this->start_date = clone($start_date); |
@@ -116,7 +116,7 @@ discard block |
||
116 | 116 | /** |
117 | 117 | * Returns the end date. |
118 | 118 | * |
119 | - * @return DateTime |
|
119 | + * @return \DateTime |
|
120 | 120 | */ |
121 | 121 | public function getEndDate() { |
122 | 122 | return clone($this->end_date); |
@@ -133,7 +133,7 @@ discard block |
||
133 | 133 | /** |
134 | 134 | * Set the end date. |
135 | 135 | * |
136 | - * @param DateTime $end_date |
|
136 | + * @param \DateTime $end_date |
|
137 | 137 | */ |
138 | 138 | public function setEndDate(\DateTime $end_date) { |
139 | 139 | $this->end_date = clone($end_date); |
@@ -451,6 +451,7 @@ discard block |
||
451 | 451 | /** |
452 | 452 | * Transforms the event in a breakdown of days, hours and minutes with associated states. |
453 | 453 | * |
454 | + * @param EventItemizer $itemizer |
|
454 | 455 | * @return array |
455 | 456 | */ |
456 | 457 | public function itemize($itemizer, $granularity = AbstractEvent::BAT_HOURLY) { |
@@ -461,7 +462,7 @@ discard block |
||
461 | 462 | /** |
462 | 463 | * Saves an event using the Store object |
463 | 464 | * |
464 | - * @param \Roomify\Bat\\Store\Store $store |
|
465 | + * @param Store $store |
|
465 | 466 | * @param string $granularity |
466 | 467 | * |
467 | 468 | * @return boolean |
@@ -342,8 +342,7 @@ |
||
342 | 342 | if ($this->dateIsEarlier($start) && |
343 | 343 | ($this->dateIsInRange($end) || $this->dateIsLater($end))) { |
344 | 344 | $overlaps = TRUE; |
345 | - } |
|
346 | - elseif ($this->dateIsInRange($start) && |
|
345 | + } elseif ($this->dateIsInRange($start) && |
|
347 | 346 | ($this->dateIsInRange($end) || $this->dateIsLater($end))) { |
348 | 347 | $overlaps = TRUE; |
349 | 348 | } |
@@ -147,8 +147,7 @@ discard block |
||
147 | 147 | // If we are in the same month the end date is the end date of the event |
148 | 148 | if ($this->event->isSameMonth()) { |
149 | 149 | $dayrange = new \DatePeriod($this->event->getStartDate(), $dayinterval, new \DateTime($this->event->getEndDate()->format("Y-n-j 23:59:59"))); |
150 | - } |
|
151 | - else { // alternatively it is the last day of the start month |
|
150 | + } else { // alternatively it is the last day of the start month |
|
152 | 151 | $dayrange = new \DatePeriod($this->event->getStartDate(), $dayinterval, $this->event->endMonthDate($this->event->getStartDate())); |
153 | 152 | } |
154 | 153 | foreach ($dayrange as $day) { |
@@ -214,8 +213,7 @@ discard block |
||
214 | 213 | $itemized[EventItemizer::BAT_HOUR][$sy][$sm]['d' . $sd] = $itemized_same_day[EventItemizer::BAT_HOUR][$sy][$sm]['d' . $sd]; |
215 | 214 | $itemized[EventItemizer::BAT_MINUTE][$sy][$sm]['d' . $sd] = $itemized_same_day[EventItemizer::BAT_MINUTE][$sy][$sm]['d' . $sd]; |
216 | 215 | } |
217 | - } |
|
218 | - else { |
|
216 | + } else { |
|
219 | 217 | // Deal with the start day unless it starts on midnight precisely at which point the whole day is booked |
220 | 218 | if (!($this->event->getStartDate()->format('H:i') == '00:00')) { |
221 | 219 | $start_period = new \DatePeriod($start_date, $interval, new \DateTime($start_date->format("Y-n-j 23:59:59"))); |
@@ -223,8 +221,7 @@ discard block |
||
223 | 221 | $itemized[EventItemizer::BAT_DAY][$sy][$sm]['d' . $sd] = -1; |
224 | 222 | $itemized[EventItemizer::BAT_HOUR][$sy][$sm]['d' . $sd] = $itemized_start[EventItemizer::BAT_HOUR][$sy][$sm]['d' . $sd]; |
225 | 223 | $itemized[EventItemizer::BAT_MINUTE][$sy][$sm]['d' . $sd] = $itemized_start[EventItemizer::BAT_MINUTE][$sy][$sm]['d' . $sd]; |
226 | - } |
|
227 | - else { |
|
224 | + } else { |
|
228 | 225 | // Just set an empty hour and minute |
229 | 226 | $itemized[EventItemizer::BAT_HOUR][$sy][$sm]['d' . $sd] = array(); |
230 | 227 | $itemized[EventItemizer::BAT_MINUTE][$sy][$sm]['d' . $sd] = array(); |
@@ -270,8 +267,7 @@ discard block |
||
270 | 267 | // Not a real hour - leave as is and move on |
271 | 268 | $counter = 0; |
272 | 269 | $start_minute = 0; |
273 | - } |
|
274 | - elseif ($counter == 60 && $start_minute == 0) { |
|
270 | + } elseif ($counter == 60 && $start_minute == 0) { |
|
275 | 271 | // Did a real whole hour so initialize the hour |
276 | 272 | $itemized[EventItemizer::BAT_HOUR][$minute->format('Y')][$minute->format('n')]['d' . $minute->format('j')]['h' . $minute->format('G')] = $this->event->getValue(); |
277 | 273 | // We have a whole hour so get rid of the minute info |
@@ -25,6 +25,7 @@ discard block |
||
25 | 25 | * Set the unit id. |
26 | 26 | * |
27 | 27 | * @param int $unit_id |
28 | + * @return void |
|
28 | 29 | */ |
29 | 30 | public function setUnitId($unit_id); |
30 | 31 | |
@@ -46,6 +47,7 @@ discard block |
||
46 | 47 | * Sets the StartDate |
47 | 48 | * |
48 | 49 | * @param \DateTime |
50 | + * @return void |
|
49 | 51 | */ |
50 | 52 | public function setStartDate(\DateTime $start_date); |
51 | 53 | |
@@ -53,6 +55,7 @@ discard block |
||
53 | 55 | * Sets the EndDate |
54 | 56 | * |
55 | 57 | * @param \DateTime |
58 | + * @return void |
|
56 | 59 | */ |
57 | 60 | public function setEndDate(\DateTime $end_date); |
58 | 61 | |
@@ -67,6 +70,7 @@ discard block |
||
67 | 70 | * Sets the event value. |
68 | 71 | * |
69 | 72 | * @param int $value |
73 | + * @return void |
|
70 | 74 | */ |
71 | 75 | public function setValue($value); |
72 | 76 | |
@@ -215,7 +219,7 @@ discard block |
||
215 | 219 | |
216 | 220 | /** |
217 | 221 | * Returns TRUE if the date supplied is the first month of the event |
218 | - * @param $date |
|
222 | + * @param \DateTime $date |
|
219 | 223 | * |
220 | 224 | * @return bool |
221 | 225 | */ |
@@ -231,7 +235,7 @@ discard block |
||
231 | 235 | |
232 | 236 | /** |
233 | 237 | * Returns TRUE if the date supplied is the last month of the event |
234 | - * @param $date |
|
238 | + * @param \DateTime $date |
|
235 | 239 | * |
236 | 240 | * @return bool |
237 | 241 | */ |
@@ -283,7 +287,6 @@ discard block |
||
283 | 287 | /** |
284 | 288 | * Returns the json version of this event. |
285 | 289 | * |
286 | - * @param \Roomify\Bat\Event\EventInterface $event |
|
287 | 290 | * |
288 | 291 | * @return mixed |
289 | 292 | */ |