ConstraintManager - Code Metrics - Roomify/bat - Measure and Improve Code Quality continuously with Scrutinizer

ConstraintManager C
last analyzed 2020-08-25 16:09 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	233
Duplicated Lines	29.61 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	55
lcom	1
cbo	2
dl	69
loc	233
rs	6
c	0
b	0
f	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	getConstraints()	0	7	2
A	addConstraints()	0	5	2
A	setConstraints()	0	4	1
B	normalizeConstraints()	0	36	8
D	normalizeMinMaxDaysConstraints()	35	72	21
D	normalizeCheckInDayConstraints()	34	68	19

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like ConstraintManager often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use ConstraintManager, and based on these observations, apply Extract Interface, too.

<?php

/**
 * @file
 * Class ConstraintManager
 */

namespace Roomify\Bat\Constraint;

class ConstraintManager {

  protected $constraints;

  /**
   * @param $constraints
   */
  public function __construct($constraints = array()) {
    $this->constraints = array();
    foreach ($constraints as $constraint) {
      $this->constraints[get_class($constraint)][] = $constraint;
    }
  }

  /**
   * @return array
   */
  public function getConstraints($constraint_class = NULL) {
    if ($constraint_class == NULL) {
      return $this->constraints;
    } else {
      return $this->constraints[$constraint_class];
    }
  }

  /**
   * @param $constraints
   */
  public function addConstraints($constraints) {
    foreach ($constraints as $constraint) {
      $this->constraints[get_class($constraint)][] = $constraint;
    }
  }

  /**
   * @param $constraints
   */
  public function setConstraints($constraints) {
    $this->constraints = array();
    $this->addConstraints($constraints);
  }

  /**
   * @param $constraint_class
   *
   * @return array
   */
  public function normalizeConstraints($constraint_class = NULL) {
    if ($constraint_class == NULL) {
      $classes = array_keys($this->constraints);
    } else {
      if (isset($this->constraints[$constraint_class])) {
        $classes = array($constraint_class);
      } else {
        return array();
      }
    }

    $new_constraints = array();

    foreach ($classes as $class) {
      switch ($class) {
        case 'Roomify\Bat\Constraint\MinMaxDaysConstraint':
          $new_constraints[$class] = $this->normalizeMinMaxDaysConstraints();
          break;

        case 'Roomify\Bat\Constraint\CheckInDayConstraint':
          $new_constraints[$class] = $this->normalizeCheckInDayConstraints();
          break;

        default:
          if (isset($this->constraints[$class])) {
            $new_constraints[$class] = $this->constraints[$class];
          }
      }
    }

    if ($constraint_class == NULL) {
      return $new_constraints;
    } else {
      return $new_constraints[$constraint_class];
    }
  }

  /**
   * @return array
   */
  protected function normalizeMinMaxDaysConstraints() {
    $new_constraints = array();

    $constraints = array_map(function ($object) { return clone $object; }, $this->constraints['Roomify\Bat\Constraint\MinMaxDaysConstraint']);

    foreach (array_reverse($constraints) as $constraint) {
      $start_date = $constraint->getStartDate();
      $end_date = $constraint->getEndDate();

      $split_constraint = NULL;

      if (!empty($new_constraints)) {
        foreach ($new_constraints as $new_constraint) {
          $new_start_date = $new_constraint->getStartDate();
          $new_end_date = $new_constraint->getEndDate();

          if ($constraint->getMinDays() && $new_constraint->getMinDays() ||
              ($constraint->getMaxDays() && $new_constraint->getMaxDays())) {
            if ($start_date >= $new_start_date && $start_date <= $new_end_date) {

              $new_end_date_clone = clone($new_end_date);
              $constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
            }
            elseif ($end_date >= $new_start_date && $end_date <= $new_end_date) {
              $new_start_date_clone = clone($new_start_date);
              $constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
            }
            elseif ($start_date < $new_start_date && $end_date > $new_end_date) {
              if ($constraint->getEndDate() > $new_start_date) {
                $new_start_date_clone = clone($new_start_date);
                $constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
              }

              if ($split_constraint == NULL) {
                $split_start_date = clone($new_end_date);
                $split_start_date->add(new \DateInterval('P1D'));
                $split_end_date = $end_date;

                $split_constraint = new MinMaxDaysConstraint($constraint->getUnits(), $constraint->getMinDays(), $constraint->getMaxDays(), $split_start_date, $split_end_date, $constraint->getCheckinDay());
              }
              else {
                $split_start_date = $split_constraint->getStartDate();
                $split_end_date = $split_constraint->getEndDate();

                if ($split_start_date < $new_end_date) {
                  $new_end_date_clone = clone($new_end_date);
                  $split_constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
                }
                if ($split_end_date < $new_start_date) {
                  $new_start_date_clone = clone($new_start_date);
                  $split_constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
                }
              }
            }
          }
        }

        if ($split_constraint != NULL) {
          $new_constraints[] = $split_constraint;
        }
      }

      $new_constraints[] = $constraint;
    }

    foreach ($new_constraints as $i => $constraint) {
      if ($constraint->getStartDate() > $constraint->getEndDate()) {
        unset($new_constraints[$i]);
      }
    }

    return $new_constraints;
  }

  /**
   * @return array
   */
  protected function normalizeCheckInDayConstraints() {
    $new_constraints = array();

    $constraints = array_map(function ($object) { return clone $object; }, $this->constraints['Roomify\Bat\Constraint\CheckInDayConstraint']);

    foreach (array_reverse($constraints) as $constraint) {
      $start_date = $constraint->getStartDate();
      $end_date = $constraint->getEndDate();

      $split_constraint = NULL;

      if (!empty($new_constraints)) {
        foreach ($new_constraints as $new_constraint) {
          $new_start_date = $new_constraint->getStartDate();
          $new_end_date = $new_constraint->getEndDate();

          if ($constraint->getCheckinDay() && $new_constraint->getCheckinDay()) {

            if ($start_date >= $new_start_date && $start_date <= $new_end_date) {
              $new_end_date_clone = clone($new_end_date);
              $constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
            } elseif ($end_date >= $new_start_date && $end_date <= $new_end_date) {
              $new_start_date_clone = clone($new_start_date);
              $constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
            } elseif ($start_date < $new_start_date && $end_date > $new_end_date) {
              if ($constraint->getEndDate() > $new_start_date) {
                $new_start_date_clone = clone($new_start_date);
                $constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
              }

              if ($split_constraint == NULL) {
                $split_start_date = clone($new_end_date);
                $split_start_date->add(new \DateInterval('P1D'));
                $split_end_date = $end_date;

                $split_constraint = new CheckInDayConstraint($constraint->getUnits(), $constraint->getCheckinDay(), $split_start_date, $split_end_date);
              } else {
                $split_start_date = $split_constraint->getStartDate();
                $split_end_date = $split_constraint->getEndDate();

                if ($split_start_date < $new_end_date) {
                  $new_end_date_clone = clone($new_end_date);
                  $split_constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
                }
                if ($split_end_date < $new_start_date) {
                  $new_start_date_clone = clone($new_start_date);
                  $split_constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
                }
              }
            }
          }
        }

        if ($split_constraint != NULL) {
          $new_constraints[] = $split_constraint;
        }
      }

      $new_constraints[] = $constraint;
    }

    foreach ($new_constraints as $i => $constraint) {
      if ($constraint->getStartDate() > $constraint->getEndDate()) {
        unset($new_constraints[$i]);
      }
    }

    return $new_constraints;
  }
  
}


1		<?php
2
3		/**
4		* @file
5		* Class ConstraintManager
6		*/
7
8		namespace Roomify\Bat\Constraint;
9
10		class ConstraintManager {
11
12		protected $constraints;
13
14		/**
15		* @param $constraints
16		*/
17		public function __construct($constraints = array()) {
18		$this->constraints = array();
19		foreach ($constraints as $constraint) {
20		$this->constraints[get_class($constraint)][] = $constraint;
21		}
22		}
23
24		/**
25		* @return array
26		*/
27		public function getConstraints($constraint_class = NULL) {
28		if ($constraint_class == NULL) {
29		return $this->constraints;
30		} else {
31		return $this->constraints[$constraint_class];
32		}
33		}
34
35		/**
36		* @param $constraints
37		*/
38		public function addConstraints($constraints) {
39		foreach ($constraints as $constraint) {
40		$this->constraints[get_class($constraint)][] = $constraint;
41		}
42		}
43
44		/**
45		* @param $constraints
46		*/
47		public function setConstraints($constraints) {
48		$this->constraints = array();
49		$this->addConstraints($constraints);
50		}
51
52		/**
53		* @param $constraint_class
54		*
55		* @return array
56		*/
57		public function normalizeConstraints($constraint_class = NULL) {
58		if ($constraint_class == NULL) {
59		$classes = array_keys($this->constraints);
60		} else {
61		if (isset($this->constraints[$constraint_class])) {
62		$classes = array($constraint_class);
63		} else {
64		return array();
65		}
66		}
67
68		$new_constraints = array();
69
70		foreach ($classes as $class) {
71		switch ($class) {
72		case 'Roomify\Bat\Constraint\MinMaxDaysConstraint':
73		$new_constraints[$class] = $this->normalizeMinMaxDaysConstraints();
74		break;
75
76		case 'Roomify\Bat\Constraint\CheckInDayConstraint':
77		$new_constraints[$class] = $this->normalizeCheckInDayConstraints();
78		break;
79
80		default:
81		if (isset($this->constraints[$class])) {
82		$new_constraints[$class] = $this->constraints[$class];
83		}
84		}
85		}
86
87		if ($constraint_class == NULL) {
88		return $new_constraints;
89		} else {
90		return $new_constraints[$constraint_class];
91		}
92		}
93
94		/**
95		* @return array
96		*/
97		protected function normalizeMinMaxDaysConstraints() {
98		$new_constraints = array();
99
100		$constraints = array_map(function ($object) { return clone $object; }, $this->constraints['Roomify\Bat\Constraint\MinMaxDaysConstraint']);
101
102		foreach (array_reverse($constraints) as $constraint) {
103		$start_date = $constraint->getStartDate();
104		$end_date = $constraint->getEndDate();
105
106		$split_constraint = NULL;
107
108		if (!empty($new_constraints)) {
109		foreach ($new_constraints as $new_constraint) {
110		$new_start_date = $new_constraint->getStartDate();
111		$new_end_date = $new_constraint->getEndDate();
112
113		if ($constraint->getMinDays() && $new_constraint->getMinDays() \|\|
114		($constraint->getMaxDays() && $new_constraint->getMaxDays())) {
115	View Code Duplication	if ($start_date >= $new_start_date && $start_date <= $new_end_date) {
		0 ignored issues – show Duplication introduced 2016-08-30 13:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
116		$new_end_date_clone = clone($new_end_date);
117		$constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
118		}
119		elseif ($end_date >= $new_start_date && $end_date <= $new_end_date) {
120		$new_start_date_clone = clone($new_start_date);
121		$constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
122		}
123		elseif ($start_date < $new_start_date && $end_date > $new_end_date) {
124		if ($constraint->getEndDate() > $new_start_date) {
125		$new_start_date_clone = clone($new_start_date);
126		$constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
127		}
128
129		if ($split_constraint == NULL) {
130		$split_start_date = clone($new_end_date);
131		$split_start_date->add(new \DateInterval('P1D'));
132		$split_end_date = $end_date;
133
134		$split_constraint = new MinMaxDaysConstraint($constraint->getUnits(), $constraint->getMinDays(), $constraint->getMaxDays(), $split_start_date, $split_end_date, $constraint->getCheckinDay());
135		}
136		else {
137		$split_start_date = $split_constraint->getStartDate();
138		$split_end_date = $split_constraint->getEndDate();
139
140		if ($split_start_date < $new_end_date) {
141		$new_end_date_clone = clone($new_end_date);
142		$split_constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
143		}
144		if ($split_end_date < $new_start_date) {
145		$new_start_date_clone = clone($new_start_date);
146		$split_constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
147		}
148		}
149		}
150		}
151		}
152
153		if ($split_constraint != NULL) {
154		$new_constraints[] = $split_constraint;
155		}
156		}
157
158		$new_constraints[] = $constraint;
159		}
160
161		foreach ($new_constraints as $i => $constraint) {
162		if ($constraint->getStartDate() > $constraint->getEndDate()) {
163		unset($new_constraints[$i]);
164		}
165		}
166
167		return $new_constraints;
168		}
169
170		/**
171		* @return array
172		*/
173		protected function normalizeCheckInDayConstraints() {
174		$new_constraints = array();
175
176		$constraints = array_map(function ($object) { return clone $object; }, $this->constraints['Roomify\Bat\Constraint\CheckInDayConstraint']);
177
178		foreach (array_reverse($constraints) as $constraint) {
179		$start_date = $constraint->getStartDate();
180		$end_date = $constraint->getEndDate();
181
182		$split_constraint = NULL;
183
184		if (!empty($new_constraints)) {
185		foreach ($new_constraints as $new_constraint) {
186		$new_start_date = $new_constraint->getStartDate();
187		$new_end_date = $new_constraint->getEndDate();
188
189	View Code Duplication	if ($constraint->getCheckinDay() && $new_constraint->getCheckinDay()) {
		0 ignored issues – show Duplication introduced 2016-08-30 13:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
190		if ($start_date >= $new_start_date && $start_date <= $new_end_date) {
191		$new_end_date_clone = clone($new_end_date);
192		$constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
193		} elseif ($end_date >= $new_start_date && $end_date <= $new_end_date) {
194		$new_start_date_clone = clone($new_start_date);
195		$constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
196		} elseif ($start_date < $new_start_date && $end_date > $new_end_date) {
197		if ($constraint->getEndDate() > $new_start_date) {
198		$new_start_date_clone = clone($new_start_date);
199		$constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
200		}
201
202		if ($split_constraint == NULL) {
203		$split_start_date = clone($new_end_date);
204		$split_start_date->add(new \DateInterval('P1D'));
205		$split_end_date = $end_date;
206
207		$split_constraint = new CheckInDayConstraint($constraint->getUnits(), $constraint->getCheckinDay(), $split_start_date, $split_end_date);
208		} else {
209		$split_start_date = $split_constraint->getStartDate();
210		$split_end_date = $split_constraint->getEndDate();
211
212		if ($split_start_date < $new_end_date) {
213		$new_end_date_clone = clone($new_end_date);
214		$split_constraint->setStartDate($new_end_date_clone->add(new \DateInterval('P1D')));
215		}
216		if ($split_end_date < $new_start_date) {
217		$new_start_date_clone = clone($new_start_date);
218		$split_constraint->setEndDate($new_start_date_clone->sub(new \DateInterval('P1D')));
219		}
220		}
221		}
222		}
223		}
224
225		if ($split_constraint != NULL) {
226		$new_constraints[] = $split_constraint;
227		}
228		}
229
230		$new_constraints[] = $constraint;
231		}
232
233		foreach ($new_constraints as $i => $constraint) {
234		if ($constraint->getStartDate() > $constraint->getEndDate()) {
235		unset($new_constraints[$i]);
236		}
237		}
238
239		return $new_constraints;
240		}
241
242		}
243

Roomify / bat

GitHub Access Token became invalid

ConstraintManager C last analyzed 2020-08-25 16:09 UTC