Rodenastyle\StreamParser\Services\JsonCollectionParser::parse()

Complexity

Conditions	3
Paths	5

Size

Total Lines	22
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	3.1707

Importance

Changes	1
Bugs	0	Features	0

<?php
	public function parse($filePath, $itemCallback, bool $assoc = true): void
	{
		$this->checkCallback($itemCallback);

		$stream = $this->openFile($filePath);

		try {
			$listener = new Listener($itemCallback, $assoc);
			$this->parser = new StreamingParser(
				$stream,
				$listener,
				$this->getOption('line_ending'),

It seems like $this->getOption('line_ending') can also be of type null; however, parameter $lineEnding of JsonStreamingParser\Parser::__construct() does only seem to accept string, maybe add an additional type check?

				$this->getOption('emit_whitespace')

It seems like $this->getOption('emit_whitespace') can also be of type null; however, parameter $emitWhitespace of JsonStreamingParser\Parser::__construct() does only seem to accept boolean, maybe add an additional type check?

			);
			$this->parser->parse();
		} catch (\Exception $e) {
			fclose($stream);
			throw $e;
		}

		if( ! fclose($stream)){
			throw new IncompleteParseException();
		}