OverviewFormatCommand::getExpectedResponseCodes() - Code Metrics - Inspection of "Return the result instead of the command." - RobinvdVleuten/php-nntp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/improved-response-hand... ( d991be )

by Robin

created 2016-12-02 20:31 UTC

OverviewFormatCommand::getExpectedResponseCodes() A

↳ Parent: OverviewFormatCommand::onInformationFollows()

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
cc	1
eloc	3
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the NNTP library.
 *
 * (c) Robin van der Vleuten <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Rvdv\Nntp\Command;

use Rvdv\Nntp\Response\MultiLineResponse;
use Rvdv\Nntp\Response\Response;

/**
 * OverviewFormatCommand.
 *
 * @author Robin van der Vleuten <[email protected]>
 */
class OverviewFormatCommand extends Command implements CommandInterface
{
    public function __construct()
    {
        parent::__construct([], true);
    }

    /**
     * {@inheritdoc}
     */
    public function __invoke()
    {
        return 'LIST OVERVIEW.FMT';
    }

    public function onInformationFollows(MultiLineResponse $response)
    {
        $result = [];

        foreach ($response->getLines() as $line) {
            if (0 == strcasecmp(substr($line, -5, 5), ':full')) {
                // ':full' is _not_ included in tag, but value set to true
                $result[str_replace('-', '_', strtolower(substr($line, 0, -5)))] = true;
            } else {
                // ':' is _not_ included in tag; value set to false
                $result[str_replace('-', '_', strtolower(substr($line, 0, -1)))] = false;
            }
        }

        return $result;
    }
}


1		<?php
2
3		/*
4		* This file is part of the NNTP library.
5		*
6		* (c) Robin van der Vleuten <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Rvdv\Nntp\Command;
13
14		use Rvdv\Nntp\Response\MultiLineResponse;
15		use Rvdv\Nntp\Response\Response;
16
17		/**
18		* OverviewFormatCommand.
19		*
20		* @author Robin van der Vleuten <[email protected]>
21		*/
22		class OverviewFormatCommand extends Command implements CommandInterface
23		{
24	6	public function __construct()
25		{
26	6	parent::__construct([], true);
27	6	}
28
29		/**
30		* {@inheritdoc}
31		*/
32	1	public function __invoke()
33		{
34	1	return 'LIST OVERVIEW.FMT';
35		}
36
37	1	public function onInformationFollows(MultiLineResponse $response)
38		{
39	1	$result = [];
40
41	1	foreach ($response->getLines() as $line) {
42	1	if (0 == strcasecmp(substr($line, -5, 5), ':full')) {
43		// ':full' is _not_ included in tag, but value set to true
44	1	$result[str_replace('-', '_', strtolower(substr($line, 0, -5)))] = true;
45	1	} else {
46		// ':' is _not_ included in tag; value set to false
47	1	$result[str_replace('-', '_', strtolower(substr($line, 0, -1)))] = false;
48		}
49	1	}
50
51	1	return $result;
52		}
53		}
54

RobinvdVleuten / php-nntp

Push — feature/improved-response-hand... ( d991be )

OverviewFormatCommand::getExpectedResponseCodes() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like