Completed
Pull Request — master (#1)
by Marco
02:12
created
RoaveTest/ComposerGpgVerify/Exception/PreferredInstallIsNotSourceTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ComposerGpgVerify\Exception;
6 6
 
Please login to merge, or discard this patch.
src/Roave/ComposerGpgVerify/Verify.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Roave\ComposerGpgVerify;
6 6
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
         $installationManager = $composer->getInstallationManager();
67 67
         /* @var $checkedPackages PackageVerification[] */
68 68
         $checkedPackages     = array_map(
69
-            function (PackageInterface $package) use ($installationManager) : PackageVerification {
69
+            function(PackageInterface $package) use ($installationManager) : PackageVerification {
70 70
                 return self::verifyPackage($installationManager, $package);
71 71
             },
72 72
             $composer->getRepositoryManager()->getLocalRepository()->getPackages()
@@ -76,12 +76,12 @@  discard block
 block discarded – undo
76 76
 
77 77
         $escapes = array_filter(
78 78
             $checkedPackages,
79
-            function (PackageVerification $verification) : bool {
80
-                return ! $verification->isVerified();
79
+            function(PackageVerification $verification) : bool {
80
+                return !$verification->isVerified();
81 81
             }
82 82
         );
83 83
 
84
-        if (! $escapes) {
84
+        if (!$escapes) {
85 85
             $io->write('<info>roave/composer-gpg-verify:</info>  All installed packages passed GPG validation!');
86 86
 
87 87
             return;
@@ -94,9 +94,9 @@  discard block
 block discarded – undo
94 94
         InstallationManager $installationManager,
95 95
         PackageInterface $package
96 96
     ) : PackageVerification {
97
-        $gitDirectory = $installationManager->getInstallPath($package) . '/.git';
97
+        $gitDirectory = $installationManager->getInstallPath($package).'/.git';
98 98
 
99
-        if (! is_dir($gitDirectory)) {
99
+        if (!is_dir($gitDirectory)) {
100 100
             return UnknownPackageFormat::fromNonGitPackage($package);
101 101
         }
102 102
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
     private static function checkTagSignatures(string $gitDirectory, PackageInterface $package, string ...$tags) : array
151 151
     {
152 152
         return array_map(
153
-            function (string $tag) use ($gitDirectory, $package) : GitSignatureCheck {
153
+            function(string $tag) use ($gitDirectory, $package) : GitSignatureCheck {
154 154
                 $command = sprintf(
155 155
                     'git --git-dir %s tag -v %s 2>&1',
156 156
                     escapeshellarg($gitDirectory),
Please login to merge, or discard this patch.
test/RoaveTest/ComposerGpgVerify/VerifyTest.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ComposerGpgVerify;
6 6
 
@@ -112,14 +112,14 @@  discard block
 block discarded – undo
112 112
             ->installationManager
113 113
             ->expects(self::any())
114 114
             ->method('getInstallPath')
115
-            ->willReturnCallback(function (PackageInterface $package) : string {
115
+            ->willReturnCallback(function(PackageInterface $package) : string {
116 116
                 return array_search($package, $this->installedPackages, true);
117 117
             });
118 118
         $this
119 119
             ->localRepository
120 120
             ->expects(self::any())
121 121
             ->method('getPackages')
122
-            ->willReturnCallback(function () {
122
+            ->willReturnCallback(function() {
123 123
                 return array_values($this->installedPackages);
124 124
             });
125 125
     }
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 
176 176
         $this->configureCorrectComposerSetup();
177 177
 
178
-        putenv('GNUPGHOME=' . $gpgHomeDirectory);
178
+        putenv('GNUPGHOME='.$gpgHomeDirectory);
179 179
 
180 180
         $this->assertWillSucceedPackageVerification();
181 181
     }
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 
200 200
         $this->configureCorrectComposerSetup();
201 201
 
202
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
202
+        putenv('GNUPGHOME='.$personalGpgDirectory);
203 203
 
204 204
         $this->assertWillFailPackageVerification();
205 205
     }
@@ -224,7 +224,7 @@  discard block
 block discarded – undo
224 224
 
225 225
         $this->configureCorrectComposerSetup();
226 226
 
227
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
227
+        putenv('GNUPGHOME='.$personalGpgDirectory);
228 228
         putenv('LANGUAGE=de_DE');
229 229
 
230 230
         try {
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
 
258 258
         $this->configureCorrectComposerSetup();
259 259
 
260
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
260
+        putenv('GNUPGHOME='.$personalGpgDirectory);
261 261
 
262 262
         $this->assertWillSucceedPackageVerification();
263 263
     }
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 
282 282
         $this->configureCorrectComposerSetup();
283 283
 
284
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
284
+        putenv('GNUPGHOME='.$personalGpgDirectory);
285 285
 
286 286
         $this->assertWillFailPackageVerification();
287 287
     }
@@ -305,7 +305,7 @@  discard block
 block discarded – undo
305 305
 
306 306
         $this->configureCorrectComposerSetup();
307 307
 
308
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
308
+        putenv('GNUPGHOME='.$personalGpgDirectory);
309 309
 
310 310
         $this->assertWillSucceedPackageVerification();
311 311
     }
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
 
325 325
         $this->configureCorrectComposerSetup();
326 326
 
327
-        putenv('GNUPGHOME=' . $gpgHomeDirectory);
327
+        putenv('GNUPGHOME='.$gpgHomeDirectory);
328 328
 
329 329
         $this->assertWillSucceedPackageVerification();
330 330
     }
@@ -342,7 +342,7 @@  discard block
 block discarded – undo
342 342
 
343 343
         $this->configureCorrectComposerSetup();
344 344
 
345
-        putenv('GNUPGHOME=' . $this->makeGpgHomeDirectory());
345
+        putenv('GNUPGHOME='.$this->makeGpgHomeDirectory());
346 346
 
347 347
         $this->assertWillFailPackageVerification();
348 348
     }
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
 
365 365
         $this->configureCorrectComposerSetup();
366 366
 
367
-        putenv('GNUPGHOME=' . $this->makeGpgHomeDirectory());
367
+        putenv('GNUPGHOME='.$this->makeGpgHomeDirectory());
368 368
 
369 369
         $this->assertWillFailPackageVerification();
370 370
     }
@@ -383,7 +383,7 @@  discard block
 block discarded – undo
383 383
 
384 384
         $this->configureCorrectComposerSetup();
385 385
 
386
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
386
+        putenv('GNUPGHOME='.$personalGpgDirectory);
387 387
 
388 388
         $this->assertWillFailPackageVerification();
389 389
     }
@@ -405,7 +405,7 @@  discard block
 block discarded – undo
405 405
 
406 406
         $this->configureCorrectComposerSetup();
407 407
 
408
-        putenv('GNUPGHOME=' . $gpgHome);
408
+        putenv('GNUPGHOME='.$gpgHome);
409 409
 
410 410
         $this->assertWillFailPackageVerification();
411 411
     }
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 
428 428
         $this->configureCorrectComposerSetup();
429 429
 
430
-        putenv('GNUPGHOME=' . $gpgHome);
430
+        putenv('GNUPGHOME='.$gpgHome);
431 431
 
432 432
         $this->assertWillFailPackageVerification();
433 433
     }
@@ -447,14 +447,14 @@  discard block
 block discarded – undo
447 447
 
448 448
         $this->configureCorrectComposerSetup();
449 449
 
450
-        putenv('GNUPGHOME=' . $personalGpgDirectory);
450
+        putenv('GNUPGHOME='.$personalGpgDirectory);
451 451
 
452 452
         $this->assertWillFailPackageVerification();
453 453
     }
454 454
 
455 455
     private function makeVendorDirectory() : string
456 456
     {
457
-        $vendorDirectory = sys_get_temp_dir() . '/' . uniqid('vendor', true);
457
+        $vendorDirectory = sys_get_temp_dir().'/'.uniqid('vendor', true);
458 458
 
459 459
         self::assertTrue(mkdir($vendorDirectory));
460 460
 
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
         string $email,
508 508
         string $name
509 509
     ) : string {
510
-        $dependencyRepository = $vendorDirectory . '/' . $packageName;
510
+        $dependencyRepository = $vendorDirectory.'/'.$packageName;
511 511
 
512 512
         self::assertTrue(mkdir($dependencyRepository, 0777, true));
513 513
 
@@ -535,7 +535,7 @@  discard block
 block discarded – undo
535 535
 
536 536
     private function makeGpgHomeDirectory() : string
537 537
     {
538
-        $homeDirectory = sys_get_temp_dir() . '/' . uniqid('gpg-verification-test', true);
538
+        $homeDirectory = sys_get_temp_dir().'/'.uniqid('gpg-verification-test', true);
539 539
 
540 540
         self::assertTrue(mkdir($homeDirectory, 0700));
541 541
 
@@ -560,7 +560,7 @@  discard block
 block discarded – undo
560 560
         self::assertGreaterThan(
561 561
             0,
562 562
             file_put_contents(
563
-                $gpgHomeDirectory . '/key-info.txt',
563
+                $gpgHomeDirectory.'/key-info.txt',
564 564
                 str_replace(['<<<NAME>>>', '<<<EMAIL>>>'], [$name, $emailAddress], $input)
565 565
             )
566 566
         );
@@ -624,7 +624,7 @@  discard block
 block discarded – undo
624 624
         string $foreignKey,
625 625
         bool $sign
626 626
     ) : void {
627
-        $exportPath = sys_get_temp_dir() . '/' . uniqid('exportedKey', true);
627
+        $exportPath = sys_get_temp_dir().'/'.uniqid('exportedKey', true);
628 628
 
629 629
         (new Process(
630 630
             sprintf('gpg --export --armor > %s', escapeshellarg($exportPath)),
@@ -644,7 +644,7 @@  discard block
 block discarded – undo
644 644
             ->setTimeout(30)
645 645
             ->mustRun();
646 646
 
647
-        if (! $sign) {
647
+        if (!$sign) {
648 648
             return;
649 649
         }
650 650
 
Please login to merge, or discard this patch.