Roave\DoctrineSimpleCache\SimpleCacheAdapter

Complexity

Total Complexity

25

Size/Duplication

Total Lines	165
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	14	4
A	validateKey()	0	14	4
A	filterValidateMultipleKeys()	0	14	3
A	get()	0	11	2
A	set()	0	5	1
A	delete()	0	5	1
A	clear()	0	4	1
A	getMultiple()	0	5	1
A	setMultiple()	0	12	4
A	deleteMultiple()	0	13	3
A	has()	0	5	1

<?php
declare(strict_types = 1);

namespace Roave\DoctrineSimpleCache;

use Doctrine\Common\Cache\Cache as DoctrineCache;
use Doctrine\Common\Cache\ClearableCache;
use Doctrine\Common\Cache\MultiGetCache;
use Doctrine\Common\Cache\MultiPutCache;
use Psr\SimpleCache\CacheInterface as PsrCache;

final class SimpleCacheAdapter implements PsrCache
{
    /**
     * @var DoctrineCache|ClearableCache|MultiGetCache|MultiPutCache
     */
    private $doctrineCache;

    /**
     * @param DoctrineCache $doctrineCache
     * @throws \Roave\DoctrineSimpleCache\CacheException
     */
    public function __construct(DoctrineCache $doctrineCache)
    {
        $this->doctrineCache = $doctrineCache;

        if (!$this->doctrineCache instanceof ClearableCache) {
            throw CacheException::fromNonClearableCache($this->doctrineCache);
        }
        if (!$this->doctrineCache instanceof MultiGetCache) {
            throw CacheException::fromNonMultiGetCache($this->doctrineCache);
        }
        if (!$this->doctrineCache instanceof MultiPutCache) {
            throw CacheException::fromNonMultiPutCache($this->doctrineCache);
        }
    }

    /**
     * @param mixed $key
     * @throws \Roave\DoctrineSimpleCache\Exception\InvalidArgumentException
     */
    private function validateKey($key) : void
    {
        if (!is_string($key)) {
            throw Exception\InvalidArgumentException::fromInvalidType($key);
        }

        if ('' === $key) {
            throw Exception\InvalidArgumentException::fromEmptyKey();
        }

        if (preg_match('/[' . preg_quote('{}()/\@:', '/') . ']/', $key)) {
            throw Exception\InvalidArgumentException::fromInvalidKeyCharacters($key);
        }
    }

    /**
     * @param mixed $keys
     * @return array
     * @throws \Roave\DoctrineSimpleCache\Exception\InvalidArgumentException
     */
    private function filterValidateMultipleKeys($keys) : array
    {
        if ($keys instanceof \Traversable) {
            $keys = iterator_to_array($keys);
        }

        if (!is_array($keys)) {
            throw Exception\InvalidArgumentException::fromNonIterableKeys($keys);
        }

        array_map([$this, 'validateKey'], $keys);

        return $keys;
    }

    /**
     * {@inheritDoc}
     */
    public function get($key, $default = null)
    {
        $this->validateKey($key);

        $value = $this->doctrineCache->fetch($key);

The method fetch does only exist in Doctrine\Common\Cache\Cache, but not in Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiGetCache and Doctrine\Common\Cache\MultiPutCache.

        if ($value === false) {
            return $default;
        }

        return $value;
    }

    /**
     * {@inheritDoc}
     */
    public function set($key, $value, $ttl = null) : bool
    {
        $this->validateKey($key);
        return $this->doctrineCache->save($key, $value, $ttl);

It seems like $ttl defined by parameter $ttl on line 95 can also be of type null; however, Doctrine\Common\Cache\Cache::save() does only seem to accept integer, maybe add an additional type check?

The method save does only exist in Doctrine\Common\Cache\Cache, but not in Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiGetCache and Doctrine\Common\Cache\MultiPutCache.

    }

    /**
     * {@inheritDoc}
     */
    public function delete($key) : bool
    {
        $this->validateKey($key);
        return $this->doctrineCache->delete($key);

The method delete does only exist in Doctrine\Common\Cache\Cache, but not in Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiGetCache and Doctrine\Common\Cache\MultiPutCache.

    }

    /**
     * {@inheritDoc}
     */
    public function clear() : bool
    {
        return $this->doctrineCache->deleteAll();

The method deleteAll does only exist in Doctrine\Common\Cache\ClearableCache, but not in Doctrine\Common\Cache\Cache and Doctrine\Common\Cache\MultiGetCache and Doctrine\Common\Cache\MultiPutCache.

    }

    /**
     * @param array|\Traversable $keys
     * @param mixed $default
     * @return array
     * @throws \Roave\DoctrineSimpleCache\Exception\InvalidArgumentException
     */
    public function getMultiple($keys, $default = null)
    {
        $keys = $this->filterValidateMultipleKeys($keys);
        return array_merge(array_fill_keys($keys, $default), $this->doctrineCache->fetchMultiple($keys));

The method fetchMultiple does only exist in Doctrine\Common\Cache\MultiGetCache, but not in Doctrine\Common\Cache\Cache and Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiPutCache.

The return type of return array_merge(array_fill_keys($keys, $default), $this->doctrineCache->fetchMultiple($keys)); (array) is incompatible with the return type declared by the interface Psr\SimpleCache\CacheInterface::getMultiple of type Psr\SimpleCache\iterable.

    }

    /**
     * @param array|\Traversable $values
     * @param null|int|\DateInterval $ttl
     * @return bool
     * @throws \Roave\DoctrineSimpleCache\Exception\InvalidArgumentException
     */
    public function setMultiple($values, $ttl = null) : bool
    {
        if (!$values instanceof \Traversable && !is_array($values)) {
            throw Exception\InvalidArgumentException::fromNonIterableKeys($values);
        }

        foreach ($values as $k => $v) {
            $this->validateKey($k);
        }

        return $this->doctrineCache->saveMultiple($values, $ttl);

The method saveMultiple does only exist in Doctrine\Common\Cache\MultiPutCache, but not in Doctrine\Common\Cache\Cache and Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiGetCache.

It seems like $values defined by parameter $values on line 136 can also be of type object<Traversable>; however, Doctrine\Common\Cache\MultiPutCache::saveMultiple() does only seem to accept array, maybe add an additional type check?

It seems like $ttl defined by parameter $ttl on line 136 can also be of type null or object<DateInterval>; however, Doctrine\Common\Cache\MultiPutCache::saveMultiple() does only seem to accept integer, maybe add an additional type check?

    }

    /**
     * @param array|\Traversable $keys
     * @return bool
     * @throws \Roave\DoctrineSimpleCache\Exception\InvalidArgumentException
     */
    public function deleteMultiple($keys) : bool
    {
        $keys = $this->filterValidateMultipleKeys($keys);

        $success = true;
        foreach ($keys as $key) {
            if (!$this->delete($key)) {
                $success = false;
            }
        }

        return $success;
    }

    /**
     * {@inheritDoc}
     */
    public function has($key) : bool
    {
        $this->validateKey($key);
        return $this->doctrineCache->contains($key);

The method contains does only exist in Doctrine\Common\Cache\Cache, but not in Doctrine\Common\Cache\ClearableCache and Doctrine\Common\Cache\MultiGetCache and Doctrine\Common\Cache\MultiPutCache.

    }
}