Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 12 | final class SimpleCacheAdapter implements PsrCache |
||
| 13 | { |
||
| 14 | /** |
||
| 15 | * @var DoctrineCache|ClearableCache|MultiGetCache|MultiPutCache |
||
| 16 | */ |
||
| 17 | private $doctrineCache; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @param DoctrineCache $doctrineCache |
||
| 21 | * @throws \Roave\DoctrineSimpleCache\CacheException |
||
| 22 | */ |
||
| 23 | 72 | public function __construct(DoctrineCache $doctrineCache) |
|
| 37 | |||
| 38 | /** |
||
| 39 | * {@inheritDoc} |
||
| 40 | */ |
||
| 41 | 29 | public function get($key, $default = null) |
|
| 50 | |||
| 51 | /** |
||
| 52 | * {@inheritDoc} |
||
| 53 | */ |
||
| 54 | 37 | View Code Duplication | public function set($key, $value, $ttl = null) : bool |
| 72 | |||
| 73 | /** |
||
| 74 | * {@inheritDoc} |
||
| 75 | */ |
||
| 76 | 7 | public function delete($key) : bool |
|
| 80 | |||
| 81 | /** |
||
| 82 | * {@inheritDoc} |
||
| 83 | */ |
||
| 84 | 59 | public function clear() : bool |
|
| 88 | |||
| 89 | /** |
||
| 90 | * {@inheritDoc} |
||
| 91 | */ |
||
| 92 | 12 | public function getMultiple($keys, $default = null) |
|
| 96 | |||
| 97 | /** |
||
| 98 | * {@inheritDoc} |
||
| 99 | */ |
||
| 100 | 24 | View Code Duplication | public function setMultiple($values, $ttl = null) : bool |
| 118 | |||
| 119 | /** |
||
| 120 | * {@inheritDoc} |
||
| 121 | */ |
||
| 122 | 5 | public function deleteMultiple($keys) : bool |
|
| 134 | |||
| 135 | /** |
||
| 136 | * {@inheritDoc} |
||
| 137 | */ |
||
| 138 | 3 | public function has($key) : bool |
|
| 142 | } |
||
| 143 |
It seems like the method you are trying to call exists only in some of the possible types.
Let’s take a look at an example:
Available Fixes
Add an additional type-check:
Only allow a single type to be passed if the variable comes from a parameter: