SimpleCacheAdapterTest - Code Metrics - Inspection of "Initial implementation of SimpleCache" - Roave/DoctrineSimpleCache - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by James

created 2017-01-03 10:18 UTC

SimpleCacheAdapterTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	153
Duplicated Lines	33.99 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	12
lcom	1
cbo	2
dl	52
loc	153
rs	10
c	1
b	0
f	1

12 Methods

Rating	Name	Duplication	Size	Complexity
A	testConstructorThrowsExceptionWhenNotMultiPuttableCacheIsUsed()	0	8	1
A	testConstructorThrowsExceptionWhenNotClearableCacheIsUsed()	0	8	1
A	testConstructorThrowsExceptionWhenNotMultiGettableCacheIsUsed()	0	8	1
A	testGetProxiesToDoctrineFetch()	0	12	1
A	testSetProxiesToDoctrineSave()	0	13	1
A	testDeleteProxiesToDoctrineDelete()	11	11	1
A	testClearProxiesToDeleteAll()	0	9	1
A	testGetMultipleProxiesToFetchMultiple()	0	15	1
A	testSetMultipleProxiesToSaveMultiple()	0	14	1
A	testDeleteMultipleReturnsTrueWhenAllDeletesSucceed()	15	15	1
A	testDeleteMultipleReturnsFalseWhenOneDeleteFails()	15	15	1
A	testHasProxiesToDoctrineContains()	11	11	1

How to fix Duplicated Code

<?php
declare(strict_types = 1);

namespace RoaveTest\DoctrineSimpleCache;

use Roave\DoctrineSimpleCache\CacheException;
use Roave\DoctrineSimpleCache\SimpleCacheAdapter;
use RoaveTestAsset\DoctrineSimpleCache\FullyImplementedCache;
use RoaveTestAsset\DoctrineSimpleCache\NotClearableCache;
use RoaveTestAsset\DoctrineSimpleCache\NotMultiGettableCache;
use RoaveTestAsset\DoctrineSimpleCache\NotMultiPuttableCache;

/**
 * @covers \Roave\DoctrineSimpleCache\SimpleCacheAdapter
 */
final class SimpleCacheAdapterTest extends \PHPUnit_Framework_TestCase
{
    public function testConstructorThrowsExceptionWhenNotMultiPuttableCacheIsUsed()
    {
        /** @var NotMultiPuttableCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(NotMultiPuttableCache::class);

        $this->expectException(CacheException::class);
        new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testConstructorThrowsExceptionWhenNotClearableCacheIsUsed()
    {
        /** @var NotClearableCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(NotClearableCache::class);

        $this->expectException(CacheException::class);
        new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testConstructorThrowsExceptionWhenNotMultiGettableCacheIsUsed()
    {
        /** @var NotMultiGettableCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(NotMultiGettableCache::class);

        $this->expectException(CacheException::class);
        new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    public function testGetProxiesToDoctrineFetch()
    {
        $key = uniqid('key', true);
        $value = uniqid('value', true);

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('fetch')->with($key)->willReturn($value);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertSame($value, $psrCache->get($key));
    }

    public function testSetProxiesToDoctrineSave()
    {
        $key = uniqid('key', true);
        $value = uniqid('value', true);
        $ttl = random_int(1000,9999);

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('save')->with($key, $value, $ttl)->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->set($key, $value, $ttl));
    }

    public function testDeleteProxiesToDoctrineDelete()

    {
        $key = uniqid('key', true);

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('delete')->with($key)->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->delete($key));
    }

    public function testClearProxiesToDeleteAll()
    {
        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('deleteAll')->with()->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->clear());
    }

    public function testGetMultipleProxiesToFetchMultiple()
    {
        $values = [
            uniqid('key1', true) => uniqid('value1', true),
            uniqid('key2', true) => uniqid('value2', true),
        ];
        $keys = array_keys($values);

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('fetchMultiple')->with($keys)->willReturn($values);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertSame($values, $psrCache->getMultiple($keys));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testSetMultipleProxiesToSaveMultiple()
    {
        $values = [
            uniqid('key1', true) => uniqid('value1', true),
            uniqid('key2', true) => uniqid('value2', true),
        ];

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('saveMultiple')->with($values)->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->setMultiple($values));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testDeleteMultipleReturnsTrueWhenAllDeletesSucceed()

    {
        $keys = [
            uniqid('key1', true),
            uniqid('key2', true),
        ];

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::at(0))->method('delete')->with($keys[0])->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $doctrineCache->expects(self::at(1))->method('delete')->with($keys[1])->willReturn(true);

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->deleteMultiple($keys));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testDeleteMultipleReturnsFalseWhenOneDeleteFails()

    {
        $keys = [
            uniqid('key1', true),
            uniqid('key2', true),
        ];

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::at(0))->method('delete')->with($keys[0])->willReturn(false);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $doctrineCache->expects(self::at(1))->method('delete')->with($keys[1])->willReturn(true);

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertFalse($psrCache->deleteMultiple($keys));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testHasProxiesToDoctrineContains()

    {
        $key = uniqid('key', true);

        /** @var FullyImplementedCache|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
        $doctrineCache = $this->createMock(FullyImplementedCache::class);
        $doctrineCache->expects(self::once())->method('contains')->with($key)->willReturn(true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        $psrCache = new SimpleCacheAdapter($doctrineCache);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        self::assertTrue($psrCache->has($key));
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace RoaveTest\DoctrineSimpleCache;
5
6		use Roave\DoctrineSimpleCache\CacheException;
7		use Roave\DoctrineSimpleCache\SimpleCacheAdapter;
8		use RoaveTestAsset\DoctrineSimpleCache\FullyImplementedCache;
9		use RoaveTestAsset\DoctrineSimpleCache\NotClearableCache;
10		use RoaveTestAsset\DoctrineSimpleCache\NotMultiGettableCache;
11		use RoaveTestAsset\DoctrineSimpleCache\NotMultiPuttableCache;
12
13		/**
14		* @covers \Roave\DoctrineSimpleCache\SimpleCacheAdapter
15		*/
16		final class SimpleCacheAdapterTest extends \PHPUnit_Framework_TestCase
17		{
18		public function testConstructorThrowsExceptionWhenNotMultiPuttableCacheIsUsed()
19		{
20		/** @var NotMultiPuttableCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
21		$doctrineCache = $this->createMock(NotMultiPuttableCache::class);
22
23		$this->expectException(CacheException::class);
24		new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...tiPuttableCache::class)` on line `21` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
25		}
26
27		public function testConstructorThrowsExceptionWhenNotClearableCacheIsUsed()
28		{
29		/** @var NotClearableCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
30		$doctrineCache = $this->createMock(NotClearableCache::class);
31
32		$this->expectException(CacheException::class);
33		new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...tClearableCache::class)` on line `30` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
34		}
35
36		public function testConstructorThrowsExceptionWhenNotMultiGettableCacheIsUsed()
37		{
38		/** @var NotMultiGettableCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
39		$doctrineCache = $this->createMock(NotMultiGettableCache::class);
40
41		$this->expectException(CacheException::class);
42		new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...tiGettableCache::class)` on line `39` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
43		}
44
45		public function testGetProxiesToDoctrineFetch()
46		{
47		$key = uniqid('key', true);
48		$value = uniqid('value', true);
49
50		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
51		$doctrineCache = $this->createMock(FullyImplementedCache::class);
52		$doctrineCache->expects(self::once())->method('fetch')->with($key)->willReturn($value);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
53
54		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `51` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
55		self::assertSame($value, $psrCache->get($key));
56		}
57
58		public function testSetProxiesToDoctrineSave()
59		{
60		$key = uniqid('key', true);
61		$value = uniqid('value', true);
62		$ttl = random_int(1000,9999);
63
64		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
65		$doctrineCache = $this->createMock(FullyImplementedCache::class);
66		$doctrineCache->expects(self::once())->method('save')->with($key, $value, $ttl)->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
67
68		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `65` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
69		self::assertTrue($psrCache->set($key, $value, $ttl));
70		}
71
72	View Code Duplication	public function testDeleteProxiesToDoctrineDelete()
		0 ignored issues – show Duplication introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		$key = uniqid('key', true);
75
76		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
77		$doctrineCache = $this->createMock(FullyImplementedCache::class);
78		$doctrineCache->expects(self::once())->method('delete')->with($key)->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
79
80		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `77` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
81		self::assertTrue($psrCache->delete($key));
82		}
83
84		public function testClearProxiesToDeleteAll()
85		{
86		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
87		$doctrineCache = $this->createMock(FullyImplementedCache::class);
88		$doctrineCache->expects(self::once())->method('deleteAll')->with()->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
89
90		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `87` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
91		self::assertTrue($psrCache->clear());
92		}
93
94		public function testGetMultipleProxiesToFetchMultiple()
95		{
96		$values = [
97		uniqid('key1', true) => uniqid('value1', true),
98		uniqid('key2', true) => uniqid('value2', true),
99		];
100		$keys = array_keys($values);
101
102		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
103		$doctrineCache = $this->createMock(FullyImplementedCache::class);
104		$doctrineCache->expects(self::once())->method('fetchMultiple')->with($keys)->willReturn($values);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
105
106		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `103` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
107		self::assertSame($values, $psrCache->getMultiple($keys));
		0 ignored issues – show Documentation introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report `$keys` is of type `array<integer,string>`, but the function expects a `object<Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
108		}
109
110		public function testSetMultipleProxiesToSaveMultiple()
111		{
112		$values = [
113		uniqid('key1', true) => uniqid('value1', true),
114		uniqid('key2', true) => uniqid('value2', true),
115		];
116
117		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
118		$doctrineCache = $this->createMock(FullyImplementedCache::class);
119		$doctrineCache->expects(self::once())->method('saveMultiple')->with($values)->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
120
121		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `118` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
122		self::assertTrue($psrCache->setMultiple($values));
		0 ignored issues – show Documentation introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report `$values` is of type `array<string,string>`, but the function expects a `object<Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
123		}
124
125	View Code Duplication	public function testDeleteMultipleReturnsTrueWhenAllDeletesSucceed()
		0 ignored issues – show Duplication introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		{
127		$keys = [
128		uniqid('key1', true),
129		uniqid('key2', true),
130		];
131
132		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
133		$doctrineCache = $this->createMock(FullyImplementedCache::class);
134		$doctrineCache->expects(self::at(0))->method('delete')->with($keys[0])->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
135		$doctrineCache->expects(self::at(1))->method('delete')->with($keys[1])->willReturn(true);
136
137		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `133` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
138		self::assertTrue($psrCache->deleteMultiple($keys));
		0 ignored issues – show Documentation introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report `$keys` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `object<Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
139		}
140
141	View Code Duplication	public function testDeleteMultipleReturnsFalseWhenOneDeleteFails()
		0 ignored issues – show Duplication introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
142		{
143		$keys = [
144		uniqid('key1', true),
145		uniqid('key2', true),
146		];
147
148		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
149		$doctrineCache = $this->createMock(FullyImplementedCache::class);
150		$doctrineCache->expects(self::at(0))->method('delete')->with($keys[0])->willReturn(false);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
151		$doctrineCache->expects(self::at(1))->method('delete')->with($keys[1])->willReturn(true);
152
153		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `149` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
154		self::assertFalse($psrCache->deleteMultiple($keys));
		0 ignored issues – show Documentation introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report `$keys` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `object<Psr\SimpleCache\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
155		}
156
157	View Code Duplication	public function testHasProxiesToDoctrineContains()
		0 ignored issues – show Duplication introduced 2017-01-03 10:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
158		{
159		$key = uniqid('key', true);
160
161		/** @var FullyImplementedCache\|\PHPUnit_Framework_MockObject_MockObject $doctrineCache */
162		$doctrineCache = $this->createMock(FullyImplementedCache::class);
163		$doctrineCache->expects(self::once())->method('contains')->with($key)->willReturn(true);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report The method `expects` does only exist in `PHPUnit_Framework_MockObject_MockObject`, but not in `RoaveTestAsset\DoctrineS...e\FullyImplementedCache`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
164
165		$psrCache = new SimpleCacheAdapter($doctrineCache);
		0 ignored issues – show Bug introduced 2017-01-03 10:13 UTC by Report Bug Copy Issue Report It seems like `$doctrineCache` defined by `$this->createMock(\Roave...mplementedCache::class)` on line `162` can also be of type `object<PHPUnit_Framework_MockObject_MockObject>`; however, `Roave\DoctrineSimpleCach...eAdapter::__construct()` does only seem to accept `object<Doctrine\Common\Cache\Cache>`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
166		self::assertTrue($psrCache->has($key));
167		}
168		}
169

Roave / DoctrineSimpleCache

Pull Request — master (#1)

SimpleCacheAdapterTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like