Inspection of "[draft] Upgrade nikolaposa/version to 4.0.0" - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#179)

by Nikola

created 2019-12-14 11:48 UTC

Status

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/AncestorRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameClassTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/TraitBased/TraitBecameClassTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/TraitBased/TraitBecameInterfaceTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

unit/DetectChanges/BCBreak/MethodBased/MethodConcretenessChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/MethodBased/MethodScopeChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,7 +37,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

BCBreak/ClassConstantBased/ClassConstantVisibilityReducedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
 
         return array_combine(array_keys($properties),
             array_map(
-                function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getReflectionConstant($constant),
                         $toClass->getReflectionConstant($constant),

Please login to merge, or discard this patch.

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	self::assertSame(
39	39	$expectedMessages,
40		- array_map(static function (Change $change) : string {
	40	+ array_map(static function(Change $change) : string {
41	41	return $change->__toString();
42	42	}, iterator_to_array($changes))
43	43	);
		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	return array_combine(
124	124	array_keys($properties),
125	125	array_map(
126		- static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
	126	+ static function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
127	127	return [
128	128	$fromClass->getMethod($methodName),
129	129	$toClass->getMethod($methodName),

		@@ -37,7 +37,7 @@ discard block
		block discarded – undo
37	37
38	38	self::assertSame(
39	39	$expectedMessages,
40		- array_map(static function (Change $change) : string {
	40	+ array_map(static function(Change $change) : string {
41	41	return $change->__toString();
42	42	}, iterator_to_array($changes))
43	43	);
		@@ -123,7 +123,7 @@ discard block
		block discarded – undo
123	123	return array_combine(
124	124	array_keys($properties),
125	125	array_map(
126		- static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
	126	+ static function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
127	127	return [
128	128	$fromClass->getMethod($methodName),
129	129	$toClass->getMethod($methodName),

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(static function (Change $change) : string {
	36	+ array_map(static function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

		@@ -35,7 +35,7 @@ discard block
		block discarded – undo
35	35
36	36	self::assertSame(
37	37	$expectedMessages,
38		- array_map(function (Change $change) : string {
	38	+ array_map(function(Change $change) : string {
39	39	return $change->__toString();
40	40	}, iterator_to_array($changes))
41	41	);
		@@ -112,7 +112,7 @@ discard block
		block discarded – undo
112	112
113	113	return array_combine(array_keys($properties),
114	114	array_map(
115		- function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
	115	+ function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
116	116	return [
117	117	$fromClass->getReflectionConstant($constant),
118	118	$toClass->getReflectionConstant($constant),

Roave / BackwardCompatibilityCheck

Pull Request — master (#179)

Status

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch