Completed
Pull Request — master (#58)
by James
03:14
created
src/Changes.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public function mergeWith(self $other) : self
46 46
     {
47
-        if (! $other->changes) {
47
+        if (!$other->changes) {
48 48
             return $this;
49 49
         }
50 50
 
Please login to merge, or discard this patch.
src/Command/AssertBackwardsCompatible.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -161,23 +161,23 @@
 block discarded – undo
161 161
         $toPath   = $this->git->checkout($sourceRepo, $toRevision);
162 162
 
163 163
         try {
164
-            $fromSources = $fromPath . '/' . $sourcesPath;
165
-            $toSources   = $toPath . '/' . $sourcesPath;
164
+            $fromSources = $fromPath.'/'.$sourcesPath;
165
+            $toSources   = $toPath.'/'.$sourcesPath;
166 166
 
167 167
             Assert::that($fromSources)->directory();
168 168
             Assert::that($toSources)->directory();
169 169
 
170 170
             $changes = $this->compareApi->__invoke(
171 171
                 $this->reflectorFactory->__invoke(
172
-                    $fromPath . '/' . $sourcesPath,
172
+                    $fromPath.'/'.$sourcesPath,
173 173
                     new AggregateSourceLocator() // no dependencies
174 174
                 ),
175 175
                 $this->reflectorFactory->__invoke(
176
-                    $fromPath . '/' . $sourcesPath,
176
+                    $fromPath.'/'.$sourcesPath,
177 177
                     $this->locateDependencies->__invoke((string) $fromPath)
178 178
                 ),
179 179
                 $this->reflectorFactory->__invoke(
180
-                    $toPath . '/' . $sourcesPath,
180
+                    $toPath.'/'.$sourcesPath,
181 181
                     $this->locateDependencies->__invoke((string) $toPath)
182 182
                 )
183 183
             );
Please login to merge, or discard this patch.
src/CompareClasses.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
     ) : Changes {
49 49
         $changelog = Changes::empty();
50 50
 
51
-        $definedApiClassNames = array_map(function (ReflectionClass $class) : string {
51
+        $definedApiClassNames = array_map(function(ReflectionClass $class) : string {
52 52
             return $class->getName();
53 53
         }, $definedSymbols->getAllClasses());
54 54
 
Please login to merge, or discard this patch.
src/Git/GetVersionCollectionFromGitRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
             ->getOutput();
32 32
 
33 33
         return VersionsCollection::fromArray(array_filter(
34
-            array_map(function (string $maybeVersion) : ?Version {
34
+            array_map(function(string $maybeVersion) : ?Version {
35 35
                 try {
36 36
                     return Version::fromString($maybeVersion);
37 37
                 } catch (InvalidVersionStringException $e) {
Please login to merge, or discard this patch.
test/unit/Git/GitCheckoutRevisionToTemporaryPathTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
         $revision = Revision::fromSha1(self::TEST_REVISION_TO_CHECKOUT);
24 24
 
25 25
         $temporaryClone = $git->checkout(
26
-            CheckedOutRepository::fromPath(realpath(__DIR__ . '/../../../')),
26
+            CheckedOutRepository::fromPath(realpath(__DIR__.'/../../../')),
27 27
             $revision
28 28
         );
29 29
 
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
     public function testCanCheckOutSameRevisionTwice() : void
36 36
     {
37 37
         $git              = new GitCheckoutRevisionToTemporaryPath();
38
-        $sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__ . '/../../../'));
38
+        $sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__.'/../../../'));
39 39
         $revision         = Revision::fromSha1(self::TEST_REVISION_TO_CHECKOUT);
40 40
 
41 41
         $first  = $git->checkout($sourceRepository, $revision);
@@ -50,10 +50,10 @@  discard block
 block discarded – undo
50 50
 
51 51
     public function testExceptionIsThrownWhenTwoPathsCollide() : void
52 52
     {
53
-        $git              = new GitCheckoutRevisionToTemporaryPath(function () : string {
53
+        $git              = new GitCheckoutRevisionToTemporaryPath(function() : string {
54 54
             return 'foo';
55 55
         });
56
-        $sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__ . '/../../../'));
56
+        $sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__.'/../../../'));
57 57
         $revision         = Revision::fromSha1(self::TEST_REVISION_TO_CHECKOUT);
58 58
 
59 59
         $first = $git->checkout($sourceRepository, $revision);
Please login to merge, or discard this patch.
test/unit/Git/GetVersionCollectionFromGitRepositoryTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,10 +26,10 @@  discard block
 block discarded – undo
26 26
 
27 27
     public function setUp() : void
28 28
     {
29
-        $tmpGitRepo = sys_get_temp_dir() . '/api-compare-' . uniqid('tmpGitRepo', true);
29
+        $tmpGitRepo = sys_get_temp_dir().'/api-compare-'.uniqid('tmpGitRepo', true);
30 30
         mkdir($tmpGitRepo, 0777, true);
31 31
         (new Process(['git', 'init']))->setWorkingDirectory($tmpGitRepo)->mustRun();
32
-        file_put_contents($tmpGitRepo . '/test', uniqid('testContent', true));
32
+        file_put_contents($tmpGitRepo.'/test', uniqid('testContent', true));
33 33
         (new Process(['git', 'add', '.']))->setWorkingDirectory($tmpGitRepo)->mustRun();
34 34
         (new Process(['git', 'commit', '-m', '"whatever"']))->setWorkingDirectory($tmpGitRepo)->mustRun();
35 35
         $this->repoPath = CheckedOutRepository::fromPath($tmpGitRepo);
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
     private function getTags() : array
50 50
     {
51 51
         return array_map(
52
-            function (Version $version) {
52
+            function(Version $version) {
53 53
                 return $version->getVersionString();
54 54
             },
55 55
             iterator_to_array((new GetVersionCollectionFromGitRepository())->fromRepository($this->repoPath))
Please login to merge, or discard this patch.
src/Git/GitCheckoutRevisionToTemporaryPath.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
     public function __construct(?callable $uniquenessFunction = null)
23 23
     {
24
-        $this->uniquenessFunction = $uniquenessFunction ?? function (string $nonUniqueThing) : string {
24
+        $this->uniquenessFunction = $uniquenessFunction ?? function(string $nonUniqueThing) : string {
25 25
                 return uniqid($nonUniqueThing, true);
26 26
             };
27 27
     }
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     private function generateTemporaryPathFor(Revision $revision) : string
56 56
     {
57 57
         $uniquePathGenerator = $this->uniquenessFunction;
58
-        $checkoutDirectory   = sys_get_temp_dir() . '/api-compare-' . $uniquePathGenerator((string) $revision . '_');
58
+        $checkoutDirectory   = sys_get_temp_dir().'/api-compare-'.$uniquePathGenerator((string) $revision.'_');
59 59
 
60 60
         Assert::that($checkoutDirectory)->not
61 61
         if (file_exists($checkoutDirectory) || is_dir($checkoutDirectory)) {
Please login to merge, or discard this patch.