Roave / BackwardCompatibilityCheck

src/Git/CheckedOutRepository.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
     public static function fromPath(string $path) : self
     {
         Assert::that($path)->directory();
-        Assert::that($path . '/.git')->directory();
+        Assert::that($path.'/.git')->directory();
         $instance       = new self();
         $instance->path = $path;
         return $instance;

src/LocateDependencies/LocateDependenciesViaComposer.php

Indentation +6 added lines, -6 removed lines

@@ -76,9 +76,9 @@ 
         $classMap = $classMapProperty->getDefaultValue();
 
         Assert::that($classMap)
-              ->isArray()
-              ->all()
-              ->file();
+                ->isArray()
+                ->all()
+                ->file();
 
         return new StaticClassMapSourceLocator($classMap, $this->astLocator);
     }
@@ -92,9 +92,9 @@ 
         $filesMap = $filesMapProperty->getDefaultValue();
 
         Assert::that($filesMap)
-              ->isArray()
-              ->all()
-              ->file();
+                ->isArray()
+                ->all()
+                ->file();
 
         return new AggregateSourceLocator(array_values(array_map(
             function (string $path) : SourceLocator {

Spacing +4 added lines, -4 removed lines

@@ -40,13 +40,13 @@ 
     public function __invoke(string $installationPath) : SourceLocator
     {
         Assert::that($installationPath)->directory();
-        Assert::that($installationPath . '/composer.json')->file();
+        Assert::that($installationPath.'/composer.json')->file();
 
-        $this->runInDirectory(function () {
+        $this->runInDirectory(function() {
             $this->installer->run();
         }, $installationPath);
 
-        $autoloadStatic = $installationPath . '/vendor/composer/autoload_static.php';
+        $autoloadStatic = $installationPath.'/vendor/composer/autoload_static.php';
 
         Assert::that($autoloadStatic)->file();
 
@@ -97,7 +97,7 @@ 
               ->file();
 
         return new AggregateSourceLocator(array_values(array_map(
-            function (string $path) : SourceLocator {
+            function(string $path) : SourceLocator {
                 return new SingleFileSourceLocator(
                     realpath($path),
                     $this->astLocator

src/Comparator.php

Spacing +3 added lines, -3 removed lines

@@ -31,7 +31,7 @@ 
     ) : Changes {
         $changelog = Changes::new();
 
-        $definedApiClassNames = array_map(function (ReflectionClass $class) : string {
+        $definedApiClassNames = array_map(function(ReflectionClass $class) : string {
             return $class->getName();
         }, $definedApi->getAllClasses());
 
@@ -56,7 +56,7 @@ 
 
         $changelog->mergeWith($this->classBasedComparisons->compare($oldClass, $newClass));
 
-        if ($newClass->isFinal() && ! $oldClass->isFinal()) {
+        if ($newClass->isFinal() && !$oldClass->isFinal()) {
             $changelog = $changelog->withAddedChange(
                 Change::changed(sprintf('Class %s is now final', $oldClass->getName()), true)
             );
@@ -117,7 +117,7 @@ 
         ReflectionMethod $newMethod
     ) : Changes {
         $newParameters = $newMethod->getParameters();
-        if (! array_key_exists($parameterPosition, $newParameters)) {
+        if (!array_key_exists($parameterPosition, $newParameters)) {
             return $changelog->withAddedChange(
                 Change::removed(
                     sprintf(

src/Comparator/BackwardsCompatibility/ClassBased/ConstantValueChanged.php

Spacing +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
         $fromValues = $this->accessibleConstantValues($fromClass);
         $toValues   = $this->accessibleConstantValues($toClass);
 
-        $changedConstants = array_keys(array_filter($fromValues, function (
+        $changedConstants = array_keys(array_filter($fromValues, function(
             $constantValue,
             string $constantName
         ) use (
@@ -28,7 +28,7 @@ 
             return array_key_exists($constantName, $toValues) && $constantValue !== $toValues[$constantName];
         }, \ARRAY_FILTER_USE_BOTH));
 
-        return Changes::fromArray(array_map(function (string $constantName) use ($fromClass) : Change {
+        return Changes::fromArray(array_map(function(string $constantName) use ($fromClass) : Change {
             return Change::changed(
                 sprintf('Value of constant %s::%s changed', $fromClass->getName(), $constantName),
                 true
@@ -41,12 +41,12 @@ 
     {
         $accessibleConstants = array_filter(
             $class->getReflectionConstants(),
-            function (ReflectionClassConstant $constant) : bool {
+            function(ReflectionClassConstant $constant) : bool {
                 return $constant->isPublic() || $constant->isProtected();
             }
         );
 
-        return array_map(function (ReflectionClassConstant $constant) {
+        return array_map(function(ReflectionClassConstant $constant) {
             return $constant->getValue();
         }, $accessibleConstants);
     }

src/Comparator/BackwardsCompatibility/ClassBased/ConstantRemoved.php

Spacing +2 added lines, -2 removed lines

@@ -21,7 +21,7 @@ 
             $this->accessibleConstants($toClass)
         );
 
-        return Changes::fromArray(array_values(array_map(function (ReflectionClassConstant $constant) use ($fromClass) : Change {
+        return Changes::fromArray(array_values(array_map(function(ReflectionClassConstant $constant) use ($fromClass) : Change {
             return Change::removed(
                 sprintf('Constant %s::%s was removed', $fromClass->getName(), $constant->getName()),
                 true
@@ -32,7 +32,7 @@ 
     /** @return ReflectionClassConstant[] */
     private function accessibleConstants(ReflectionClass $class) : array
     {
-        return array_filter($class->getReflectionConstants(), function (ReflectionClassConstant $constant) : bool {
+        return array_filter($class->getReflectionConstants(), function(ReflectionClassConstant $constant) : bool {
             return $constant->isPublic() || $constant->isProtected();
         });
     }

src/Comparator/BackwardsCompatibility/ClassBased/ConstantVisibilityReduced.php

Spacing +4 added lines, -4 removed lines

@@ -30,19 +30,19 @@ 
             array_combine(
                 $sharedKeys,
                 array_map(
-                    function (string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
+                    function(string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
                         return [$visibilitiesFrom[$propertyName], $visibilitiesTo[$propertyName]];
                     },
                     $sharedKeys
                 )
             ),
-            function (array $visibilities) : bool {
+            function(array $visibilities) : bool {
                 // Note: works because the strings "public", "protected" and "private" can be compared directly as they sort correctly for our purposes
                 return $visibilities[0] > $visibilities[1];
             }
         );
 
-        return Changes::fromArray(array_values(array_map(function (
+        return Changes::fromArray(array_values(array_map(function(
             string $propertyName,
             array $visibilities
         ) use (
@@ -64,7 +64,7 @@ 
     /** @return string[] indexed by constant name */
     private function constantVisibilities(ReflectionClass $class) : array
     {
-        return array_map(function (ReflectionClassConstant $constant) : string {
+        return array_map(function(ReflectionClassConstant $constant) : string {
             if ($constant->isPublic()) {
                 return self::VISIBILITY_PUBLIC;
             }

src/Comparator/BackwardsCompatibility/ClassBased/MethodVisibilityReduced.php

Spacing +5 added lines, -5 removed lines

@@ -37,19 +37,19 @@ 
             array_combine(
                 $sharedKeys,
                 array_map(
-                    function (string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
+                    function(string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
                         return [$visibilitiesFrom[$propertyName], $visibilitiesTo[$propertyName]];
                     },
                     $sharedKeys
                 )
             ),
-            function (array $visibilities) : bool {
+            function(array $visibilities) : bool {
                 // Note: works because the strings "public", "protected" and "private" can be compared directly as they sort correctly for our purposes
                 return $visibilities[0] > $visibilities[1];
             }
         );
 
-        return Changes::fromArray(array_values(array_map(function (
+        return Changes::fromArray(array_values(array_map(function(
             string $methodName,
             array $visibilities
         ) use (
@@ -74,10 +74,10 @@ 
         $methods = $class->getMethods();
 
         return array_combine(
-            array_map(function (ReflectionMethod $method) : string {
+            array_map(function(ReflectionMethod $method) : string {
                 return $method->getName();
             }, $methods),
-            array_map(function (ReflectionMethod $method) : string {
+            array_map(function(ReflectionMethod $method) : string {
                 if ($method->isPublic()) {
                     return self::VISIBILITY_PUBLIC;
                 }

src/Comparator/BackwardsCompatibility/ClassBased/PropertyVisibilityReduced.php

Spacing +4 added lines, -4 removed lines

@@ -37,19 +37,19 @@ 
             array_combine(
                 $sharedKeys,
                 array_map(
-                    function (string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
+                    function(string $propertyName) use ($visibilitiesFrom, $visibilitiesTo) : array {
                         return [$visibilitiesFrom[$propertyName], $visibilitiesTo[$propertyName]];
                     },
                     $sharedKeys
                 )
             ),
-            function (array $visibilities) : bool {
+            function(array $visibilities) : bool {
                 // Note: works because the strings "public", "protected" and "private" can be compared directly as they sort correctly for our purposes
                 return $visibilities[0] > $visibilities[1];
             }
         );
 
-        return Changes::fromArray(array_values(array_map(function (
+        return Changes::fromArray(array_values(array_map(function(
             string $propertyName,
             array $visibilities
         ) use (
@@ -71,7 +71,7 @@ 
     /** @return string[] */
     private function propertyVisibilities(ReflectionClass $class) : array
     {
-        return array_map(function (ReflectionProperty $property) : string {
+        return array_map(function(ReflectionProperty $property) : string {
             if ($property->isPublic()) {
                 return self::VISIBILITY_PUBLIC;
             }

src/Comparator/BackwardsCompatibility/ClassBased/MultiClassBased.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     {
         return array_reduce(
             $this->checks,
-            function (Changes $changes, ClassBased $check) use ($fromClass, $toClass) : Changes {
+            function(Changes $changes, ClassBased $check) use ($fromClass, $toClass) : Changes {
                 return $changes->mergeWith($check->compare($fromClass, $toClass));
             },
             Changes::new()