View GitHub Repository BackwardCompatibilityCheck

Schedule Inspection
Subscribe
Passed
Pull Request — master (#120)
by Marco
06:44
created
Status
Category
Toggle Patches
test/unit/DetectChanges/BCBreak/InterfaceBased/MethodAddedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33
34 34 
         self::assertSame(
35 35 
             $expectedMessages,
36 
-            array_map(static function (Change $change) : string {
36 
+            array_map(static function(Change $change) : string {
37 37 
                 return $change->__toString();
38 38 
             }, iterator_to_array($changes))
39 39 
         );
 
@@ -106,7 +106,7 @@  discard block
 
 block discarded – undo
106 106 
         return array_combine(
107 107 
             array_keys($properties),
108 108 
             array_map(
109 
-                static function (string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
109 
+                static function(string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
110 110 
                 ) : array {
111 111 
                     return [
112 112 
                         $fromClassReflector->reflect($className),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/InterfaceBased/AncestorRemovedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(static function (Change $change) : string {
39 
+            array_map(static function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
             ,
64 64 
             $locator
65 65 
         ));
66 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
66 
+        $toReflector = new ClassReflector(new StringSourceLocator(
67 67 
             <<<'PHP'
68 68 
 <?php
69 69 
 
@@ -95,7 +95,7 @@  discard block
 
 block discarded – undo
95 95 
         return array_combine(
96 96 
             array_keys($interfaces),
97 97 
             array_map(
98 
-                static function (string $interfaceName, array $errors) use ($fromReflector, $toReflector) : array {
98 
+                static function(string $interfaceName, array $errors) use ($fromReflector, $toReflector) : array {
99 99 
                     return [
100 100 
                         $fromReflector->reflect($interfaceName),
101 101 
                         $toReflector->reflect($interfaceName),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/MethodBased/MethodBecameFinalTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37
38 38 
         self::assertSame(
39 39 
             $expectedMessages,
40 
-            array_map(static function (Change $change) : string {
40 
+            array_map(static function(Change $change) : string {
41 41 
                 return $change->__toString();
42 42 
             }, iterator_to_array($changes))
43 43 
         );
 
@@ -123,7 +123,7 @@  discard block
 
 block discarded – undo
123 123 
         return array_combine(
124 124 
             array_keys($properties),
125 125 
             array_map(
126 
-                static function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
126 
+                static function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
127 127 
                     return [
128 128 
                         $fromClass->getMethod($methodName),
129 129 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/MethodBased/MethodVisibilityReducedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(static function (Change $change) : string {
39 
+            array_map(static function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -108,7 +108,7 @@  discard block
 
 block discarded – undo
108 108 
         return array_combine(
109 109 
             array_keys($properties),
110 110 
             array_map(
111 
-                static function (string $method, array $errorMessages) use ($fromClass, $toClass) : array {
111 
+                static function(string $method, array $errorMessages) use ($fromClass, $toClass) : array {
112 112 
                     return [
113 113 
                         $fromClass->getMethod($method),
114 114 
                         $toClass->getMethod($method),
Please login to merge, or discard this patch.
DetectChanges/BCBreak/ClassConstantBased/ClassConstantValueChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -37,7 +37,7 @@  discard block
 
 block discarded – undo
37 37
38 38 
         self::assertSame(
39 39 
             $expectedMessages,
40 
-            array_map(static function (Change $change) : string {
40 
+            array_map(static function(Change $change) : string {
41 41 
                 return $change->__toString();
42 42 
             }, iterator_to_array($changes))
43 43 
         );
 
@@ -121,7 +121,7 @@  discard block
 
 block discarded – undo
121 121 
         return array_combine(
122 122 
             array_keys($properties),
123 123 
             array_map(
124 
-                static function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
124 
+                static function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
125 125 
                     return [
126 126 
                         $fromClass->getReflectionConstant($constant),
127 127 
                         $toClass->getReflectionConstant($constant),
Please login to merge, or discard this patch.
test/unit/DetectChanges/Variance/TypeIsContravariantTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -224,7 +224,7 @@  discard block
 
 block discarded – undo
224 224 
         return array_merge(
225 225 
             [[null]],
226 226 
             array_merge(...array_map(
227 
-                static function (string $type) use ($reflector) : array {
227 
+                static function(string $type) use ($reflector) : array {
228 228 
                     return [
229 229 
                         [ReflectionType::createFromTypeAndReflector($type, false, $reflector)],
230 230 
                         [ReflectionType::createFromTypeAndReflector($type, true, $reflector)],
 
@@ -248,7 +248,7 @@  discard block
 
 block discarded – undo
248 248 
     /** @dataProvider existingNullableTypeStrings */
249 249 
     public function testContravarianceConsidersNullability(string $type) : void
250 250 
     {
251 
-        $reflector   = new ClassReflector(new StringSourceLocator(
251 
+        $reflector = new ClassReflector(new StringSourceLocator(
252 252 
             <<<'PHP'
253 253 
 <?php
254 254
Please login to merge, or discard this patch.
test/unit/DetectChanges/Variance/TypeIsCovariantTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -235,7 +235,7 @@  discard block
 
 block discarded – undo
235 235 
         return array_merge(
236 236 
             [[null]],
237 237 
             array_merge(...array_map(
238 
-                static function (string $type) use ($reflector) : array {
238 
+                static function(string $type) use ($reflector) : array {
239 239 
                     return [
240 240 
                         [ReflectionType::createFromTypeAndReflector($type, false, $reflector)],
241 241 
                         [ReflectionType::createFromTypeAndReflector($type, true, $reflector)],
 
@@ -259,7 +259,7 @@  discard block
 
 block discarded – undo
259 259 
     /** @dataProvider existingNullableTypeStrings */
260 260 
     public function testCovarianceConsidersNullability(string $type) : void
261 261 
     {
262 
-        $reflector   = new ClassReflector(new StringSourceLocator(
262 
+        $reflector = new ClassReflector(new StringSourceLocator(
263 263 
             <<<'PHP'
264 264 
 <?php
265 265
Please login to merge, or discard this patch.
test/unit/Command/AssertBackwardsCompatibleTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -75,7 +75,7 @@  discard block
 
 block discarded – undo
75 75
76 76 
     public function setUp() : void
77 77 
     {
78 
-        $repositoryPath = realpath(__DIR__ . '/../../../');
78 
+        $repositoryPath = realpath(__DIR__.'/../../../');
79 79
80 80 
         self::assertInternalType('string', $repositoryPath);
81 81 
 
@@ -274,7 +274,7 @@  discard block
 
 block discarded – undo
274 274
275 275 
         $this->output->expects(self::any())
276 276 
             ->method('writeln')
277 
-            ->willReturnCallback(static function (string $output) use ($changeToExpect) : void {
277 
+            ->willReturnCallback(static function(string $output) use ($changeToExpect) : void {
278 278 
                 self::assertContains($changeToExpect, $output);
279 279 
             });
280 280 
     }
 
@@ -358,7 +358,7 @@  discard block
 
 block discarded – undo
358 358
359 359 
         $this->getVersions->expects(self::once())
360 360 
             ->method('fromRepository')
361 
-            ->with(self::callback(function (CheckedOutRepository $checkedOutRepository) : bool {
361 
+            ->with(self::callback(function(CheckedOutRepository $checkedOutRepository) : bool {
362 362 
                 self::assertEquals($this->sourceRepository, $checkedOutRepository);
363 363 
                 return true;
364 364 
             }))
Please login to merge, or discard this patch.
src/Git/GetVersionCollectionFromGitRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -32,7 +32,7 @@
 
 block discarded – undo
32 32 
             ->getOutput();
33 33
34 34 
         return new VersionsCollection(...array_filter(
35 
-            array_map(static function (string $maybeVersion) : ?Version {
35 
+            array_map(static function(string $maybeVersion) : ?Version {
36 36 
                 try {
37 37 
                     return Version::fromString($maybeVersion);
38 38 
                 } catch (InvalidVersionStringException $e) {
Please login to merge, or discard this patch.