View GitHub Repository BackwardCompatibilityCheck

Schedule Inspection
Subscribe
Passed
Pull Request — master (#38)
by Marco
02:23
created
Status
Category
Toggle Patches
FunctionBased/RequiredParameterAmountIncreasedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\FunctionBased;
6 6 
 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35
36 36 
         self::assertSame(
37 37 
             $expectedMessages,
38 
-            array_map(function (Change $change) : string {
38 
+            array_map(function(Change $change) : string {
39 39 
                 return $change->__toString();
40 40 
             }, iterator_to_array($changes))
41 41 
         );
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
             array_combine(
117 117 
                 array_keys($functions),
118 118 
                 array_map(
119 
-                    function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
119 
+                    function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
120 120 
                         return [
121 121 
                             $fromReflector->reflect($function),
122 122 
                             $toReflector->reflect($function),
Please login to merge, or discard this patch.
BackwardsCompatibility/FunctionBased/ParameterByReferenceChangedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\FunctionBased;
6 6 
 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35
36 36 
         self::assertSame(
37 37 
             $expectedMessages,
38 
-            array_map(function (Change $change) : string {
38 
+            array_map(function(Change $change) : string {
39 39 
                 return $change->__toString();
40 40 
             }, iterator_to_array($changes))
41 41 
         );
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
             array_combine(
117 117 
                 array_keys($functions),
118 118 
                 array_map(
119 
-                    function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
119 
+                    function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
120 120 
                         return [
121 121 
                             $fromReflector->reflect($function),
122 122 
                             $toReflector->reflect($function),
Please login to merge, or discard this patch.
BackwardsCompatibility/FunctionBased/ReturnTypeCovarianceChangedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\FunctionBased;
6 6 
 
@@ -35,7 +35,7 @@  discard block
 
 block discarded – undo
35 35
36 36 
         self::assertSame(
37 37 
             $expectedMessages,
38 
-            array_map(function (Change $change) : string {
38 
+            array_map(function(Change $change) : string {
39 39 
                 return $change->__toString();
40 40 
             }, iterator_to_array($changes))
41 41 
         );
 
@@ -116,7 +116,7 @@  discard block
 
 block discarded – undo
116 116 
             array_combine(
117 117 
                 array_keys($functions),
118 118 
                 array_map(
119 
-                    function (string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
119 
+                    function(string $function, array $errorMessages) use ($fromReflector, $toReflector) : array {
120 120 
                         return [
121 121 
                             $fromReflector->reflect($function),
122 122 
                             $toReflector->reflect($function),
Please login to merge, or discard this patch.
BackwardsCompatibility/InterfaceBased/InterfaceBecameClassTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\InterfaceBased;
6 6 
 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29
30 30 
         self::assertSame(
31 31 
             $expectedMessages,
32 
-            array_map(function (Change $change) : string {
32 
+            array_map(function(Change $change) : string {
33 33 
                 return $change->__toString();
34 34 
             }, iterator_to_array($changes))
35 35 
         );
 
@@ -56,7 +56,7 @@  discard block
 
 block discarded – undo
56 56 
             ,
57 57 
             $locator
58 58 
         ));
59 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
59 
+        $toReflector = new ClassReflector(new StringSourceLocator(
60 60 
             <<<'PHP'
61 61 
 <?php
62 62 
 
@@ -89,7 +89,7 @@  discard block
 
 block discarded – undo
89 89 
         return array_combine(
90 90 
             array_keys($classes),
91 91 
             array_map(
92 
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
92 
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
93 93 
                     return [
94 94 
                         $fromReflector->reflect($className),
95 95 
                         $toReflector->reflect($className),
Please login to merge, or discard this patch.
BackwardsCompatibility/MethodBased/MethodConcretenessChangedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;
6 6 
 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34
35 35 
         self::assertSame(
36 36 
             $expectedMessages,
37 
-            array_map(function (Change $change) : string {
37 
+            array_map(function(Change $change) : string {
38 38 
                 return $change->__toString();
39 39 
             }, iterator_to_array($changes))
40 40 
         );
 
@@ -128,7 +128,7 @@  discard block
 
 block discarded – undo
128 128 
         return array_combine(
129 129 
             array_keys($properties),
130 130 
             array_map(
131 
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
131 
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
132 132 
                     return [
133 133 
                         $fromClass->getMethod($methodName),
134 134 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/MethodBased/MethodBecameFinalTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;
6 6 
 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34
35 35 
         self::assertSame(
36 36 
             $expectedMessages,
37 
-            array_map(function (Change $change) : string {
37 
+            array_map(function(Change $change) : string {
38 38 
                 return $change->__toString();
39 39 
             }, iterator_to_array($changes))
40 40 
         );
 
@@ -128,7 +128,7 @@  discard block
 
 block discarded – undo
128 128 
         return array_combine(
129 129 
             array_keys($properties),
130 130 
             array_map(
131 
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
131 
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
132 132 
                     return [
133 133 
                         $fromClass->getMethod($methodName),
134 134 
                         $toClass->getMethod($methodName),
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/ClassBased/ClassBecameInterfaceTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6 6 
 
@@ -30,7 +30,7 @@  discard block
 
 block discarded – undo
30 30
31 31 
         self::assertSame(
32 32 
             $expectedMessages,
33 
-            array_map(function (Change $change) : string {
33 
+            array_map(function(Change $change) : string {
34 34 
                 return $change->__toString();
35 35 
             }, iterator_to_array($changes))
36 36 
         );
 
@@ -57,7 +57,7 @@  discard block
 
 block discarded – undo
57 57 
             ,
58 58 
             $locator
59 59 
         ));
60 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
60 
+        $toReflector = new ClassReflector(new StringSourceLocator(
61 61 
             <<<'PHP'
62 62 
 <?php
63 63 
 
@@ -90,7 +90,7 @@  discard block
 
 block discarded – undo
90 90 
         return array_combine(
91 91 
             array_keys($classes),
92 92 
             array_map(
93 
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
93 
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
94 94 
                     return [
95 95 
                         $fromReflector->reflect($className),
96 96 
                         $toReflector->reflect($className),
Please login to merge, or discard this patch.
src/Comparator/BackwardsCompatibility/MethodBased/MethodBecameFinal.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;
6 6 
 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
 {
18 18 
     public function compare(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
19 19 
     {
20 
-        if ($fromMethod->isFinal() || ! $toMethod->isFinal()) {
20 
+        if ($fromMethod->isFinal() || !$toMethod->isFinal()) {
21 21 
             return Changes::new();
22 22 
         }
23 23
Please login to merge, or discard this patch.
Comparator/BackwardsCompatibility/MethodBased/MethodConcretenessChanged.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -1,6 +1,6 @@  discard block
 
 block discarded – undo
1 1 
 <?php
2 2
3 
-declare(strict_types=1);
3 
+declare(strict_types = 1);
4 4
5 5 
 namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;
6 6 
 
@@ -17,7 +17,7 @@  discard block
 
 block discarded – undo
17 17 
 {
18 18 
     public function compare(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
19 19 
     {
20 
-        if ($fromMethod->isAbstract() || ! $toMethod->isAbstract()) {
20 
+        if ($fromMethod->isAbstract() || !$toMethod->isAbstract()) {
21 21 
             return Changes::new();
22 22 
         }
23 23
Please login to merge, or discard this patch.