Completed
Pull Request — master (#34)
by Marco
02:42 queued 30s
created
src/Comparator/BackwardsCompatibility/ClassBased/ClassBased.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6 6
 
Please login to merge, or discard this patch.
src/Comparator/BackwardsCompatibility/ClassBased/PropertyRemoved.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6 6
 
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
             array_keys($this->accessibleProperties($toClass))
22 22
         );
23 23
 
24
-        return Changes::fromArray(array_values(array_map(function (string $property) use ($fromClass) : Change {
24
+        return Changes::fromArray(array_values(array_map(function(string $property) use ($fromClass) : Change {
25 25
             return Change::removed(
26 26
                 sprintf('Property %s#%s was removed', $fromClass->getName(), $property),
27 27
                 true
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
     /** @return ReflectionProperty[] */
33 33
     private function accessibleProperties(ReflectionClass $class) : array
34 34
     {
35
-        return array_filter($class->getProperties(), function (ReflectionProperty $property) : bool {
35
+        return array_filter($class->getProperties(), function(ReflectionProperty $property) : bool {
36 36
             return $property->isPublic() || $property->isProtected();
37 37
         });
38 38
     }
Please login to merge, or discard this patch.
unit/Comparator/BackwardsCompatibility/ClassBased/PropertyRemovedTest.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types=1);
3
+declare(strict_types = 1);
4 4
 
5 5
 namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6 6
 
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 
30 30
         self::assertSame(
31 31
             $expectedMessages,
32
-            array_map(function (Change $change) : string {
32
+            array_map(function(Change $change) : string {
33 33
                 return $change->__toString();
34 34
             }, iterator_to_array($changes))
35 35
         );
@@ -43,11 +43,11 @@  discard block
 block discarded – undo
43 43
         return [
44 44
             'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
45 45
                 (new ClassReflector(new SingleFileSourceLocator(
46
-                    __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
46
+                    __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
47 47
                     $locator
48 48
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
49 49
                 (new ClassReflector(new SingleFileSourceLocator(
50
-                    __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
50
+                    __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
51 51
                     $locator
52 52
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
53 53
                 [
Please login to merge, or discard this patch.
test/asset/api/new/ClassWithPropertiesBeingRemoved.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace RoaveTestAsset;
5 5
 
Please login to merge, or discard this patch.
test/asset/api/old/ClassWithPropertiesBeingRemoved.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace RoaveTestAsset;
5 5
 
Please login to merge, or discard this patch.
src/Command/ApiCompare.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace Roave\ApiCompare\Command;
5 5
 
@@ -117,21 +117,21 @@  discard block
 block discarded – undo
117 117
         $toRevision = $this->parseRevision->fromStringForRepository($input->getOption('to'), $sourceRepo);
118 118
         $sourcesPath = $input->getArgument('sources-path');
119 119
 
120
-        $output->writeln(sprintf('Comparing from %s to %s...', (string)$fromRevision, (string)$toRevision));
120
+        $output->writeln(sprintf('Comparing from %s to %s...', (string) $fromRevision, (string) $toRevision));
121 121
 
122 122
         $fromPath = $this->git->checkout($sourceRepo, $fromRevision);
123 123
         $toPath = $this->git->checkout($sourceRepo, $toRevision);
124 124
 
125 125
         try {
126
-            $fromSources = $fromPath . '/' . $sourcesPath;
127
-            $toSources   = $toPath . '/' . $sourcesPath;
126
+            $fromSources = $fromPath.'/'.$sourcesPath;
127
+            $toSources   = $toPath.'/'.$sourcesPath;
128 128
 
129 129
             Assert::that($fromSources)->directory();
130 130
             Assert::that($toSources)->directory();
131 131
 
132 132
             $changes = $this->comparator->compare(
133
-                $this->reflectorFactory->__invoke((string)$fromPath . '/' . $sourcesPath),
134
-                $this->reflectorFactory->__invoke((string)$toPath . '/' . $sourcesPath)
133
+                $this->reflectorFactory->__invoke((string) $fromPath.'/'.$sourcesPath),
134
+                $this->reflectorFactory->__invoke((string) $toPath.'/'.$sourcesPath)
135 135
             );
136 136
 
137 137
             (new SymfonyConsoleTextFormatter($output))->write($changes);
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
     private function parseRevisionFromInput(InputInterface $input, CheckedOutRepository $repository) : Revision
153 153
     {
154 154
         return $this->parseRevision->fromStringForRepository(
155
-            (string)$input->getOption('from'),
155
+            (string) $input->getOption('from'),
156 156
             $repository
157 157
         );
158 158
     }
Please login to merge, or discard this patch.
test/unit/Command/ApiCompareTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace RoaveTest\ApiCompare\Command;
5 5
 
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
 
57 57
     public function setUp() : void
58 58
     {
59
-        $this->sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__ . '/../../../'));
60
-        chdir((string)$this->sourceRepository);
59
+        $this->sourceRepository = CheckedOutRepository::fromPath(realpath(__DIR__.'/../../../'));
60
+        chdir((string) $this->sourceRepository);
61 61
 
62 62
         $this->input = $this->createMock(InputInterface::class);
63 63
         $this->output = $this->createMock(OutputInterface::class);
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
 
199 199
         $this->parseRevision->expects(self::at(0))
200 200
             ->method('fromStringForRepository')
201
-            ->with((string)$pickedVersion)
201
+            ->with((string) $pickedVersion)
202 202
             ->willReturn(Revision::fromSha1($fromSha));
203 203
         $this->parseRevision->expects(self::at(1))
204 204
             ->method('fromStringForRepository')
@@ -207,7 +207,7 @@  discard block
 block discarded – undo
207 207
 
208 208
         $this->getVersions->expects(self::once())
209 209
             ->method('fromRepository')
210
-            ->with(self::callback(function (CheckedOutRepository $checkedOutRepository) : bool {
210
+            ->with(self::callback(function(CheckedOutRepository $checkedOutRepository) : bool {
211 211
                 self::assertEquals($this->sourceRepository, $checkedOutRepository);
212 212
                 return true;
213 213
             }))
Please login to merge, or discard this patch.
test/asset/api/new/ClassWithMethodsBeingRemoved.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace RoaveTestAsset;
5 5
 
Please login to merge, or discard this patch.
test/asset/api/new/ClassWithPropertyVisibilitiesBeingChanged.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 
4 4
 namespace RoaveTestAsset;
5 5
 
Please login to merge, or discard this patch.