Inspection of "Merge pull request #121 from carusogabriel/task/bu..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aefb49...0e78db )

by Marco

created 2019-04-22 03:31 UTC

Status

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
+                static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getProperty($property),
                         $toClass->getProperty($property),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameFinalTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameInterfaceTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/PropertyChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
+            ->willReturnCallback(static function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(3))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
+            ->willReturnCallback(static function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
                 $methodName = $from->getName();
 
                 self::assertSame(strtolower($methodName), strtolower($to->getName()));

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameAbstractTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
+            ->willReturnCallback(static function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(static function (Change $change) : string {
	39	+ array_map(static function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -175,7 +175,7 @@ discard block
		block discarded – undo
175	175	return array_combine(
176	176	array_keys($properties),
177	177	array_map(
178		- static function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
	178	+ static function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
179	179	return [
180	180	$fromClass->getProperty($property),
181	181	$toClass->getProperty($property),

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(static function (Change $change) : string {
	39	+ array_map(static function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	,
67	67	$locator
68	68	));
69		- $toReflector = new ClassReflector(new StringSourceLocator(
	69	+ $toReflector = new ClassReflector(new StringSourceLocator(
70	70	<<<'PHP'
71	71	<?php
72	72
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105	return array_combine(
106	106	array_keys($classes),
107	107	array_map(
108		- static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	108	+ static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
109	109	return [
110	110	$fromReflector->reflect($className),
111	111	$toReflector->reflect($className),

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	self::assertSame(
33	33	$expectedMessages,
34		- array_map(static function (Change $change) : string {
	34	+ array_map(static function(Change $change) : string {
35	35	return $change->__toString();
36	36	}, iterator_to_array($changes))
37	37	);
		@@ -53,7 +53,7 @@ discard block
		block discarded – undo
53	53	,
54	54	$locator
55	55	));
56		- $toReflector = new ClassReflector(new StringSourceLocator(
	56	+ $toReflector = new ClassReflector(new StringSourceLocator(
57	57	<<<'PHP'
58	58	<?php
59	59

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(static function (Change $change) : string {
	36	+ array_map(static function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- static function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ static function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

		@@ -61,7 +61,7 @@
		block discarded – undo
61	61	$comparator
62	62	->expects(self::exactly(2))
63	63	->method('__invoke')
64		- ->willReturnCallback(static function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
	64	+ ->willReturnCallback(static function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
65	65	$propertyName = $from->getName();
66	66
67	67	self::assertSame($propertyName, $to->getName());

		@@ -62,7 +62,7 @@
		block discarded – undo
62	62	$comparator
63	63	->expects(self::exactly(3))
64	64	->method('__invoke')
65		- ->willReturnCallback(static function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
	65	+ ->willReturnCallback(static function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
66	66	$methodName = $from->getName();
67	67
68	68	self::assertSame(strtolower($methodName), strtolower($to->getName()));

Roave / BackwardCompatibilityCheck

Push — master ( aefb49...0e78db )

Status

Category

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch