Inspection of "Merge pull request #95 from Roave/feature/#96-phps..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ba85a6...34f627 )

by Marco

created 2018-08-21 10:57 UTC

Status

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -30,21 +30,21 @@  discard block
 block discarded – undo
         $this->output->writeln(
             "# Added\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                function (Change $change) : bool {
+                function(Change $change) : bool {
                     return $change->isAdded();
                 },
                 ...$arrayOfChanges
             ))
             . "\n# Changed\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                function (Change $change) : bool {
+                function(Change $change) : bool {
                     return $change->isChanged();
                 },
                 ...$arrayOfChanges
             ))
             . "\n# Removed\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                function (Change $change) : bool {
+                function(Change $change) : bool {
                     return $change->isRemoved();
                 },
                 ...$arrayOfChanges
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
     private function convertFilteredChangesToMarkdownBulletList(callable $filterFunction, Change ...$changes) : array
     {
         return array_map(
-            function (Change $change) : string {
-                return ' - ' . str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim((string) $change)) . "\n";
+            function(Change $change) : string {
+                return ' - '.str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim((string) $change))."\n";
             },
             array_filter($changes, $filterFunction)
         );

Please login to merge, or discard this patch.

src/Formatter/ReflectionFunctionAbstractName.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -13,12 +13,12 @@
 block discarded – undo
     {
         if ($function instanceof ReflectionMethod) {
             if ($function->isStatic()) {
-                return $function->getDeclaringClass()->getName() . '::' . $function->getName() . '()';
+                return $function->getDeclaringClass()->getName().'::'.$function->getName().'()';
             }
 
-            return $function->getDeclaringClass()->getName() . '#' . $function->getName() . '()';
+            return $function->getDeclaringClass()->getName().'#'.$function->getName().'()';
         }
 
-        return $function->getName() . '()';
+        return $function->getName().'()';
     }
 }

Please login to merge, or discard this patch.

vendor/composer/autoload_static.php 1 patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -6,40 +6,40 @@
 block discarded – undo
 
 class ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
 {
-    public static $prefixLengthsPsr4 = array (
+    public static $prefixLengthsPsr4 = array(
         'p' =>
-            array (
+            array(
                 'phpDocumentor\\Reflection\\' => 25,
             ),
     );
 
-    public static $prefixDirsPsr4 = array (
+    public static $prefixDirsPsr4 = array(
         'phpDocumentor\\Reflection\\' =>
-            array (
-                0 => __DIR__ . '/..' . '/phpdocumentor/reflection-common/src',
-                1 => __DIR__ . '/..' . '/phpdocumentor/reflection-docblock/src',
-                2 => __DIR__ . '/..' . '/phpdocumentor/type-resolver/src',
+            array(
+                0 => __DIR__.'/..'.'/phpdocumentor/reflection-common/src',
+                1 => __DIR__.'/..'.'/phpdocumentor/reflection-docblock/src',
+                2 => __DIR__.'/..'.'/phpdocumentor/type-resolver/src',
             ),
     );
 
-    public static $prefixesPsr0 = array (
+    public static $prefixesPsr0 = array(
         'P' =>
-            array (
+            array(
                 'Prophecy\\' =>
-                    array (
-                        0 => __DIR__ . '/..' . '/phpspec/prophecy/src',
+                    array(
+                        0 => __DIR__.'/..'.'/phpspec/prophecy/src',
                     ),
             ),
     );
 
-    public static $classMap = array (
-        'A\\ClassName' => __DIR__ . '/../..' . '/AClassName.php',
-        'B\\ClassName' => __DIR__ . '/../..' . '/BClassName.php',
+    public static $classMap = array(
+        'A\\ClassName' => __DIR__.'/../..'.'/AClassName.php',
+        'B\\ClassName' => __DIR__.'/../..'.'/BClassName.php',
     );
 
     public static function getInitializer(ClassLoader $loader)
     {
-        return \Closure::bind(function () use ($loader) {
+        return \Closure::bind(function() use ($loader) {
             $loader->prefixLengthsPsr4 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixLengthsPsr4;
             $loader->prefixDirsPsr4 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixDirsPsr4;
             $loader->prefixesPsr0 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixesPsr0;

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/MethodBased/MethodBecameFinalTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/MethodBased/MethodVisibilityReducedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $method, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $method, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($method),
                         $toClass->getMethod($method),

Please login to merge, or discard this patch.

unit/DetectChanges/BCBreak/MethodBased/MethodConcretenessChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/MethodBased/MethodScopeChangedTest.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -36,7 +36,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($properties),
             array_map(
-                function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
+                function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
                     return [
                         $fromClass->getMethod($methodName),
                         $toClass->getMethod($methodName),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameTraitTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameClassTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(function (Change $change) : string {
+            array_map(function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
             ,
             $locator
         ));
-        $toReflector   = new ClassReflector(new StringSourceLocator(
+        $toReflector = new ClassReflector(new StringSourceLocator(
             <<<'PHP'
 <?php
 
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
         return array_combine(
             array_keys($classes),
             array_map(
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
                     return [
                         $fromReflector->reflect($className),
                         $toReflector->reflect($className),

Please login to merge, or discard this patch.

		@@ -30,21 +30,21 @@ discard block
		block discarded – undo
30	30	$this->output->writeln(
31	31	"# Added\n"
32	32	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
33		- function (Change $change) : bool {
	33	+ function(Change $change) : bool {
34	34	return $change->isAdded();
35	35	},
36	36	...$arrayOfChanges
37	37	))
38	38	. "\n# Changed\n"
39	39	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
40		- function (Change $change) : bool {
	40	+ function(Change $change) : bool {
41	41	return $change->isChanged();
42	42	},
43	43	...$arrayOfChanges
44	44	))
45	45	. "\n# Removed\n"
46	46	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
47		- function (Change $change) : bool {
	47	+ function(Change $change) : bool {
48	48	return $change->isRemoved();
49	49	},
50	50	...$arrayOfChanges
		@@ -56,8 +56,8 @@ discard block
		block discarded – undo
56	56	private function convertFilteredChangesToMarkdownBulletList(callable $filterFunction, Change ...$changes) : array
57	57	{
58	58	return array_map(
59		- function (Change $change) : string {
60		- return ' - ' . str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim((string) $change)) . "\n";
	59	+ function(Change $change) : string {
	60	+ return ' - '.str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim((string) $change))."\n";
61	61	},
62	62	array_filter($changes, $filterFunction)
63	63	);

		@@ -13,12 +13,12 @@
		block discarded – undo
13	13	{
14	14	if ($function instanceof ReflectionMethod) {
15	15	if ($function->isStatic()) {
16		- return $function->getDeclaringClass()->getName() . '::' . $function->getName() . '()';
	16	+ return $function->getDeclaringClass()->getName().'::'.$function->getName().'()';
17	17	}
18	18
19		- return $function->getDeclaringClass()->getName() . '#' . $function->getName() . '()';
	19	+ return $function->getDeclaringClass()->getName().'#'.$function->getName().'()';
20	20	}
21	21
22		- return $function->getName() . '()';
	22	+ return $function->getName().'()';
23	23	}
24	24	}

		@@ -6,40 +6,40 @@
		block discarded – undo
6	6
7	7	class ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
8	8	{
9		- public static $prefixLengthsPsr4 = array (
	9	+ public static $prefixLengthsPsr4 = array(
10	10	'p' =>
11		- array (
	11	+ array(
12	12	'phpDocumentor\\Reflection\\' => 25,
13	13	),
14	14	);
15	15
16		- public static $prefixDirsPsr4 = array (
	16	+ public static $prefixDirsPsr4 = array(
17	17	'phpDocumentor\\Reflection\\' =>
18		- array (
19		- 0 => __DIR__ . '/..' . '/phpdocumentor/reflection-common/src',
20		- 1 => __DIR__ . '/..' . '/phpdocumentor/reflection-docblock/src',
21		- 2 => __DIR__ . '/..' . '/phpdocumentor/type-resolver/src',
	18	+ array(
	19	+ 0 => __DIR__.'/..'.'/phpdocumentor/reflection-common/src',
	20	+ 1 => __DIR__.'/..'.'/phpdocumentor/reflection-docblock/src',
	21	+ 2 => __DIR__.'/..'.'/phpdocumentor/type-resolver/src',
22	22	),
23	23	);
24	24
25		- public static $prefixesPsr0 = array (
	25	+ public static $prefixesPsr0 = array(
26	26	'P' =>
27		- array (
	27	+ array(
28	28	'Prophecy\\' =>
29		- array (
30		- 0 => __DIR__ . '/..' . '/phpspec/prophecy/src',
	29	+ array(
	30	+ 0 => __DIR__.'/..'.'/phpspec/prophecy/src',
31	31	),
32	32	),
33	33	);
34	34
35		- public static $classMap = array (
36		- 'A\\ClassName' => __DIR__ . '/../..' . '/AClassName.php',
37		- 'B\\ClassName' => __DIR__ . '/../..' . '/BClassName.php',
	35	+ public static $classMap = array(
	36	+ 'A\\ClassName' => __DIR__.'/../..'.'/AClassName.php',
	37	+ 'B\\ClassName' => __DIR__.'/../..'.'/BClassName.php',
38	38	);
39	39
40	40	public static function getInitializer(ClassLoader $loader)
41	41	{
42		- return \Closure::bind(function () use ($loader) {
	42	+ return \Closure::bind(function() use ($loader) {
43	43	$loader->prefixLengthsPsr4 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixLengthsPsr4;
44	44	$loader->prefixDirsPsr4 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixDirsPsr4;
45	45	$loader->prefixesPsr0 = ComposerStaticInitaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa::$prefixesPsr0;

		@@ -36,7 +36,7 @@ discard block
		block discarded – undo
36	36
37	37	self::assertSame(
38	38	$expectedMessages,
39		- array_map(function (Change $change) : string {
	39	+ array_map(function(Change $change) : string {
40	40	return $change->__toString();
41	41	}, iterator_to_array($changes))
42	42	);
		@@ -122,7 +122,7 @@ discard block
		block discarded – undo
122	122	return array_combine(
123	123	array_keys($properties),
124	124	array_map(
125		- function (string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
	125	+ function(string $methodName, array $errorMessages) use ($fromClass, $toClass) : array {
126	126	return [
127	127	$fromClass->getMethod($methodName),
128	128	$toClass->getMethod($methodName),

		@@ -33,7 +33,7 @@ discard block
		block discarded – undo
33	33
34	34	self::assertSame(
35	35	$expectedMessages,
36		- array_map(function (Change $change) : string {
	36	+ array_map(function(Change $change) : string {
37	37	return $change->__toString();
38	38	}, iterator_to_array($changes))
39	39	);
		@@ -63,7 +63,7 @@ discard block
		block discarded – undo
63	63	,
64	64	$locator
65	65	));
66		- $toReflector = new ClassReflector(new StringSourceLocator(
	66	+ $toReflector = new ClassReflector(new StringSourceLocator(
67	67	<<<'PHP'
68	68	<?php
69	69
		@@ -102,7 +102,7 @@ discard block
		block discarded – undo
102	102	return array_combine(
103	103	array_keys($classes),
104	104	array_map(
105		- function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
	105	+ function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106	106	return [
107	107	$fromReflector->reflect($className),
108	108	$toReflector->reflect($className),

Roave / BackwardCompatibilityCheck

Push — master ( ba85a6...34f627 )

Status

Category

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +15 added lines, -15 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch