View GitHub Repository BackwardCompatibilityCheck

Schedule Inspection
Subscribe
Completed
Pull Request — master (#69)
by Ben
06:51
created
Status
Category
Toggle Patches
test/unit/DetectChanges/BCBreak/InterfaceBased/InterfaceBecameClassTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33
34 34 
         self::assertSame(
35 35 
             $expectedMessages,
36 
-            array_map(function (Change $change) : string {
36 
+            array_map(function(Change $change) : string {
37 37 
                 return $change->__toString();
38 38 
             }, iterator_to_array($changes))
39 39 
         );
 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
             ,
64 64 
             $locator
65 65 
         ));
66 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
66 
+        $toReflector = new ClassReflector(new StringSourceLocator(
67 67 
             <<<'PHP'
68 68 
 <?php
69 69 
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
         return array_combine(
103 103 
             array_keys($classes),
104 104 
             array_map(
105 
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
105 
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106 106 
                     return [
107 107 
                         $fromReflector->reflect($className),
108 108 
                         $toReflector->reflect($className),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/InterfaceBased/MethodAddedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33
34 34 
         self::assertSame(
35 35 
             $expectedMessages,
36 
-            array_map(function (Change $change) : string {
36 
+            array_map(function(Change $change) : string {
37 37 
                 return $change->__toString();
38 38 
             }, iterator_to_array($changes))
39 39 
         );
 
@@ -106,7 +106,7 @@  discard block
 
 block discarded – undo
106 106 
         return array_combine(
107 107 
             array_keys($properties),
108 108 
             array_map(
109 
-                function (string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
109 
+                function(string $className, array $errorMessages) use ($fromClassReflector, $toClassReflector
110 110 
                 ) : array {
111 111 
                     return [
112 112 
                         $fromClassReflector->reflect($className),
Please login to merge, or discard this patch.
BCBreak/ClassConstantBased/ClassConstantVisibilityReducedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34
35 35 
         self::assertSame(
36 36 
             $expectedMessages,
37 
-            array_map(function (Change $change) : string {
37 
+            array_map(function(Change $change) : string {
38 38 
                 return $change->__toString();
39 39 
             }, iterator_to_array($changes))
40 40 
         );
 
@@ -112,7 +112,7 @@  discard block
 
 block discarded – undo
112 112 
         return array_combine(
113 113 
             array_keys($properties),
114 114 
             array_map(
115 
-                function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
115 
+                function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
116 116 
                     return [
117 117 
                         $fromClass->getReflectionConstant($constant),
118 118 
                         $toClass->getReflectionConstant($constant),
Please login to merge, or discard this patch.
DetectChanges/BCBreak/ClassConstantBased/ClassConstantValueChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -34,7 +34,7 @@  discard block
 
 block discarded – undo
34 34
35 35 
         self::assertSame(
36 36 
             $expectedMessages,
37 
-            array_map(function (Change $change) : string {
37 
+            array_map(function(Change $change) : string {
38 38 
                 return $change->__toString();
39 39 
             }, iterator_to_array($changes))
40 40 
         );
 
@@ -112,7 +112,7 @@  discard block
 
 block discarded – undo
112 112 
         return array_combine(
113 113 
             array_keys($properties),
114 114 
             array_map(
115 
-                function (string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
115 
+                function(string $constant, array $errorMessages) use ($fromClass, $toClass) : array {
116 116 
                     return [
117 117 
                         $fromClass->getReflectionConstant($constant),
118 118 
                         $toClass->getReflectionConstant($constant),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/ClassBased/ClassBecameFinalTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31
32 32 
         self::assertSame(
33 33 
             $expectedMessages,
34 
-            array_map(function (Change $change) : string {
34 
+            array_map(function(Change $change) : string {
35 35 
                 return $change->__toString();
36 36 
             }, iterator_to_array($changes))
37 37 
         );
 
@@ -53,7 +53,7 @@  discard block
 
 block discarded – undo
53 53 
             ,
54 54 
             $locator
55 55 
         ));
56 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
56 
+        $toReflector = new ClassReflector(new StringSourceLocator(
57 57 
             <<<'PHP'
58 58 
 <?php
59 59
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/ClassBased/ConstantRemovedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -29,7 +29,7 @@  discard block
 
 block discarded – undo
29 29
30 30 
         self::assertSame(
31 31 
             $expectedMessages,
32 
-            array_map(function (Change $change) : string {
32 
+            array_map(function(Change $change) : string {
33 33 
                 return $change->__toString();
34 34 
             }, iterator_to_array($changes))
35 35 
         );
 
@@ -43,11 +43,11 @@  discard block
 
 block discarded – undo
43 43 
         return [
44 44 
             'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
45 45 
                 (new ClassReflector(new SingleFileSourceLocator(
46 
-                    __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
46 
+                    __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
47 47 
                     $locator
48 48 
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
49 49 
                 (new ClassReflector(new SingleFileSourceLocator(
50 
-                    __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
50 
+                    __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
51 51 
                     $locator
52 52 
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
53 53 
                 [
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/ClassBased/PropertyRemovedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31
32 32 
         self::assertSame(
33 33 
             $expectedMessages,
34 
-            array_map(function (Change $change) : string {
34 
+            array_map(function(Change $change) : string {
35 35 
                 return $change->__toString();
36 36 
             }, iterator_to_array($changes))
37 37 
         );
 
@@ -45,11 +45,11 @@  discard block
 
 block discarded – undo
45 45 
         return [
46 46 
             'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
47 47 
                 (new ClassReflector(new SingleFileSourceLocator(
48 
-                    __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
48 
+                    __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
49 49 
                     $locator
50 50 
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
51 51 
                 (new ClassReflector(new SingleFileSourceLocator(
52 
-                    __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
52 
+                    __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
53 53 
                     $locator
54 54 
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
55 55 
                 [
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/ClassBased/MethodRemovedTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -31,7 +31,7 @@  discard block
 
 block discarded – undo
31 31
32 32 
         self::assertSame(
33 33 
             $expectedMessages,
34 
-            array_map(function (Change $change) : string {
34 
+            array_map(function(Change $change) : string {
35 35 
                 return $change->__toString();
36 36 
             }, iterator_to_array($changes))
37 37 
         );
 
@@ -45,11 +45,11 @@  discard block
 
 block discarded – undo
45 45 
         return [
46 46 
             'RoaveTestAsset\\ClassWithMethodsBeingRemoved' => [
47 47 
                 (new ClassReflector(new SingleFileSourceLocator(
48 
-                    __DIR__ . '/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
48 
+                    __DIR__.'/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
49 49 
                     $locator
50 50 
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
51 51 
                 (new ClassReflector(new SingleFileSourceLocator(
52 
-                    __DIR__ . '/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
52 
+                    __DIR__.'/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
53 53 
                     $locator
54 54 
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
55 55 
                 [
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/ClassBased/ConstantChangedTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -60,7 +60,7 @@
 
 block discarded – undo
60 60 
         $comparator
61 61 
             ->expects(self::exactly(2))
62 62 
             ->method('__invoke')
63 
-            ->willReturnCallback(function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
63 
+            ->willReturnCallback(function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
64 64 
                 $propertyName = $from->getName();
65 65
66 66 
                 self::assertSame($propertyName, $to->getName());
Please login to merge, or discard this patch.