MethodScopeChanged::compare() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-17 13:58 UTC

MethodScopeChanged::compare() A

↳ Parent: MethodScopeChanged

Complexity

Conditions	3
Paths	3

Size

Total Lines	22
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.2
c	0
b	0
f	0
cc	3
eloc	14
nc	3
nop	2

<?php

declare(strict_types=1);

namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;

use Roave\ApiCompare\Change;
use Roave\ApiCompare\Changes;
use Roave\BetterReflection\Reflection\ReflectionMethod;
use function sprintf;

/**
 * A method that changes from instance to static or the opposite has to be called differently,
 * so any of such changes are to be considered BC breaks
 */
final class MethodScopeChanged implements MethodBased
{
    public function compare(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
    {
        if ($fromMethod->isPrivate()) {
            return Changes::new();
        }

        $scopeFrom = $this->methodScope($fromMethod);
        $scopeTo   = $this->methodScope($toMethod);

        if ($scopeFrom === $scopeTo) {
            return Changes::new();
        }

        return Changes::fromArray([Change::changed(
            sprintf(
                'Method %s() of class %s changed scope from %s to %s',
                $fromMethod->getName(),
                $fromMethod->getDeclaringClass()->getName(),
                $scopeFrom,
                $scopeTo
            ),
            true
        )]);
    }

    private function methodScope(ReflectionMethod $method) : string
    {
        return $method->isStatic() ? 'static' : 'instance';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;
6
7			use Roave\ApiCompare\Change;
8			use Roave\ApiCompare\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionMethod;
10			use function sprintf;
11
12			/**
13			* A method that changes from instance to static or the opposite has to be called differently,
14			* so any of such changes are to be considered BC breaks
15			*/
16			final class MethodScopeChanged implements MethodBased
17			{
18			public function compare(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
19			{
20			if ($fromMethod->isPrivate()) {
21			return Changes::new();
22			}
23
24			$scopeFrom = $this->methodScope($fromMethod);
25			$scopeTo = $this->methodScope($toMethod);
26
27			if ($scopeFrom === $scopeTo) {
28			return Changes::new();
29			}
30
31			return Changes::fromArray([Change::changed(
32			sprintf(
33			'Method %s() of class %s changed scope from %s to %s',
34			$fromMethod->getName(),
35			$fromMethod->getDeclaringClass()->getName(),
36			$scopeFrom,
37			$scopeTo
38			),
39			true
40			)]);
41			}
42
43			private function methodScope(ReflectionMethod $method) : string
44			{
45			return $method->isStatic() ? 'static' : 'instance';
46			}
47			}
48

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

MethodScopeChanged::compare() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like