RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\MethodBased\MethodVisibilityReducedTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	104
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	testDiffs()	0	13	1
B	propertiesToBeTested()	0	80	1

<?php

declare(strict_types=1);

namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\MethodBased;

use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased\MethodVisibilityReduced;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionMethod;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use function array_map;
use function iterator_to_array;

/**
 * @covers \Roave\ApiCompare\Comparator\BackwardsCompatibility\MethodBased\MethodVisibilityReduced
 */
final class MethodVisibilityReducedTest extends TestCase
{
    /**
     * @dataProvider propertiesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionMethod $fromMethod,
        ReflectionMethod $toMethod,
        array $expectedMessages
    ) : void {
        $changes = (new MethodVisibilityReduced())
            ->compare($fromMethod, $toMethod);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionMethod)[][] */
    public function propertiesToBeTested() : array
    {
        $astLocator = (new BetterReflection())->astLocator();

        $fromLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public function publicMaintainedPublic() {}
    public function publicReducedToProtected() {}
    public function publicReducedToPrivate() {}
    protected function protectedMaintainedProtected() {}
    protected function protectedReducedToPrivate() {}
    protected function protectedIncreasedToPublic() {}
    private function privateMaintainedPrivate() {}
    private function privateIncreasedToProtected() {}
    private function privateIncreasedToPublic() {}
}
PHP
            ,
            $astLocator
        );

        $toLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public function publicMaintainedPublic() {}
    protected function publicReducedToProtected() {}
    private function publicReducedToPrivate() {}
    protected function protectedMaintainedProtected() {}
    private function protectedReducedToPrivate() {}
    public function protectedIncreasedToPublic() {}
    private function privateMaintainedPrivate() {}
    protected function privateIncreasedToProtected() {}
    public function privateIncreasedToPublic() {}
}
PHP
            ,
            $astLocator
        );

        $fromClassReflector = new ClassReflector($fromLocator);
        $toClassReflector   = new ClassReflector($toLocator);
        $fromClass          = $fromClassReflector->reflect('TheClass');
        $toClass            = $toClassReflector->reflect('TheClass');

        $properties = [

            'publicMaintainedPublic'       => [],
            'publicReducedToProtected'     => [
                '[BC] CHANGED: Method publicReducedToProtected() of class TheClass visibility reduced from public to protected',
            ],
            'publicReducedToPrivate'       => [
                '[BC] CHANGED: Method publicReducedToPrivate() of class TheClass visibility reduced from public to private',
            ],
            'protectedMaintainedProtected' => [],
            'protectedReducedToPrivate'    => [
                '[BC] CHANGED: Method protectedReducedToPrivate() of class TheClass visibility reduced from protected to private',
            ],
            'protectedIncreasedToPublic'   => [],
            'privateMaintainedPrivate'     => [],
            'privateIncreasedToProtected'  => [],
            'privateIncreasedToPublic'     => [],
        ];

        return array_combine(
            array_keys($properties),
            array_map(
                function (string $method, array $errorMessages) use ($fromClass, $toClass) : array {
                    return [
                        $fromClass->getMethod($method),

The method getMethod() does not exist on Roave\BetterReflection\Reflection\Reflection. It seems like you code against a sub-type of Roave\BetterReflection\Reflection\Reflection such as Roave\BetterReflection\Reflection\ReflectionClass.

                        $toClass->getMethod($method),
                        $errorMessages,
                    ];
                },
                array_keys($properties),
                $properties
            )
        );
    }
}