ClassBecameInterfaceTest::classesToBeTested() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-18 11:00 UTC

ClassBecameInterfaceTest::classesToBeTested() A

↳ Parent: ClassBecameInterfaceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	62
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	62
rs	9.4743
c	0
b	0
f	0
eloc	31
nc	1
nop	0
cc	1

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;

use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased\ClassBecameAbstract;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased\ClassBecameInterface;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionClass;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;

final class ClassBecameInterfaceTest extends TestCase
{
    /**
     * @dataProvider classesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionClass $fromClass,
        ReflectionClass $toClass,
        array $expectedMessages
    ) : void {
        $changes = (new ClassBecameInterface())
            ->compare($fromClass, $toClass);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionClass)[][] */
    public function classesToBeTested() : array
    {
        $locator       = (new BetterReflection())->astLocator();
        $fromReflector = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

class ConcreteToAbstract {}
abstract class AbstractToConcrete {}
class ConcreteToConcrete {}
abstract class AbstractToAbstract {}
class ConcreteToInterface {}
interface InterfaceToConcrete {}
interface InterfaceToInterface {}
interface InterfaceToAbstract {}
abstract class AbstractToInterface {}
PHP
            ,
            $locator
        ));
        $toReflector   = new ClassReflector(new StringSourceLocator(
            <<<'PHP'
<?php

abstract class ConcreteToAbstract {}
class AbstractToConcrete {}
class ConcreteToConcrete {}
abstract class AbstractToAbstract {}
interface ConcreteToInterface {}
class InterfaceToConcrete {}
interface InterfaceToInterface {}
abstract class InterfaceToAbstract {}
interface AbstractToInterface {}
PHP
            ,
            $locator
        ));

        $classes = [
            'ConcreteToAbstract'   => [],
            'AbstractToConcrete'   => [],
            'ConcreteToConcrete'   => [],
            'AbstractToAbstract'   => [],
            'ConcreteToInterface'  => ['[BC] CHANGED: Class ConcreteToInterface became an interface'],
            'InterfaceToConcrete'  => [],
            'InterfaceToInterface' => [],
            'InterfaceToAbstract'  => [],
            'AbstractToInterface'  => ['[BC] CHANGED: Class AbstractToInterface became an interface'],
        ];

        return array_combine(
            array_keys($classes),
            array_map(
                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
                    return [
                        $fromReflector->reflect($className),
                        $toReflector->reflect($className),
                        $errors,
                    ];
                },
                array_keys($classes),
                $classes
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\ClassBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\ApiCompare\Change;
9			use Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased\ClassBecameAbstract;
10			use Roave\ApiCompare\Comparator\BackwardsCompatibility\ClassBased\ClassBecameInterface;
11			use Roave\BetterReflection\BetterReflection;
12			use Roave\BetterReflection\Reflection\ReflectionClass;
13			use Roave\BetterReflection\Reflector\ClassReflector;
14			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
15
16			final class ClassBecameInterfaceTest extends TestCase
17			{
18			/**
19			* @dataProvider classesToBeTested
20			*
21			* @param string[] $expectedMessages
22			*/
23			public function testDiffs(
24			ReflectionClass $fromClass,
25			ReflectionClass $toClass,
26			array $expectedMessages
27			) : void {
28			$changes = (new ClassBecameInterface())
29			->compare($fromClass, $toClass);
30
31			self::assertSame(
32			$expectedMessages,
33			array_map(function (Change $change) : string {
34			return $change->__toString();
35			}, iterator_to_array($changes))
36			);
37			}
38
39			/** @return (string[]\|ReflectionClass)[][] */
40			public function classesToBeTested() : array
41			{
42			$locator = (new BetterReflection())->astLocator();
43			$fromReflector = new ClassReflector(new StringSourceLocator(
44			<<<'PHP'
45			<?php
46
47			class ConcreteToAbstract {}
48			abstract class AbstractToConcrete {}
49			class ConcreteToConcrete {}
50			abstract class AbstractToAbstract {}
51			class ConcreteToInterface {}
52			interface InterfaceToConcrete {}
53			interface InterfaceToInterface {}
54			interface InterfaceToAbstract {}
55			abstract class AbstractToInterface {}
56			PHP
57			,
58			$locator
59			));
60			$toReflector = new ClassReflector(new StringSourceLocator(
61			<<<'PHP'
62			<?php
63
64			abstract class ConcreteToAbstract {}
65			class AbstractToConcrete {}
66			class ConcreteToConcrete {}
67			abstract class AbstractToAbstract {}
68			interface ConcreteToInterface {}
69			class InterfaceToConcrete {}
70			interface InterfaceToInterface {}
71			abstract class InterfaceToAbstract {}
72			interface AbstractToInterface {}
73			PHP
74			,
75			$locator
76			));
77
78			$classes = [
79			'ConcreteToAbstract' => [],
80			'AbstractToConcrete' => [],
81			'ConcreteToConcrete' => [],
82			'AbstractToAbstract' => [],
83			'ConcreteToInterface' => ['[BC] CHANGED: Class ConcreteToInterface became an interface'],
84			'InterfaceToConcrete' => [],
85			'InterfaceToInterface' => [],
86			'InterfaceToAbstract' => [],
87			'AbstractToInterface' => ['[BC] CHANGED: Class AbstractToInterface became an interface'],
88			];
89
90			return array_combine(
91			array_keys($classes),
92			array_map(
93			function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
94			return [
95			$fromReflector->reflect($className),
96			$toReflector->reflect($className),
97			$errors,
98			];
99			},
100			array_keys($classes),
101			$classes
102			)
103			);
104			}
105			}
106

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

ClassBecameInterfaceTest::classesToBeTested() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like