The expression $newMethods of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an
empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using empty(..) or !empty(...) instead.
Loading history...
21
return Changes::new();
22
}
23
24
return Changes::fromArray(array_values(array_map(function (ReflectionMethod $method) use (
25
$fromInterface
26
) : Change {
27
return Change::added(
28
sprintf(
29
'Method %s() was added to interface %s',
30
$method->getName(),
31
$fromInterface->getName()
32
),
33
true
34
);
35
}, $newMethods)));
36
}
37
38
/** @return ReflectionMethod[] indexed by lowercase method name */
39
private function methods(ReflectionClass $interface) : array
Roave /
BackwardCompatibilityCheck
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.