Inspection of "Do not skip cleanup when deploying" - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#198)

by Marco

created 2020-02-08 18:44 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
+            ->willReturnCallback(static function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(3))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
+            ->willReturnCallback(static function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
                 $methodName = $from->getName();
 
                 self::assertSame(strtolower($methodName), strtolower($to->getName()));

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/ConstantChangedTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -61,7 +61,7 @@
 block discarded – undo
         $comparator
             ->expects(self::exactly(2))
             ->method('__invoke')
-            ->willReturnCallback(static function (ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
+            ->willReturnCallback(static function(ReflectionClassConstant $from, ReflectionClassConstant $to) : Changes {
                 $propertyName = $from->getName();
 
                 self::assertSame($propertyName, $to->getName());

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/MethodRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithMethodsBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithMethodsBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithMethodsBeingRemoved'),
                 [

Please login to merge, or discard this patch.

test/unit/DetectChanges/BCBreak/ClassBased/PropertyRemovedTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -31,7 +31,7 @@  discard block
 block discarded – undo
 
         self::assertSame(
             $expectedMessages,
-            array_map(static function (Change $change) : string {
+            array_map(static function(Change $change) : string {
                 return $change->__toString();
             }, iterator_to_array($changes))
         );
@@ -45,11 +45,11 @@  discard block
 block discarded – undo
         return [
             'RoaveTestAsset\\ClassWithPropertiesBeingRemoved' => [
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/old/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 (new ClassReflector(new SingleFileSourceLocator(
-                    __DIR__ . '/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
+                    __DIR__.'/../../../../asset/api/new/ClassWithPropertiesBeingRemoved.php',
                     $locator
                 )))->reflect('RoaveTestAsset\\ClassWithPropertiesBeingRemoved'),
                 [

Please login to merge, or discard this patch.

src/Git/GetVersionCollectionFromGitRepository.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -32,7 +32,7 @@
 block discarded – undo
             ->getOutput();
 
         return new VersionsCollection(...array_filter(
-            array_map(static function (string $maybeVersion) : ?Version {
+            array_map(static function(string $maybeVersion) : ?Version {
                 try {
                     return Version::fromString($maybeVersion);
                 } catch (InvalidVersionStringException $e) {

Please login to merge, or discard this patch.

src/Formatter/MarkdownPipedToSymfonyConsoleFormatter.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -31,21 +31,21 @@  discard block
 block discarded – undo
         $this->output->writeln(
             "# Added\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                static function (Change $change) : bool {
+                static function(Change $change) : bool {
                     return $change->isAdded();
                 },
                 ...$arrayOfChanges
             ))
             . "\n# Changed\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                static function (Change $change) : bool {
+                static function(Change $change) : bool {
                     return $change->isChanged();
                 },
                 ...$arrayOfChanges
             ))
             . "\n# Removed\n"
             . implode('', $this->convertFilteredChangesToMarkdownBulletList(
-                static function (Change $change) : bool {
+                static function(Change $change) : bool {
                     return $change->isRemoved();
                 },
                 ...$arrayOfChanges
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
     private function convertFilteredChangesToMarkdownBulletList(callable $filterFunction, Change ...$changes) : array
     {
         return array_map(
-            static function (Change $change) : string {
-                return ' - ' . str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim($change->__toString())) . "\n";
+            static function(Change $change) : string {
+                return ' - '.str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim($change->__toString()))."\n";
             },
             array_filter($changes, $filterFunction)
         );

Please login to merge, or discard this patch.

src/DetectChanges/BCBreak/ClassBased/MethodChanged.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -49,7 +49,7 @@
 block discarded – undo
         $methods = $class->getMethods();
 
         return array_combine(
-            array_map(static function (ReflectionMethod $method) : string {
+            array_map(static function(ReflectionMethod $method) : string {
                 return strtolower($method->getName());
             }, $methods),
             $methods

Please login to merge, or discard this patch.

		@@ -62,7 +62,7 @@
		block discarded – undo
62	62	$comparator
63	63	->expects(self::exactly(3))
64	64	->method('__invoke')
65		- ->willReturnCallback(static function (ReflectionMethod $from, ReflectionMethod $to) : Changes {
	65	+ ->willReturnCallback(static function(ReflectionMethod $from, ReflectionMethod $to) : Changes {
66	66	$methodName = $from->getName();
67	67
68	68	self::assertSame(strtolower($methodName), strtolower($to->getName()));

		@@ -32,7 +32,7 @@
		block discarded – undo
32	32	->getOutput();
33	33
34	34	return new VersionsCollection(...array_filter(
35		- array_map(static function (string $maybeVersion) : ?Version {
	35	+ array_map(static function(string $maybeVersion) : ?Version {
36	36	try {
37	37	return Version::fromString($maybeVersion);
38	38	} catch (InvalidVersionStringException $e) {

		@@ -49,7 +49,7 @@
		block discarded – undo
49	49	$methods = $class->getMethods();
50	50
51	51	return array_combine(
52		- array_map(static function (ReflectionMethod $method) : string {
	52	+ array_map(static function(ReflectionMethod $method) : string {
53	53	return strtolower($method->getName());
54	54	}, $methods),
55	55	$methods

		@@ -61,7 +61,7 @@
		block discarded – undo
61	61	$comparator
62	62	->expects(self::exactly(2))
63	63	->method('__invoke')
64		- ->willReturnCallback(static function (ReflectionProperty $from, ReflectionProperty $to) : Changes {
	64	+ ->willReturnCallback(static function(ReflectionProperty $from, ReflectionProperty $to) : Changes {
65	65	$propertyName = $from->getName();
66	66
67	67	self::assertSame($propertyName, $to->getName());

		@@ -31,7 +31,7 @@ discard block
		block discarded – undo
31	31
32	32	self::assertSame(
33	33	$expectedMessages,
34		- array_map(static function (Change $change) : string {
	34	+ array_map(static function(Change $change) : string {
35	35	return $change->__toString();
36	36	}, iterator_to_array($changes))
37	37	);
		@@ -45,11 +45,11 @@ discard block
		block discarded – undo
45	45	return [
46	46	'RoaveTestAsset\\ClassWithConstantsBeingRemoved' => [
47	47	(new ClassReflector(new SingleFileSourceLocator(
48		- __DIR__ . '/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
	48	+ __DIR__.'/../../../../asset/api/old/ClassWithConstantsBeingRemoved.php',
49	49	$locator
50	50	)))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
51	51	(new ClassReflector(new SingleFileSourceLocator(
52		- __DIR__ . '/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
	52	+ __DIR__.'/../../../../asset/api/new/ClassWithConstantsBeingRemoved.php',
53	53	$locator
54	54	)))->reflect('RoaveTestAsset\\ClassWithConstantsBeingRemoved'),
55	55	[

		@@ -31,21 +31,21 @@ discard block
		block discarded – undo
31	31	$this->output->writeln(
32	32	"# Added\n"
33	33	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
34		- static function (Change $change) : bool {
	34	+ static function(Change $change) : bool {
35	35	return $change->isAdded();
36	36	},
37	37	...$arrayOfChanges
38	38	))
39	39	. "\n# Changed\n"
40	40	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
41		- static function (Change $change) : bool {
	41	+ static function(Change $change) : bool {
42	42	return $change->isChanged();
43	43	},
44	44	...$arrayOfChanges
45	45	))
46	46	. "\n# Removed\n"
47	47	. implode('', $this->convertFilteredChangesToMarkdownBulletList(
48		- static function (Change $change) : bool {
	48	+ static function(Change $change) : bool {
49	49	return $change->isRemoved();
50	50	},
51	51	...$arrayOfChanges
		@@ -57,8 +57,8 @@ discard block
		block discarded – undo
57	57	private function convertFilteredChangesToMarkdownBulletList(callable $filterFunction, Change ...$changes) : array
58	58	{
59	59	return array_map(
60		- static function (Change $change) : string {
61		- return ' - ' . str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim($change->__toString())) . "\n";
	60	+ static function(Change $change) : string {
	61	+ return ' - '.str_replace(['ADDED: ', 'CHANGED: ', 'REMOVED: '], '', trim($change->__toString()))."\n";
62	62	},
63	63	array_filter($changes, $filterFunction)
64	64	);

Roave / BackwardCompatibilityCheck

Pull Request — master (#198)

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch