PropertyDefaultValueChangedTest::propertiesToBeTested() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-18 15:21 UTC

propertiesToBeTested() B

↳ Parent: PropertyDefaultValueChangedTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	104
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	104
rs	8.2857
c	0
b	0
f	0
cc	1
eloc	44
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;

use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionProperty;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use function array_combine;
use function array_keys;
use function array_map;
use function iterator_to_array;

/**
 * @covers \Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged
 */
final class PropertyDefaultValueChangedTest extends TestCase
{
    /**
     * @dataProvider propertiesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionProperty $fromFunction,
        ReflectionProperty $toFunction,
        array $expectedMessages
    ) : void {
        $changes = (new PropertyDefaultValueChanged())
            ->compare($fromFunction, $toFunction);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionProperty)[][] */
    public function propertiesToBeTested() : array
    {
        $astLocator = (new BetterReflection())->astLocator();

        $fromLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public $publicNothingToNothing;
    public $publicNothingToNull;
    public $publicNullToNull = null;
    public $publicValueChanged = 1;
    public $publicValueToSimilarValue = '1';
    public $publicExpressionToExpressionValue = 101 + 5;
    
    protected $protectedNothingToNothing;
    protected $protectedNothingToNull;
    protected $protectedNullToNull = null;
    protected $protectedValueChanged = 1;
    protected $protectedValueToSimilarValue = '1';
    protected $protectedExpressionToExpressionValue = 101 + 5;
    
    private $privateNothingToNothing;
    private $privateNothingToNull;
    private $privateNullToNull = null;
    private $privateValueChanged = 1;
    private $privateValueToSimilarValue = '1';
    private $privateExpressionToExpressionValue = 101 + 5;
}
PHP
            ,
            $astLocator
        );

        $toLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public $publicNothingToNothing;
    public $publicNothingToNull = null;
    public $publicNullToNull = null;
    public $publicValueChanged = 2;
    public $publicValueToSimilarValue = 1;
    public $publicExpressionToExpressionValue = 106;
    
    protected $protectedNothingToNothing;
    protected $protectedNothingToNull = null;
    protected $protectedNullToNull = null;
    protected $protectedValueChanged = 2;
    protected $protectedValueToSimilarValue = 1;
    protected $protectedExpressionToExpressionValue = 106;
    
    private $privateNothingToNothing;
    private $privateNothingToNull = null;
    private $privateNullToNull = null;
    private $privateValueChanged = 2;
    private $privateValueToSimilarValue = 1;
    private $privateExpressionToExpressionValue = 106;
}
PHP
            ,
            $astLocator
        );

        $fromClassReflector = new ClassReflector($fromLocator);
        $toClassReflector   = new ClassReflector($toLocator);
        $fromClass          = $fromClassReflector->reflect('TheClass');
        $toClass            = $toClassReflector->reflect('TheClass');

        $properties = [
            'publicNothingToNothing'               => [],
            'publicNothingToNull'                  => [],
            'publicNullToNull'                     => [],
            'publicValueChanged'                   => ['[BC] CHANGED: Property TheClass#$publicValueChanged changed default value from 1 to 2'],
            'publicValueToSimilarValue'            => ['[BC] CHANGED: Property TheClass#$publicValueToSimilarValue changed default value from \'1\' to 1'],
            'publicExpressionToExpressionValue'    => [],
            'protectedNothingToNothing'            => [],
            'protectedNothingToNull'               => [],
            'protectedNullToNull'                  => [],
            'protectedValueChanged'                => ['[BC] CHANGED: Property TheClass#$protectedValueChanged changed default value from 1 to 2'],
            'protectedValueToSimilarValue'         => ['[BC] CHANGED: Property TheClass#$protectedValueToSimilarValue changed default value from \'1\' to 1'],
            'protectedExpressionToExpressionValue' => [],
            'privateNothingToNothing'              => [],
            'privateNothingToNull'                 => [],
            'privateNullToNull'                    => [],
            'privateValueChanged'                  => ['[BC] CHANGED: Property TheClass#$privateValueChanged changed default value from 1 to 2'],
            'privateValueToSimilarValue'           => ['[BC] CHANGED: Property TheClass#$privateValueToSimilarValue changed default value from \'1\' to 1'],
            'privateExpressionToExpressionValue'   => [],
        ];

        return array_combine(
            array_keys($properties),
            array_map(
                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                    return [
                        $fromClass->getProperty($property),
                        $toClass->getProperty($property),
                        $errorMessages,
                    ];
                },
                array_keys($properties),
                $properties
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\ApiCompare\Change;
9			use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged;
10			use Roave\BetterReflection\BetterReflection;
11			use Roave\BetterReflection\Reflection\ReflectionProperty;
12			use Roave\BetterReflection\Reflector\ClassReflector;
13			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
14			use function array_combine;
15			use function array_keys;
16			use function array_map;
17			use function iterator_to_array;
18
19			/**
20			* @covers \Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged
21			*/
22			final class PropertyDefaultValueChangedTest extends TestCase
23			{
24			/**
25			* @dataProvider propertiesToBeTested
26			*
27			* @param string[] $expectedMessages
28			*/
29			public function testDiffs(
30			ReflectionProperty $fromFunction,
31			ReflectionProperty $toFunction,
32			array $expectedMessages
33			) : void {
34			$changes = (new PropertyDefaultValueChanged())
35			->compare($fromFunction, $toFunction);
36
37			self::assertSame(
38			$expectedMessages,
39			array_map(function (Change $change) : string {
40			return $change->__toString();
41			}, iterator_to_array($changes))
42			);
43			}
44
45			/** @return (string[]\|ReflectionProperty)[][] */
46			public function propertiesToBeTested() : array
47			{
48			$astLocator = (new BetterReflection())->astLocator();
49
50			$fromLocator = new StringSourceLocator(
51			<<<'PHP'
52			<?php
53
54			class TheClass {
55			public $publicNothingToNothing;
56			public $publicNothingToNull;
57			public $publicNullToNull = null;
58			public $publicValueChanged = 1;
59			public $publicValueToSimilarValue = '1';
60			public $publicExpressionToExpressionValue = 101 + 5;
61
62			protected $protectedNothingToNothing;
63			protected $protectedNothingToNull;
64			protected $protectedNullToNull = null;
65			protected $protectedValueChanged = 1;
66			protected $protectedValueToSimilarValue = '1';
67			protected $protectedExpressionToExpressionValue = 101 + 5;
68
69			private $privateNothingToNothing;
70			private $privateNothingToNull;
71			private $privateNullToNull = null;
72			private $privateValueChanged = 1;
73			private $privateValueToSimilarValue = '1';
74			private $privateExpressionToExpressionValue = 101 + 5;
75			}
76			PHP
77			,
78			$astLocator
79			);
80
81			$toLocator = new StringSourceLocator(
82			<<<'PHP'
83			<?php
84
85			class TheClass {
86			public $publicNothingToNothing;
87			public $publicNothingToNull = null;
88			public $publicNullToNull = null;
89			public $publicValueChanged = 2;
90			public $publicValueToSimilarValue = 1;
91			public $publicExpressionToExpressionValue = 106;
92
93			protected $protectedNothingToNothing;
94			protected $protectedNothingToNull = null;
95			protected $protectedNullToNull = null;
96			protected $protectedValueChanged = 2;
97			protected $protectedValueToSimilarValue = 1;
98			protected $protectedExpressionToExpressionValue = 106;
99
100			private $privateNothingToNothing;
101			private $privateNothingToNull = null;
102			private $privateNullToNull = null;
103			private $privateValueChanged = 2;
104			private $privateValueToSimilarValue = 1;
105			private $privateExpressionToExpressionValue = 106;
106			}
107			PHP
108			,
109			$astLocator
110			);
111
112			$fromClassReflector = new ClassReflector($fromLocator);
113			$toClassReflector = new ClassReflector($toLocator);
114			$fromClass = $fromClassReflector->reflect('TheClass');
115			$toClass = $toClassReflector->reflect('TheClass');
116
117			$properties = [
118			'publicNothingToNothing' => [],
119			'publicNothingToNull' => [],
120			'publicNullToNull' => [],
121			'publicValueChanged' => ['[BC] CHANGED: Property TheClass#$publicValueChanged changed default value from 1 to 2'],
122			'publicValueToSimilarValue' => ['[BC] CHANGED: Property TheClass#$publicValueToSimilarValue changed default value from \'1\' to 1'],
123			'publicExpressionToExpressionValue' => [],
124			'protectedNothingToNothing' => [],
125			'protectedNothingToNull' => [],
126			'protectedNullToNull' => [],
127			'protectedValueChanged' => ['[BC] CHANGED: Property TheClass#$protectedValueChanged changed default value from 1 to 2'],
128			'protectedValueToSimilarValue' => ['[BC] CHANGED: Property TheClass#$protectedValueToSimilarValue changed default value from \'1\' to 1'],
129			'protectedExpressionToExpressionValue' => [],
130			'privateNothingToNothing' => [],
131			'privateNothingToNull' => [],
132			'privateNullToNull' => [],
133			'privateValueChanged' => ['[BC] CHANGED: Property TheClass#$privateValueChanged changed default value from 1 to 2'],
134			'privateValueToSimilarValue' => ['[BC] CHANGED: Property TheClass#$privateValueToSimilarValue changed default value from \'1\' to 1'],
135			'privateExpressionToExpressionValue' => [],
136			];
137
138			return array_combine(
139			array_keys($properties),
140			array_map(
141			function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
142			return [
143			$fromClass->getProperty($property),
144			$toClass->getProperty($property),
145			$errorMessages,
146			];
147			},
148			array_keys($properties),
149			$properties
150			)
151			);
152			}
153			}
154

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

propertiesToBeTested() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like