PropertyScopeChangedTest::propertiesToBeTested() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-16 22:48 UTC

PropertyScopeChangedTest::propertiesToBeTested() B

↳ Parent: PropertyScopeChangedTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	96
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	96
rs	8.3859
c	0
b	0
f	0
cc	1
eloc	42
nc	1
nop	0

How to fix Long Method

<?php

declare(strict_types=1);

namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;

use PHPUnit\Framework\TestCase;
use Roave\ApiCompare\Change;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged;
use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyScopeChanged;
use Roave\BetterReflection\BetterReflection;
use Roave\BetterReflection\Reflection\ReflectionProperty;
use Roave\BetterReflection\Reflector\ClassReflector;
use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
use function array_map;
use function iterator_to_array;

/**
 * @covers \Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyScopeChanged
 */
final class PropertyScopeChangedTest extends TestCase
{
    /**
     * @dataProvider propertiesToBeTested
     *
     * @param string[] $expectedMessages
     */
    public function testDiffs(
        ReflectionProperty $fromFunction,
        ReflectionProperty $toFunction,
        array $expectedMessages
    ) : void {
        $changes = (new PropertyScopeChanged())
            ->compare($fromFunction, $toFunction);

        self::assertSame(
            $expectedMessages,
            array_map(function (Change $change) : string {
                return $change->__toString();
            }, iterator_to_array($changes))
        );
    }

    /** @return (string[]|ReflectionProperty)[][] */
    public function propertiesToBeTested() : array
    {
        $astLocator = (new BetterReflection())->astLocator();

        $fromLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public $publicInstanceToStatic;
    public static $publicStaticToInstance;
    public $publicInstanceToInstance;
    public static $publicStaticToStatic;
    
    protected $protectedInstanceToStatic;
    protected static $protectedStaticToInstance;
    protected $protectedInstanceToInstance;
    protected static $protectedStaticToStatic;
    
    private $privateInstanceToStatic;
    private static $privateStaticToInstance;
    private $privateInstanceToInstance;
    private static $privateStaticToStatic;
}
PHP
            ,
            $astLocator
        );

        $toLocator = new StringSourceLocator(
            <<<'PHP'
<?php

class TheClass {
    public static $publicInstanceToStatic;
    public $publicStaticToInstance;
    public $publicInstanceToInstance;
    public static $publicStaticToStatic;
    
    protected static $protectedInstanceToStatic;
    protected $protectedStaticToInstance;
    protected $protectedInstanceToInstance;
    protected static $protectedStaticToStatic;
    
    private static $privateInstanceToStatic;
    private $privateStaticToInstance;
    private $privateInstanceToInstance;
    private static $privateStaticToStatic;
}
PHP
            ,
            $astLocator
        );

        $fromClassReflector = new ClassReflector($fromLocator);
        $toClassReflector   = new ClassReflector($toLocator);
        $fromClass          = $fromClassReflector->reflect('TheClass');
        $toClass            = $toClassReflector->reflect('TheClass');

        $properties = [
            'publicInstanceToStatic'   => [
                '[BC] CHANGED: Property $publicInstanceToStatic of TheClass changed scope from instance to static',
            ],
            'publicStaticToInstance'   => [
                '[BC] CHANGED: Property $publicStaticToInstance of TheClass changed scope from static to instance',
            ],
            'publicInstanceToInstance' => [],
            'publicStaticToStatic'     => [],

            'protectedInstanceToStatic'    => [
                '[BC] CHANGED: Property $protectedInstanceToStatic of TheClass changed scope from instance to static',
            ],
            'protectedStaticToInstance'    => [
                '[BC] CHANGED: Property $protectedStaticToInstance of TheClass changed scope from static to instance',
            ],
            'protectedInstanceToInstance' => [],
            'protectedStaticToStatic'      => [],

            'privateInstanceToStatic'    => [],
            'privateStaticToInstance'   => [],
            'privateInstanceToInstance' => [],
            'privateStaticToStatic'     => [],
        ];

        return array_combine(
            array_keys($properties),
            array_map(
                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
                    return [
                        $fromClass->getProperty($property),
                        $toClass->getProperty($property),
                        $errorMessages,
                    ];
                },
                array_keys($properties),
                $properties
            )
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RoaveTest\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;
6
7			use PHPUnit\Framework\TestCase;
8			use Roave\ApiCompare\Change;
9			use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyDefaultValueChanged;
10			use Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyScopeChanged;
11			use Roave\BetterReflection\BetterReflection;
12			use Roave\BetterReflection\Reflection\ReflectionProperty;
13			use Roave\BetterReflection\Reflector\ClassReflector;
14			use Roave\BetterReflection\SourceLocator\Type\StringSourceLocator;
15			use function array_map;
16			use function iterator_to_array;
17
18			/**
19			* @covers \Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased\PropertyScopeChanged
20			*/
21			final class PropertyScopeChangedTest extends TestCase
22			{
23			/**
24			* @dataProvider propertiesToBeTested
25			*
26			* @param string[] $expectedMessages
27			*/
28			public function testDiffs(
29			ReflectionProperty $fromFunction,
30			ReflectionProperty $toFunction,
31			array $expectedMessages
32			) : void {
33			$changes = (new PropertyScopeChanged())
34			->compare($fromFunction, $toFunction);
35
36			self::assertSame(
37			$expectedMessages,
38			array_map(function (Change $change) : string {
39			return $change->__toString();
40			}, iterator_to_array($changes))
41			);
42			}
43
44			/** @return (string[]\|ReflectionProperty)[][] */
45			public function propertiesToBeTested() : array
46			{
47			$astLocator = (new BetterReflection())->astLocator();
48
49			$fromLocator = new StringSourceLocator(
50			<<<'PHP'
51			<?php
52
53			class TheClass {
54			public $publicInstanceToStatic;
55			public static $publicStaticToInstance;
56			public $publicInstanceToInstance;
57			public static $publicStaticToStatic;
58
59			protected $protectedInstanceToStatic;
60			protected static $protectedStaticToInstance;
61			protected $protectedInstanceToInstance;
62			protected static $protectedStaticToStatic;
63
64			private $privateInstanceToStatic;
65			private static $privateStaticToInstance;
66			private $privateInstanceToInstance;
67			private static $privateStaticToStatic;
68			}
69			PHP
70			,
71			$astLocator
72			);
73
74			$toLocator = new StringSourceLocator(
75			<<<'PHP'
76			<?php
77
78			class TheClass {
79			public static $publicInstanceToStatic;
80			public $publicStaticToInstance;
81			public $publicInstanceToInstance;
82			public static $publicStaticToStatic;
83
84			protected static $protectedInstanceToStatic;
85			protected $protectedStaticToInstance;
86			protected $protectedInstanceToInstance;
87			protected static $protectedStaticToStatic;
88
89			private static $privateInstanceToStatic;
90			private $privateStaticToInstance;
91			private $privateInstanceToInstance;
92			private static $privateStaticToStatic;
93			}
94			PHP
95			,
96			$astLocator
97			);
98
99			$fromClassReflector = new ClassReflector($fromLocator);
100			$toClassReflector = new ClassReflector($toLocator);
101			$fromClass = $fromClassReflector->reflect('TheClass');
102			$toClass = $toClassReflector->reflect('TheClass');
103
104			$properties = [
105			'publicInstanceToStatic' => [
106			'[BC] CHANGED: Property $publicInstanceToStatic of TheClass changed scope from instance to static',
107			],
108			'publicStaticToInstance' => [
109			'[BC] CHANGED: Property $publicStaticToInstance of TheClass changed scope from static to instance',
110			],
111			'publicInstanceToInstance' => [],
112			'publicStaticToStatic' => [],
113
114			'protectedInstanceToStatic' => [
115			'[BC] CHANGED: Property $protectedInstanceToStatic of TheClass changed scope from instance to static',
116			],
117			'protectedStaticToInstance' => [
118			'[BC] CHANGED: Property $protectedStaticToInstance of TheClass changed scope from static to instance',
119			],
120			'protectedInstanceToInstance' => [],
121			'protectedStaticToStatic' => [],
122
123			'privateInstanceToStatic' => [],
124			'privateStaticToInstance' => [],
125			'privateInstanceToInstance' => [],
126			'privateStaticToStatic' => [],
127			];
128
129			return array_combine(
130			array_keys($properties),
131			array_map(
132			function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
133			return [
134			$fromClass->getProperty($property),
135			$toClass->getProperty($property),
136			$errorMessages,
137			];
138			},
139			array_keys($properties),
140			$properties
141			)
142			);
143			}
144			}
145

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

PropertyScopeChangedTest::propertiesToBeTested() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like