PropertyVisibilityReduced::compare() - Code Metrics - Inspection of "Verify method, function, property, constant and in..." - Roave/BackwardCompatibilityCheck - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#38)

by Marco

created 2018-04-16 22:48 UTC

PropertyVisibilityReduced::compare() A

↳ Parent: PropertyVisibilityReduced

Complexity

Conditions	2
Paths	2

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	12
nc	2
nop	2

<?php

declare(strict_types=1);

namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;

use Roave\ApiCompare\Change;
use Roave\ApiCompare\Changes;
use Roave\BetterReflection\Reflection\ReflectionProperty;
use function sprintf;

final class PropertyVisibilityReduced implements PropertyBased
{
    private const VISIBILITY_PRIVATE = 'private';

    private const VISIBILITY_PROTECTED = 'protected';

    private const VISIBILITY_PUBLIC = 'public';

    public function compare(ReflectionProperty $fromProperty, ReflectionProperty $toProperty) : Changes
    {
        $visibilityFrom = $this->propertyVisibility($fromProperty);
        $visibilityTo   = $this->propertyVisibility($toProperty);

        if ($visibilityFrom <= $visibilityTo) {
            return Changes::new();
        }

        return Changes::fromArray([Change::changed(
            sprintf(
                'Property %s#$%s visibility reduced from %s to %s',
                $fromProperty->getDeclaringClass()->getName(),
                $fromProperty->getName(),
                $visibilityFrom,
                $visibilityTo
            ),
            true
        )]);
    }

    private function propertyVisibility(ReflectionProperty $property) : string
    {
        if ($property->isPublic()) {
            return self::VISIBILITY_PUBLIC;
        }

        if ($property->isProtected()) {
            return self::VISIBILITY_PROTECTED;
        }

        return self::VISIBILITY_PRIVATE;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Roave\ApiCompare\Comparator\BackwardsCompatibility\PropertyBased;
6
7			use Roave\ApiCompare\Change;
8			use Roave\ApiCompare\Changes;
9			use Roave\BetterReflection\Reflection\ReflectionProperty;
10			use function sprintf;
11
12			final class PropertyVisibilityReduced implements PropertyBased
13			{
14			private const VISIBILITY_PRIVATE = 'private';
15
16			private const VISIBILITY_PROTECTED = 'protected';
17
18			private const VISIBILITY_PUBLIC = 'public';
19
20			public function compare(ReflectionProperty $fromProperty, ReflectionProperty $toProperty) : Changes
21			{
22			$visibilityFrom = $this->propertyVisibility($fromProperty);
23			$visibilityTo = $this->propertyVisibility($toProperty);
24
25			if ($visibilityFrom <= $visibilityTo) {
26			return Changes::new();
27			}
28
29			return Changes::fromArray([Change::changed(
30			sprintf(
31			'Property %s#$%s visibility reduced from %s to %s',
32			$fromProperty->getDeclaringClass()->getName(),
33			$fromProperty->getName(),
34			$visibilityFrom,
35			$visibilityTo
36			),
37			true
38			)]);
39			}
40
41			private function propertyVisibility(ReflectionProperty $property) : string
42			{
43			if ($property->isPublic()) {
44			return self::VISIBILITY_PUBLIC;
45			}
46
47			if ($property->isProtected()) {
48			return self::VISIBILITY_PROTECTED;
49			}
50
51			return self::VISIBILITY_PRIVATE;
52			}
53			}
54

Roave / BackwardCompatibilityCheck

Pull Request — master (#38)

PropertyVisibilityReduced::compare() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like