View GitHub Repository BackwardCompatibilityCheck

Schedule Inspection
Subscribe
Passed
Pull Request — master (#109)
by Marco
05:58 queued 03:28
created
Status
Category
Toggle Patches
test/unit/DetectChanges/BCBreak/TraitBased/TraitBecameInterfaceTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -33,7 +33,7 @@  discard block
 
 block discarded – undo
33 33
34 34 
         self::assertSame(
35 35 
             $expectedMessages,
36 
-            array_map(function (Change $change) : string {
36 
+            array_map(function(Change $change) : string {
37 37 
                 return $change->__toString();
38 38 
             }, iterator_to_array($changes))
39 39 
         );
 
@@ -63,7 +63,7 @@  discard block
 
 block discarded – undo
63 63 
             ,
64 64 
             $locator
65 65 
         ));
66 
-        $toReflector   = new ClassReflector(new StringSourceLocator(
66 
+        $toReflector = new ClassReflector(new StringSourceLocator(
67 67 
             <<<'PHP'
68 68 
 <?php
69 69 
 
@@ -102,7 +102,7 @@  discard block
 
 block discarded – undo
102 102 
         return array_combine(
103 103 
             array_keys($classes),
104 104 
             array_map(
105 
-                function (string $className, array $errors) use ($fromReflector, $toReflector) : array {
105 
+                function(string $className, array $errors) use ($fromReflector, $toReflector) : array {
106 106 
                     return [
107 107 
                         $fromReflector->reflect($className),
108 108 
                         $toReflector->reflect($className),
Please login to merge, or discard this patch.
DetectChanges/BCBreak/PropertyBased/PropertyDocumentedTypeChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138 
         return array_combine(
139 139 
             array_keys($properties),
140 140 
             array_map(
141 
-                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
141 
+                function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
142 142 
                     return [
143 143 
                         $fromClass->getProperty($property),
144 144 
                         $toClass->getProperty($property),
Please login to merge, or discard this patch.
test/unit/DetectChanges/BCBreak/PropertyBased/PropertyScopeChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138 
         return array_combine(
139 139 
             array_keys($properties),
140 140 
             array_map(
141 
-                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
141 
+                function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
142 142 
                     return [
143 143 
                         $fromClass->getProperty($property),
144 144 
                         $toClass->getProperty($property),
Please login to merge, or discard this patch.
DetectChanges/BCBreak/PropertyBased/PropertyDefaultValueChangedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138 
         return array_combine(
139 139 
             array_keys($properties),
140 140 
             array_map(
141 
-                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
141 
+                function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
142 142 
                     return [
143 143 
                         $fromClass->getProperty($property),
144 144 
                         $toClass->getProperty($property),
Please login to merge, or discard this patch.
unit/DetectChanges/BCBreak/PropertyBased/PropertyVisibilityReducedTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -36,7 +36,7 @@  discard block
 
 block discarded – undo
36 36
37 37 
         self::assertSame(
38 38 
             $expectedMessages,
39 
-            array_map(function (Change $change) : string {
39 
+            array_map(function(Change $change) : string {
40 40 
                 return $change->__toString();
41 41 
             }, iterator_to_array($changes))
42 42 
         );
 
@@ -138,7 +138,7 @@  discard block
 
 block discarded – undo
138 138 
         return array_combine(
139 139 
             array_keys($properties),
140 140 
             array_map(
141 
-                function (string $property, array $errorMessages) use ($fromClass, $toClass) : array {
141 
+                function(string $property, array $errorMessages) use ($fromClass, $toClass) : array {
142 142 
                     return [
143 143 
                         $fromClass->getProperty($property),
144 144 
                         $toClass->getProperty($property),
Please login to merge, or discard this patch.
test/unit/DetectChanges/Variance/TypeIsContravariantTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -224,7 +224,7 @@  discard block
 
 block discarded – undo
224 224 
         return array_merge(
225 225 
             [[null]],
226 226 
             array_merge(...array_map(
227 
-                function (string $type) use ($reflector) : array {
227 
+                function(string $type) use ($reflector) : array {
228 228 
                     return [
229 229 
                         [ReflectionType::createFromTypeAndReflector($type, false, $reflector)],
230 230 
                         [ReflectionType::createFromTypeAndReflector($type, true, $reflector)],
 
@@ -248,7 +248,7 @@  discard block
 
 block discarded – undo
248 248 
     /** @dataProvider existingNullableTypeStrings */
249 249 
     public function testContravarianceConsidersNullability(string $type) : void
250 250 
     {
251 
-        $reflector   = new ClassReflector(new StringSourceLocator(
251 
+        $reflector = new ClassReflector(new StringSourceLocator(
252 252 
             <<<'PHP'
253 253 
 <?php
254 254
Please login to merge, or discard this patch.
test/unit/DetectChanges/Variance/TypeIsCovariantTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -235,7 +235,7 @@  discard block
 
 block discarded – undo
235 235 
         return array_merge(
236 236 
             [[null]],
237 237 
             array_merge(...array_map(
238 
-                function (string $type) use ($reflector) : array {
238 
+                function(string $type) use ($reflector) : array {
239 239 
                     return [
240 240 
                         [ReflectionType::createFromTypeAndReflector($type, false, $reflector)],
241 241 
                         [ReflectionType::createFromTypeAndReflector($type, true, $reflector)],
 
@@ -259,7 +259,7 @@  discard block
 
 block discarded – undo
259 259 
     /** @dataProvider existingNullableTypeStrings */
260 260 
     public function testCovarianceConsidersNullability(string $type) : void
261 261 
     {
262 
-        $reflector   = new ClassReflector(new StringSourceLocator(
262 
+        $reflector = new ClassReflector(new StringSourceLocator(
263 263 
             <<<'PHP'
264 264 
 <?php
265 265
Please login to merge, or discard this patch.
src/DetectChanges/BCBreak/MethodBased/MethodConcretenessChanged.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -17,7 +17,7 @@
 
 block discarded – undo
17 17 
 {
18 18 
     public function __invoke(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
19 19 
     {
20 
-        if ($fromMethod->isAbstract() || ! $toMethod->isAbstract()) {
20 
+        if ($fromMethod->isAbstract() || !$toMethod->isAbstract()) {
21 21 
             return Changes::empty();
22 22 
         }
23 23
Please login to merge, or discard this patch.
src/DetectChanges/BCBreak/MethodBased/OnlyProtectedMethodChanged.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch 
@@ -22,7 +22,7 @@
 
 block discarded – undo
22 22
23 23 
     public function __invoke(ReflectionMethod $fromMethod, ReflectionMethod $toMethod) : Changes
24 24 
     {
25 
-        if (! $fromMethod->isProtected()) {
25 
+        if (!$fromMethod->isProtected()) {
26 26 
             return Changes::empty();
27 27 
         }
28 28
Please login to merge, or discard this patch.